From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74A06C433F5 for ; Fri, 15 Apr 2022 05:25:25 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nfESS-0007M6-Vt; Fri, 15 Apr 2022 05:25:24 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nfESS-0007Lz-0t for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Apr 2022 05:25:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rwvsmsnne7SnULh2hbKByo2WuoxQie2Xsqxi/Bxqgj8=; b=OYg+PRmtVdEjQEONkCZwn3Ito3 xs3iuD1ZqEw5QoVWASWjfL61R9JEIp9XQhtX9mxKCbeIzsfDRCC1aScsqnIH4fue1kMNqi+0TITFs I3eFvcSJrgdnBxwa6FUQ9q6HxMR+jFDA8srumhXa7ckMm4lTT87AQjoI/WbeLoP9NnjU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rwvsmsnne7SnULh2hbKByo2WuoxQie2Xsqxi/Bxqgj8=; b=nOTamDyRNTzi1P8uxP3o4qPgQh wEwRuTyGCLCwl9afFpGlwhrZDqFKWarOFyX9HtDYEO+YVC9pk2ImjMov71+1DAgwbGqShzx/LNegp cbHL9u0BZL2Vj7rdfOpC5mhwLUunyfgCd/UfuuiR2Uvy7+K4vze/ILYG4meZXa3sMIi0=; Received: from esa6.hgst.iphmx.com ([216.71.154.45]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nfESQ-0009dA-GB for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Apr 2022 05:25:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1650000323; x=1681536323; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wC6/PVYH+J9es8aT7sK5ZaGwsGnDQHOFu7y4PW6r0NI=; b=Lbal0ZCH/kozYxQ0vezJl70LO7XoZHIu1CSBBuK3jNGvkqxdM4KWRuKV Xm4Klm3CpunytJsMCQzZ9l7vyfaWNwLiIgtH9s7gghF/2F1Z2WdJrVN2v WKc/ZeV9+lXKsUv3RF+I1LK+3aXdKrQba6Z0wxx/DLjA0XlmGvVmNCQr5 CZepB3euzbLWYtOHVkQuEb0fKCCZTXfe/4eYL1qDD5ShMefOsx8s95jCt UR+JKu1GAXd9h7Z/0Kn5mdyc6YD3WTXATdSeMAQzsw63HYGNgMB1xCTtf sEDZj+4c6SS2QvgOKDAINLL73svGv6IhuYmwX7OUZQ52ZYGCZLE1yA0Mz A==; X-IronPort-AV: E=Sophos;i="5.90,261,1643644800"; d="scan'208";a="198866635" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 15 Apr 2022 13:09:49 +0800 IronPort-SDR: U7M0HTW0mGzPUYj+5qHyM3J9AJUUMRwtZYEf4nVNoFt1nt+DOn8L6iIWJBwI6DxMpY+s9WatXi Q49yIECPQPgpopGUjl6Kg3AHi444OG4IYLtOWi6MpNaHy4qTfXVX43JauAOCeyok1lzG4Lp+St dCfLCkZUU/K9RFSTodIns4xhbfAjfGbl9jGL8m9sSU8rSDzAeFeeIUcW5gXXcEJl+zOweBDTeh XtMCCVDAVloBa7kkb2iB5LLnu3zq760XPz5sLZzyBWFiUslHo0EPwyO481MhfMOpbnAUudDmcJ Zkbif/Tmn1nQIrMFQXrJKuhe Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 21:40:13 -0700 IronPort-SDR: GhcttepUJoUgWcF9BQXtnTM0H2i0ifyIergpnqHpXGfeyNSTpJleEomzwmX4v9sV4GV2Z2kdSQ 3yCDkMcnxiBnkf5T2ZWa3rb9Mtr1e44A+5Oh0tbplDzdaV4y9WeqYQkWTKy71lpl6OSlwrDxZQ Xbd5mwX9FI4fmyqQnoiCskNeuzP8Tsw/uR3VsLAiH16WZDDn1TjRRO7VGUA1BWl6gPJU/ytk8f YC6buM1wVV9I+98qelkIfBmEHptspaXIdqs6+PUJ/ksSLHMOXsiZJSCFj/Ctq/D7aEbrEoi2cF LmY= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 22:09:50 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KfksS2bw5z1SVpC for ; Thu, 14 Apr 2022 22:09:48 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1649999387; x=1652591388; bh=wC6/PVYH+J9es8aT7sK5ZaGwsGnDQHOFu7y 4PW6r0NI=; b=A2KBgHYSLIEiloAT36KBlSnrdHo/5oKL9FrIFynJT5WRtSMAWFY bOfFXbV9aPU/SW14KWhWGoxgvZNpDxlNmySfQsvY8YKVzB0GPsCqMriDKUnvzDGe gxI79wWgz9d4ps/B6Xlf+gQiJxT1WJ1ZvXg2qG+PSKztllpdqubmLYAwOO/nz5St h4S8KA8vLEE0CNTHJjAA8Hcfkt3KCfxgWm/synsXo5jFqWGlKXVMBpl0q6F/zUl8 QMkInWk2S7O06U7jACfYKTCYPrMyVz97bbnYwKLXgej41iNgxlqjzLyt5sjDI1Lg BUEAK+PEVHrx0bfVbsoqkvKO8/sBQvwsP4Q== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id pIhCVkHxA0rR for ; Thu, 14 Apr 2022 22:09:47 -0700 (PDT) Received: from [10.225.163.9] (unknown [10.225.163.9]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KfksM3c9Fz1Rvlx; Thu, 14 Apr 2022 22:09:43 -0700 (PDT) Message-ID: <62ebc311-e5ef-cea5-5236-0c83d1a3eb64@opensource.wdc.com> Date: Fri, 15 Apr 2022 14:09:42 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Christoph Hellwig , Jens Axboe References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-11-hch@lst.de> Organization: Western Digital Research In-Reply-To: <20220415045258.199825-11-hch@lst.de> X-Headers-End: 1nfESQ-0009dA-GB Subject: Re: [f2fs-dev] [PATCH 10/27] mm: use bdev_is_zoned in claim_swapfile X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Damien Le Moal via Linux-f2fs-devel Reply-To: Damien Le Moal Cc: jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, cluster-devel@redhat.com, xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org, linux-um@lists.infradead.org, nbd@other.debian.org, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 4/15/22 13:52, Christoph Hellwig wrote: > Use the bdev based helper instead of poking into the queue. > > Signed-off-by: Christoph Hellwig > --- > mm/swapfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 63c61f8b26118..4c7537162af5e 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -2761,7 +2761,7 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode) > * write only restriction. Hence zoned block devices are not > * suitable for swapping. Disallow them here. > */ > - if (blk_queue_is_zoned(p->bdev->bd_disk->queue)) > + if (bdev_is_zoned(p->bdev)) > return -EINVAL; > p->flags |= SWP_BLKDEV; > } else if (S_ISREG(inode->i_mode)) { Looks good. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel