linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Sheng Yong <shengyong@oppo.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v4] f2fs: fix to enable compress for newly created file if extension matches
Date: Thu, 24 Nov 2022 10:38:21 +0800	[thread overview]
Message-ID: <63c416b9-b5cc-7c7d-1dad-ef00d0512d93@kernel.org> (raw)
In-Reply-To: <Y36QoFTGTbAAJpdX@google.com>

On 2022/11/24 5:29, Jaegeuk Kim wrote:
>>> +	if (S_ISDIR(inode->i_mode))
>>> +		goto inherit_comp;
>>
>> Documentation/filesystems/f2fs.rst
>>
>> - Priority in between FS_COMPR_FL, FS_NOCOMP_FS, extensions:
>>
>>    * compress_extension=so; nocompress_extension=zip; chattr +c dir; touch
>>      dir/foo.so; touch dir/bar.zip; touch dir/baz.txt; then foo.so and baz.txt
>>      should be compresse, bar.zip should be non-compressed. chattr +c dir/bar.zip
>>      can enable compress on bar.zip.
>>
>> It looks nocompress_extension has higher priority than flag inheriting?
> 
> I think so.

Hi Sheng, Jaegeuk,

Yup, I guess I misunderstand the code. :)

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2022-11-24  2:38 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11 10:08 [f2fs-dev] [PATCH v2 1/2] f2fs: fix to enable compress for newly created file if extension matches Sheng Yong via Linux-f2fs-devel
2022-11-11 10:08 ` [f2fs-dev] [PATCH v2 2/2] f2fs: move set_file_temperature into f2fs_new_inode Sheng Yong via Linux-f2fs-devel
2022-11-11 10:20   ` Chao Yu
2022-11-14 22:40   ` Jaegeuk Kim
2022-11-11 10:20 ` [f2fs-dev] [PATCH v2 1/2] f2fs: fix to enable compress for newly created file if extension matches Chao Yu
2022-11-12  1:27 ` Jaegeuk Kim
2022-11-14  1:42   ` Sheng Yong via Linux-f2fs-devel
2022-11-14 16:05   ` Chao Yu
2022-11-14 22:39 ` Jaegeuk Kim
2022-11-15  0:20   ` Jaegeuk Kim
2022-11-15  1:49     ` Chao Yu
2022-11-15 16:01       ` [f2fs-dev] [PATCH v3] " Sheng Yong via Linux-f2fs-devel
2022-11-15 21:48         ` Jaegeuk Kim
2022-11-15 22:45         ` Jaegeuk Kim
2022-11-15 23:00         ` [f2fs-dev] [PATCH v4] " Jaegeuk Kim
2022-11-16  2:21           ` Sheng Yong via Linux-f2fs-devel
2022-11-17  1:13             ` Jaegeuk Kim
2022-11-23 21:46           ` [f2fs-dev] [PATCH v5] " Jaegeuk Kim
2022-11-24 14:27             ` Chao Yu
2022-11-17  1:12         ` [f2fs-dev] [PATCH v4] " Jaegeuk Kim
2022-11-23 14:54           ` Chao Yu
2022-11-23 16:09             ` Sheng Yong via Linux-f2fs-devel
2022-11-23 21:29             ` Jaegeuk Kim
2022-11-24  2:38               ` Chao Yu [this message]
2022-11-15  1:34   ` [f2fs-dev] [PATCH v2 1/2] " Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63c416b9-b5cc-7c7d-1dad-ef00d0512d93@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shengyong@oppo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).