From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE678EC875F for ; Fri, 8 Sep 2023 00:30:36 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qePOL-0005Zl-18; Fri, 08 Sep 2023 00:30:34 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qePOK-0005Ze-CS for linux-f2fs-devel@lists.sourceforge.net; Fri, 08 Sep 2023 00:30:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rWH+VGW4ynUEnqVgfK8Uo5vbTneevGaezyT5mB/sqg4=; b=SjJrGR2kh5oYXBTQm6/sFt8ngp 3sc5EUl87PZEjpwQa4X+s7QT8LJKwykduhx5jvdGNJs3AjxpSn1bBr5+Hcq4LwHHLzXa65oQ1eNgZ RPRHyieALcoVSQsUFIYl1aHhuYscD5WgrAXp3wi7umsvPTLmLL2qm6U55rwt4+vIBnfQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rWH+VGW4ynUEnqVgfK8Uo5vbTneevGaezyT5mB/sqg4=; b=Y3vBFAEUpYNnxMJHbOSWCn5NRP eKAAynLDTUUlcLLXXt2N7pjqVr4CbNH3K+McyX0Ida1XtLmJcxXXa1BA1c96CM61SYpPtOEAuIppt irmz+F1zl30U3T/uDCfVSV1t8Peq47YtFKsa/voJxlBr9J5KLSpGpC6wWrFDgtMzot4g=; Received: from mail-ej1-f41.google.com ([209.85.218.41]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qePOG-0006pI-5c for linux-f2fs-devel@lists.sourceforge.net; Fri, 08 Sep 2023 00:30:33 +0000 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-9a2a4a5472dso575100866b.1 for ; Thu, 07 Sep 2023 17:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694133021; x=1694737821; darn=lists.sourceforge.net; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rWH+VGW4ynUEnqVgfK8Uo5vbTneevGaezyT5mB/sqg4=; b=XhfuAIlH8iDpptnC52gcD4s2SrmIcjq/xdvrLoWb+WTV7kuqZSytVtwoywoH6Cf7Os 2GaoeJdBvpEVENdrYUEPOZEnq7Ux/IyCTh0rx7pV/+l61dOogGGLbQW6hLvw5TAnRhqe Zc+cwWDH0a50tBJTDgYASdI4R2lY3Rf1NeB3j2ivya+IiCw0Xe0OunNL+GdMES1b6FTh 8/PaWzNT7Fa6jZpxNysDSEpyZi4oAtEHylDS3MddYELxUMEiPC8NWnxKhRMdkAbd2XHu GCCDGv4xZRGMqK2HkoA75hnRyIh+1cnD5a3M/EY4EWYfM8hG8RqUQVvboXducs5jhmfr pWRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694133021; x=1694737821; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rWH+VGW4ynUEnqVgfK8Uo5vbTneevGaezyT5mB/sqg4=; b=BG19JnqniqNhgyIL3lJ3y4HPJOdfGVhKX0LC4rpHUXNICq4u7yTJUHAbplCVsTcS5c kwkc1ChLQ4VFlIsmIlDbThLJnqBlgIOH9PiDYe4tY3Qa1uj4hd1WYa5wjjlw2mM/M/vS /iXw4+Fovg5JUTEsRO/3mdezq2VVgR/Ih7YP3jdsRNYKvIzsKPBs8axq9Aw2+tiiYYHW zXVuol6JiTME5ZqVPklazc66pKCFVTzWnBRllowU+VXDXg+kapD5wGB5f5MjswkKL9I/ 9N/Mfw60GisFHg5UaX83Wu5FSmiyNxzPD++u0HwBdnAmEeqvLR1BgxBxdn242Y8IR9bz H8fQ== X-Gm-Message-State: AOJu0YwE+PNflBYam9OV44QqzpiaNg4a12Z5KhzmutvyJNFMMgtQ0j93 LaPX1UOumH36U//QK/G7AP4= X-Google-Smtp-Source: AGHT+IHUmcSd3yGn0Yc+fxHKH36GJLlYUzap6qvtcfMqwZgOcAgDOYhbcm3dJF4+eYZ9U6PvPuYQ6g== X-Received: by 2002:a17:907:6e87:b0:9a1:c69c:9388 with SMTP id sh7-20020a1709076e8700b009a1c69c9388mr4152809ejc.37.1694133021412; Thu, 07 Sep 2023 17:30:21 -0700 (PDT) Received: from [192.168.8.100] ([148.252.141.16]) by smtp.gmail.com with ESMTPSA id lz24-20020a170906fb1800b009932337747esm280974ejb.86.2023.09.07.17.30.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Sep 2023 17:30:21 -0700 (PDT) Message-ID: <6489b8cb-7d54-1e29-f192-a3449ed87fa1@gmail.com> Date: Fri, 8 Sep 2023 01:29:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Dave Chinner , Hao Xu References: <20230827132835.1373581-1-hao.xu@linux.dev> <20230827132835.1373581-8-hao.xu@linux.dev> <642de4e6-801d-fcad-a7ce-bfc6dec3b6e5@linux.dev> Content-Language: en-US From: Pavel Begunkov In-Reply-To: X-Headers-End: 1qePOG-0006pI-5c Subject: Re: [f2fs-dev] [PATCH 07/11] vfs: add nowait parameter for file_accessed() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , "Darrick J . Wong" , Dominique Martinet , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Stefan Roesch , Clay Harris , linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org, Matthew Wilcox , codalist@coda.cs.cmu.edu, cluster-devel@redhat.com, linux-cachefs@redhat.com, linux-ext4@vger.kernel.org, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-block@vger.kernel.org, Alexander Viro , io-uring@vger.kernel.org, Jens Axboe , Christian Brauner , netdev@vger.kernel.org, samba-technical@lists.samba.org, linux-unionfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, bpf@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 9/3/23 23:30, Dave Chinner wrote: > On Wed, Aug 30, 2023 at 02:11:31PM +0800, Hao Xu wrote: >> On 8/29/23 19:53, Matthew Wilcox wrote: >>> On Tue, Aug 29, 2023 at 03:46:13PM +0800, Hao Xu wrote: >>>> On 8/28/23 05:32, Matthew Wilcox wrote: >>>>> On Sun, Aug 27, 2023 at 09:28:31PM +0800, Hao Xu wrote: >>>>>> From: Hao Xu >>>>>> >>>>>> Add a boolean parameter for file_accessed() to support nowait semantics. >>>>>> Currently it is true only with io_uring as its initial caller. >>>>> >>>>> So why do we need to do this as part of this series? Apparently it >>>>> hasn't caused any problems for filemap_read(). >>>>> >>>> >>>> We need this parameter to indicate if nowait semantics should be enforced in >>>> touch_atime(), There are locks and maybe IOs in it. >>> >>> That's not my point. We currently call file_accessed() and >>> touch_atime() for nowait reads and nowait writes. You haven't done >>> anything to fix those. >>> >>> I suspect you can trim this patchset down significantly by avoiding >>> fixing the file_accessed() problem. And then come back with a later >>> patchset that fixes it for all nowait i/o. Or do a separate prep series >> >> I'm ok to do that. >> >>> first that fixes it for the existing nowait users, and then a second >>> series to do all the directory stuff. >>> >>> I'd do the first thing. Just ignore the problem. Directory atime >>> updates cause I/O so rarely that you can afford to ignore it. Almost >>> everyone uses relatime or nodiratime. >> >> Hi Matthew, >> The previous discussion shows this does cause issues in real >> producations: https://lore.kernel.org/io-uring/2785f009-2ebb-028d-8250-d5f3a30510f0@gmail.com/#:~:text=fwiw%2C%20we%27ve%20just%20recently%20had%20similar%20problems%20with%20io_uring%20read/write >> > > Then separate it out into it's own patch set so we can have a > discussion on the merits of requiring using noatime, relatime or > lazytime for really latency sensitive IO applications. Changing code > is not always the right solution... Separation sounds reasonable, but it can hardly be said that only latency sensitive apps would care about >1s nowait/async submission delays. Presumably, btrfs can improve on that, but it still looks like it's perfectly legit for filesystems do heavy stuff in timestamping like waiting for IO. Right? -- Pavel Begunkov _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel