From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E6DC4338F for ; Thu, 29 Jul 2021 00:37:51 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81D906103B; Thu, 29 Jul 2021 00:37:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 81D906103B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1m8u3a-0005x6-9I; Thu, 29 Jul 2021 00:37:50 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1m8u3Z-0005wz-1d for linux-f2fs-devel@lists.sourceforge.net; Thu, 29 Jul 2021 00:37:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qqWw+vA0vUKlaNP16C5Qr9XxtQOKXd8xnAmGappybWY=; b=Pt26kXx/2JFRHqgEFnei/Bzw28 XXp0gQl7rxrueGTeeWIEGkw9VnMN6BLMG1ABF/AuTkKFSgVtiTvMHsXXurZVh7NEJK9AMoYUFvtRr HqRedJ4u8B9nxkn8dAoU8qX5rsnoXm+UXCe0piazZDcth2KuUAyPUdYkuynVHI68mGQA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qqWw+vA0vUKlaNP16C5Qr9XxtQOKXd8xnAmGappybWY=; b=SI5MQRTuW7xe/wNZCb4O1daHKI tReuhhYJJW7/9c9MlGLbHbSe6vd7LEKVLRTR/+dwwPfY6m+veGO5lmYb689wPMOvtfKzq8ROuM9zu Z51wcjHTi02HvEbs6lGPqNU4HwTX0kXyiLA1jH6gtPdqMePlZEew9rgDxMO5+2ErWtVA=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1m8u3R-0007JK-Eu for linux-f2fs-devel@lists.sourceforge.net; Thu, 29 Jul 2021 00:37:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 95B616103B; Thu, 29 Jul 2021 00:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627519047; bh=HKuJ/sGTGEoDM22RJYLhczo7YamW8A07HkBki046ZPs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=W+nFlplcDkxPtR6FK3U73kf6y7ker+0HsuiHS9wyd/pPFKIAJmkEnT2usx4ttscK8 Ut3KSQ8XWplcwRZeWCg6WVpxygCU8Dgeo6jDQrieKEQdD5bZ7f5wAMFC/dW+X/GTqP AkgWoL7GBpUMLLea8K7BEcXRi4Yd+VGM6SvAa3QKqDwcKDQ2JNvtSODKHGx6tAkaQ+ GcEGdb7MTtemveefybubjMWR64Z70a6DPAJcRoiD49FBaeRC/3oSx46fTUFUkWQqXg a6LTP74Rr2/fCfDKtu94/BMf6+4Mjc/10Pn8PBIBVmA/+RyTKo0CU+j+9MrSus0zQl J1lZhmK8hjtvA== To: Daeho Jeong References: <20210726041819.2059593-1-daeho43@gmail.com> From: Chao Yu Message-ID: <66d9419d-5ce6-626c-7ac8-d0592f34ec31@kernel.org> Date: Thu, 29 Jul 2021 08:37:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Headers-End: 1m8u3R-0007JK-Eu Subject: Re: [f2fs-dev] [PATCH v4] f2fs: change fiemap way in printing compression chunk X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong , Eric Biggers , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/7/28 0:41, Daeho Jeong wrote: > How about adding this? > > skip_fill: > > if (map.m_pblk == COMPRESS_ADDR) { > > if (start_blk & (cluster_size - 1)) { > > ret = -EFSCORRUPTED; > > goto out; > > } > > compr_cluster = true; > > count_in_cluster = 1; > > } else if (compr_appended) { It seems we can add a separate patch to cover all cases that cluster metadata is going to be accessed rather than just fixing fiemap() case here? >>> Signed-off-by: Daeho Jeong >>> Tested-by: Eric Biggers Anyway, this patch looks good to me. Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel