From: Jens Axboe <axboe@kernel.dk>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] loop: drop caches if offset or block_size are changed
Date: Wed, 9 Jan 2019 20:51:59 -0700 [thread overview]
Message-ID: <6742173c-170b-555e-edc2-f70314eccabf@kernel.dk> (raw)
In-Reply-To: <20190110031714.39000-1-jaegeuk@kernel.org>
On 1/9/19 8:17 PM, Jaegeuk Kim wrote:
> If we don't drop caches used in old offset or block_size, we can get old data
> from new offset/block_size, which gives unexpected data to user.
>
> For example, Martijn found a loopback bug in the below scenario.
> 1) LOOP_SET_FD loads first two pages on loop file
> 2) LOOP_SET_STATUS64 changes the offset on the loop file
> 3) mount is failed due to the cached pages having wrong superblock
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2019-01-10 3:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 3:17 [PATCH] loop: drop caches if offset or block_size are changed Jaegeuk Kim
2019-01-10 3:51 ` Jens Axboe [this message]
2019-03-14 5:07 ` Gwendal Grignou
2019-04-15 21:13 ` grygorii tertychnyi via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6742173c-170b-555e-edc2-f70314eccabf@kernel.dk \
--to=axboe@kernel.dk \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).