From: Jeff Layton via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: NeilBrown <neil@brown.name>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Paulo Alcantara <pc@manguebit.org>,
Mike Marshall <hubcap@omnibond.com>,
linux-xfs@vger.kernel.org, Tyler Hicks <code@tyhicks.com>,
devel@lists.orangefs.org, Shyam Prasad N <sprasad@microsoft.com>,
Jan Harkes <jaharkes@cs.cmu.edu>,
linux-um@lists.infradead.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Eric Van Hensbergen <ericvh@kernel.org>,
Christian Brauner <brauner@kernel.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Trond Myklebust <trondmy@kernel.org>,
Dave Kleikamp <shaggy@kernel.org>,
David Hildenbrand <david@redhat.com>,
linux-cifs@vger.kernel.org, linux-nilfs@vger.kernel.org,
Hugh Dickins <hughd@google.com>,
codalist@coda.cs.cmu.edu, Namjae Jeon <linkinjeon@kernel.org>,
Yangtao Li <frank.li@vivo.com>,
ocfs2-devel@lists.linux.dev, Jaegeuk Kim <jaegeuk@kernel.org>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Theodore Ts'o <tytso@mit.edu>,
Muchun Song <muchun.song@linux.dev>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net, gfs2@lists.linux.dev,
Anna Schumaker <anna@kernel.org>,
linux-efi@vger.kernel.org,
Martin Brandenburg <martin@omnibond.com>,
Kees Cook <kees@kernel.org>, Yuezhang Mo <yuezhang.mo@sony.com>,
Carlos Maiolino <cem@kernel.org>, Chris Mason <clm@fb.com>,
linux-mtd@lists.infradead.org, linux-hardening@vger.kernel.org,
Marc Dionne <marc.dionne@auristor.com>,
linux-afs@lists.infradead.org, Miklos Szeredi <miklos@szeredi.hu>,
coda@cs.cmu.edu, Viacheslav Dubeyko <slava@dubeyko.com>,
Ilya Dryomov <idryomov@gmail.com>,
linux-ext4@vger.kernel.org, Amir Goldstein <amir73il@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
ceph-devel@vger.kernel.org, Oscar Salvador <osalvador@suse.de>,
David Howells <dhowells@redhat.com>,
linux-nfs@vger.kernel.org,
Joseph Qi <joseph.qi@linux.alibaba.com>,
samba-technical@lists.samba.org, Steve French <sfrench@samba.org>,
Jeremy Kerr <jk@ozlabs.org>,
ntfs3@lists.linux.dev, Hans de Goede <hansg@kernel.org>,
jfs-discussion@lists.sourceforge.net, Jan Kara <jack@suse.cz>,
Dominique Martinet <asmadeus@codewreck.org>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
Bob Copeland <me@bobcopeland.com>,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
linux-mm@kvack.org, Andreas Dilger <adilger.kernel@dilger.ca>,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
Ard Biesheuvel <ardb@kernel.org>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
Richard Weinberger <richard@nod.at>,
Mark Fasheh <mark@fasheh.com>,
ecryptfs@vger.kernel.org, Tom Talpey <tom@talpey.com>,
Bharath SM <bharathsm@microsoft.com>,
"Tigran A. Aivazian" <aivazian.tigran@gmail.com>,
David Sterba <dsterba@suse.com>, Xiubo Li <xiubli@redhat.com>,
Ryusuke Konishi <konishi.ryusuke@gmail.com>,
v9fs@lists.linux.dev, linux-unionfs@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Sungjong Seo <sj1557.seo@samsung.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-karma-devel@lists.sourceforge.net,
linux-btrfs@vger.kernel.org, Joel Becker <jlbec@evilplan.org>
Subject: Re: [f2fs-dev] [PATCH] vfs: remove the excl argument from the ->create() inode_operation
Date: Thu, 06 Nov 2025 07:07:48 -0500 [thread overview]
Message-ID: <6758176514cdd6e2ceacb3bd0e4d63fb8784b7c6.camel@kernel.org> (raw)
In-Reply-To: <176237780417.634289.15818324160940255011@noble.neil.brown.name>
On Thu, 2025-11-06 at 08:23 +1100, NeilBrown wrote:
> On Thu, 06 Nov 2025, Jeff Layton wrote:
> > Since ce8644fcadc5 ("lookup_open(): expand the call of vfs_create()"),
> > the "excl" argument to the ->create() inode_operation is always set to
> > true. Remove it, and fix up all of the create implementations.
>
> nonono
>
>
> > @@ -3802,7 +3802,7 @@ static struct dentry *lookup_open(struct nameidata *nd, struct file *file,
> > }
> >
> > error = dir_inode->i_op->create(idmap, dir_inode, dentry,
> > - mode, open_flag & O_EXCL);
> > + mode);
>
> "open_flag & O_EXCL" is not the same as "true".
>
> It is true that "all calls to vfs_create() pass true for 'excl'"
> The same is NOT true for inode_operations.create.
>
I don't think this is a problem, actually:
Almost all of the existing ->create() operations ignore the "excl"
bool. There are only two that I found that do not: NFS and GFS2. Both
of those have an ->atomic_open() operation though, so lookup_open()
will never call ->create() for those filesystems. This means that -
>create() _is_ always called with excl == true.
--
Jeff Layton <jlayton@kernel.org>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2025-11-06 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 20:24 [f2fs-dev] [PATCH] vfs: remove the excl argument from the ->create() inode_operation Jeff Layton via Linux-f2fs-devel
2025-11-05 21:23 ` NeilBrown
2025-11-06 12:07 ` Jeff Layton via Linux-f2fs-devel [this message]
2025-11-06 18:01 ` Jeff Layton via Linux-f2fs-devel
2025-11-07 0:00 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6758176514cdd6e2ceacb3bd0e4d63fb8784b7c6.camel@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=adilger.kernel@dilger.ca \
--cc=agruenba@redhat.com \
--cc=aivazian.tigran@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=amir73il@gmail.com \
--cc=anna@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=ardb@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bharathsm@microsoft.com \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=clm@fb.com \
--cc=coda@cs.cmu.edu \
--cc=codalist@coda.cs.cmu.edu \
--cc=code@tyhicks.com \
--cc=david@redhat.com \
--cc=devel@lists.orangefs.org \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=dwmw2@infradead.org \
--cc=ecryptfs@vger.kernel.org \
--cc=ericvh@kernel.org \
--cc=frank.li@vivo.com \
--cc=gfs2@lists.linux.dev \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gustavoars@kernel.org \
--cc=hansg@kernel.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=hubcap@omnibond.com \
--cc=hughd@google.com \
--cc=idryomov@gmail.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jaharkes@cs.cmu.edu \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jk@ozlabs.org \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=johannes@sipsolutions.net \
--cc=joseph.qi@linux.alibaba.com \
--cc=kees@kernel.org \
--cc=konishi.ryusuke@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-karma-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=marc.dionne@auristor.com \
--cc=mark@fasheh.com \
--cc=martin@omnibond.com \
--cc=me@bobcopeland.com \
--cc=miklos@szeredi.hu \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=muchun.song@linux.dev \
--cc=neil@brown.name \
--cc=ntfs3@lists.linux.dev \
--cc=ocfs2-devel@lists.linux.dev \
--cc=osalvador@suse.de \
--cc=pc@manguebit.org \
--cc=richard@nod.at \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=shaggy@kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=slava@dubeyko.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=tytso@mit.edu \
--cc=v9fs@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
--cc=xiubli@redhat.com \
--cc=yuezhang.mo@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).