From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA0BEC433EF for ; Thu, 9 Sep 2021 23:51:40 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CA3F61101; Thu, 9 Sep 2021 23:51:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5CA3F61101 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mOTpT-0000zn-MT; Thu, 09 Sep 2021 23:51:39 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOTpS-0000zh-Jr for linux-f2fs-devel@lists.sourceforge.net; Thu, 09 Sep 2021 23:51:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vnx9eaK6Rf7jbpckAL093aW2bY1xrkRJ0JeFL3qz8fg=; b=T4JV0Ow/bGSyV6BUlP1rFJG/HS zaHopZHTeXw9xCZ6x/jCLs4oUU7sCW7ugTSCLrB9LZyzSKSL0FlNvcEz3xUfilQBruouqdHhB2D8y uOj9PosO8OcpPxq/b8sXYs3apl0rpb6ecXaC5EfRzUD66LVV2VG9hEwkKOvN0e9KUrHc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vnx9eaK6Rf7jbpckAL093aW2bY1xrkRJ0JeFL3qz8fg=; b=bA9pKidW00k3Nvc1AxJitjeM73 MPaTuL1tMnFbcf7RGNW/GmH5K0ve2nZpGMxyUlXHzq1WUJEfe76UuaVVMHQ3zHtFqY+W4n0axtlSg 9FU13YRbwW5UPBJVcPzSOOtwV/lgLVjHxVfqoj0ZKxh0mXFjkA4zm3WS3nie3d+odA38=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mOTpR-005Qfm-WC for linux-f2fs-devel@lists.sourceforge.net; Thu, 09 Sep 2021 23:51:38 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5FB36610E9; Thu, 9 Sep 2021 23:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631231490; bh=fztYKXwCNriqil1UbKCuyBqnFoKNcnIMC9/mJUjAils=; h=Subject:To:References:From:Date:In-Reply-To:From; b=urGtZ56EpHaXAcPm9F103+W/UhQ6A5tOHIELnS27hJPbf0riXPNIIaQ/6F3sxJOLO bleOHITbxmgh64Aok8t3qKQ2IvxGOz4caCBewz8dMSN/OSkaQ/hnlU/37Bew3u4/zK l5BuFR+6K9rYH1aMV+28+uxaTtd0gcpLPEmTgBlH81ht7SNMjn+/2T7vpiKzcRvLUD eAvifvkG18e2XX6OlzN5s0Xi8T13NAbh2Uj6k2Rhl0n/wyTW823AyiihfH53kfpB4Z msrSzms5LlrOrJ2+WvX9PnhlkVWSnpAEY33GO/N5HMT/JDaMtx38UXGDgxVT0ixU5p E5UMLNWsHyqMg== To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20210907174351.1104857-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <6c40b766-2bdc-03c2-9e8a-e399d6e83282@kernel.org> Date: Fri, 10 Sep 2021 07:51:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210907174351.1104857-1-jaegeuk@kernel.org> Content-Language: en-US X-Headers-End: 1mOTpR-005Qfm-WC Subject: Re: [f2fs-dev] [PATCH] f2fs: should use GFP_NOFS for directory inodes X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/9/8 1:43, Jaegeuk Kim wrote: > We use inline_dentry which requires to allocate dentry page when adding a link. > If we allow to reclaim memory from filesystem, we do down_read(&sbi->cp_rwsem) > twice by f2fs_lock_op(). I think this should be okay, but how about stopping > the lockdep complaint [1]? > > f2fs_create() > - f2fs_lock_op() > - f2fs_do_add_link() > - __f2fs_find_entry > - f2fs_get_read_data_page() > -> kswapd > - shrink_node > - f2fs_evict_inode > - f2fs_lock_op() > > [1] > > fs_reclaim > ){+.+.}-{0:0} > : > kswapd0: lock_acquire+0x114/0x394 > kswapd0: __fs_reclaim_acquire+0x40/0x50 > kswapd0: prepare_alloc_pages+0x94/0x1ec > kswapd0: __alloc_pages_nodemask+0x78/0x1b0 > kswapd0: pagecache_get_page+0x2e0/0x57c > kswapd0: f2fs_get_read_data_page+0xc0/0x394 > kswapd0: f2fs_find_data_page+0xa4/0x23c > kswapd0: find_in_level+0x1a8/0x36c > kswapd0: __f2fs_find_entry+0x70/0x100 > kswapd0: f2fs_do_add_link+0x84/0x1ec > kswapd0: f2fs_mkdir+0xe4/0x1e4 > kswapd0: vfs_mkdir+0x110/0x1c0 > kswapd0: do_mkdirat+0xa4/0x160 > kswapd0: __arm64_sys_mkdirat+0x24/0x34 > kswapd0: el0_svc_common.llvm.17258447499513131576+0xc4/0x1e8 > kswapd0: do_el0_svc+0x28/0xa0 > kswapd0: el0_svc+0x24/0x38 > kswapd0: el0_sync_handler+0x88/0xec > kswapd0: el0_sync+0x1c0/0x200 > kswapd0: > -> #1 > ( > &sbi->cp_rwsem > ){++++}-{3:3} > : > kswapd0: lock_acquire+0x114/0x394 > kswapd0: down_read+0x7c/0x98 > kswapd0: f2fs_do_truncate_blocks+0x78/0x3dc > kswapd0: f2fs_truncate+0xc8/0x128 > kswapd0: f2fs_evict_inode+0x2b8/0x8b8 > kswapd0: evict+0xd4/0x2f8 > kswapd0: iput+0x1c0/0x258 > kswapd0: do_unlinkat+0x170/0x2a0 > kswapd0: __arm64_sys_unlinkat+0x4c/0x68 > kswapd0: el0_svc_common.llvm.17258447499513131576+0xc4/0x1e8 > kswapd0: do_el0_svc+0x28/0xa0 > kswapd0: el0_svc+0x24/0x38 > kswapd0: el0_sync_handler+0x88/0xec > kswapd0: el0_sync+0x1c0/0x200 > > Fixes: bdbc90fa55af ("f2fs: don't put dentry page in pagecache into highmem") > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel