From: Chao Yu <chao@kernel.org>
To: Yohan Joung <jyh429@gmail.com>, jaegeuk@kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
linux-f2fs-devel@lists.sourceforge.net, lkp@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix align check for npo2
Date: Sat, 1 Apr 2023 09:49:16 +0800 [thread overview]
Message-ID: <6db7be47-9455-c466-f99a-497f8fe8930a@kernel.org> (raw)
In-Reply-To: <20230324130747.523-1-jyh429@gmail.com>
On 2023/3/24 21:07, Yohan Joung wrote:
> Fix alignment check to be correct in npo2 as well
>
> Signed-off-by: Yohan Joung <yohan.joung@sk.com>
> ---
> fs/f2fs/segment.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 055e70e77aa2..f4a22a065277 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1842,6 +1842,7 @@ static int __f2fs_issue_discard_zone(struct f2fs_sb_info *sbi,
> sector_t sector, nr_sects;
> block_t lblkstart = blkstart;
> int devi = 0;
> + u32 remainder = 0;
>
> if (f2fs_is_multi_device(sbi)) {
> devi = f2fs_target_device_index(sbi, blkstart);
> @@ -1857,9 +1858,9 @@ static int __f2fs_issue_discard_zone(struct f2fs_sb_info *sbi,
> if (f2fs_blkz_is_seq(sbi, devi, blkstart)) {
> sector = SECTOR_FROM_BLOCK(blkstart);
> nr_sects = SECTOR_FROM_BLOCK(blklen);
> + div_u64_rem(sector, bdev_zone_sectors(bdev), &remainder);
Should use div64_u64_rem()? As both sector and return value of bdev_zone_sectors()
are u64.
Thanks,
>
> - if (sector & (bdev_zone_sectors(bdev) - 1) ||
> - nr_sects != bdev_zone_sectors(bdev)) {
> + if (remainder || nr_sects != bdev_zone_sectors(bdev)) {
> f2fs_err(sbi, "(%d) %s: Unaligned zone reset attempted (block %x + %x)",
> devi, sbi->s_ndevs ? FDEV(devi).path : "",
> blkstart, blklen);
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-04-01 1:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 13:14 [f2fs-dev] [PATCH] f2fs: fix align check for npo2 Yohan Joung
2023-03-23 2:37 ` kernel test robot
2023-03-23 7:23 ` Yohan Joung
2023-03-23 23:47 ` Jaegeuk Kim
2023-03-24 13:07 ` Yohan Joung
2023-04-01 1:49 ` Chao Yu [this message]
2023-04-02 3:17 ` Yohan Joung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6db7be47-9455-c466-f99a-497f8fe8930a@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=jyh429@gmail.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).