From: Chao Yu <chao@kernel.org>
To: Yunlei He <heyunlei@oppo.com>, jaegeuk@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: count mmap write io more accurately
Date: Mon, 19 Jun 2023 09:01:14 +0800 [thread overview]
Message-ID: <700bd4aa-20ac-a73d-2fb8-416e41ba208b@kernel.org> (raw)
In-Reply-To: <20230613065135.3517335-1-heyunlei@oppo.com>
On 2023/6/13 14:51, Yunlei He wrote:
> This patch count mmap write io more accurately and remove
> redundant PageUptodate judgement in f2fs_vm_page_mkwrite.
Yunlei,
What about separating this patch:
- remove unneeded uptodate check/set.
- fix incorrect PageMappedToDisk check and goto logic.
Thanks,
>
> Signed-off-by: Yunlei He <heyunlei@oppo.com>
> ---
> fs/f2fs/file.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 4dd4e2bd000a..34a6177c64a4 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -149,14 +149,12 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
> zero_user_segment(page, offset, PAGE_SIZE);
> }
> set_page_dirty(page);
> - if (!PageUptodate(page))
> - SetPageUptodate(page);
>
> +out_sem:
> f2fs_update_iostat(sbi, inode, APP_MAPPED_IO, F2FS_BLKSIZE);
> f2fs_update_time(sbi, REQ_TIME);
>
> trace_f2fs_vm_page_mkwrite(page, DATA);
> -out_sem:
> filemap_invalidate_unlock_shared(inode->i_mapping);
>
> sb_end_pagefault(inode->i_sb);
> --
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-06-19 1:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 6:51 [f2fs-dev] [PATCH] f2fs: count mmap write io more accurately Yunlei He via Linux-f2fs-devel
2023-06-19 1:01 ` Chao Yu [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-19 15:14 Yunlei He via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=700bd4aa-20ac-a73d-2fb8-416e41ba208b@kernel.org \
--to=chao@kernel.org \
--cc=heyunlei@oppo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).