From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] fsck.f2fs: check only max extra_isize
Date: Sun, 18 Aug 2019 20:34:51 +0800 [thread overview]
Message-ID: <723dac7b-2223-cf03-78ac-c417af5a404d@kernel.org> (raw)
In-Reply-To: <20190817010325.36501-1-jaegeuk@kernel.org>
On 2019-8-17 9:03, Jaegeuk Kim wrote:
> If we use later kernel having larger extra_isize, old fsck will delete
> entire old files.
Would it be better to construct the length based on existed features?
Thanks,
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fsck/fsck.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fsck/fsck.c b/fsck/fsck.c
> index 1708abe..b4e53db 100644
> --- a/fsck/fsck.c
> +++ b/fsck/fsck.c
> @@ -731,7 +731,7 @@ void fsck_chk_inode_blk(struct f2fs_sb_info *sbi, u32 nid,
> if (f2fs_has_extra_isize(&node_blk->i)) {
> if (c.feature & cpu_to_le32(F2FS_FEATURE_EXTRA_ATTR)) {
> if (node_blk->i.i_extra_isize >
> - cpu_to_le16(F2FS_TOTAL_EXTRA_ATTR_SIZE)) {
> + 4 * DEF_ADDRS_PER_INODE) {
> FIX_MSG("ino[0x%x] recover i_extra_isize "
> "from %u to %u",
> nid,
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-08-18 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-17 1:03 [f2fs-dev] [PATCH] fsck.f2fs: check only max extra_isize Jaegeuk Kim
2019-08-18 12:34 ` Chao Yu [this message]
2019-08-20 1:16 ` Jaegeuk Kim
2019-08-20 9:16 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=723dac7b-2223-cf03-78ac-c417af5a404d@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).