From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03897C3A589 for ; Tue, 20 Aug 2019 09:17:13 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9D4E216F4 for ; Tue, 20 Aug 2019 09:17:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="F31kAjBi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="MhuiWLM2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9D4E216F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1i00GO-0000iO-EI; Tue, 20 Aug 2019 09:17:12 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1i00GN-0000iG-24 for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Aug 2019 09:17:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=isMFtwz7KabAHoGlJlcsmxIDUiH5y82m7cI138msfDM=; b=F31kAjBi7qjA0XcryPwTBgi+m2 5BDBpn4lIgf8L8da8JAMIjervy1M4ek1jUc8s/SbsX47rR79RX7c/dCtf+CEuv+RJoAlCCSs1wKdw JdkWsspGVMWfQ1wT6BRICbsedJuxcDH0FdhoWu7BwzhU5J4AsNJkFRN0A4Artg5OZrvg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=isMFtwz7KabAHoGlJlcsmxIDUiH5y82m7cI138msfDM=; b=MhuiWLM221pG+BxAkhKtTgDNuX snUNcHIjXPK3CSz6aAcBKIBnRGSxPIINgerEdWQjJmL3bz+jAcuZXOLqHHeyURKQgA+QwrFhJ5KHU A2wroVWPITRQJOPNQjG4xlOJY0ZUyDqF+8TbdBuNDF6+Nh2pWkSiIpwvYqerYoT9BFKU=; Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1i00GL-00CyIP-PL for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Aug 2019 09:17:10 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id BD8848EC234F8254D4D4; Tue, 20 Aug 2019 17:17:02 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 20 Aug 2019 17:16:59 +0800 To: Jaegeuk Kim References: <20190816030334.81035-1-yuchao0@huawei.com> <3349ceea-85ac-173a-81a4-1188ce3804ca@huawei.com> <20190820010000.GA45681@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: <74d1d451-e2a7-dc0f-a218-a05cd4cdcfa8@huawei.com> Date: Tue, 20 Aug 2019 17:16:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190820010000.GA45681@jaegeuk-macbookpro.roam.corp.google.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1i00GL-00CyIP-PL Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to avoid data corruption by forbidding SSR overwrite X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2019/8/20 9:00, Jaegeuk Kim wrote: > On 08/19, Chao Yu wrote: >> On 2019/8/16 11:03, Chao Yu wrote: >>> There is one case can cause data corruption. >>> >>> - write 4k to fileA >>> - fsync fileA, 4k data is writebacked to lbaA >>> - write 4k to fileA >>> - kworker flushs 4k to lbaB; dnode contain lbaB didn't be persisted yet >>> - write 4k to fileB >>> - kworker flush 4k to lbaA due to SSR >>> - SPOR -> dnode with lbaA will be recovered, however lbaA contains fileB's >>> data >>> >>> One solution is tracking all fsynced file's block history, and disallow >>> SSR overwrite on newly invalidated block on that file. >>> >>> However, during recovery, no matter the dnode is flushed or fsynced, all >>> previous dnodes until last fsynced one in node chain can be recovered, >>> that means we need to record all block change in flushed dnode, which >>> will cause heavy cost, so let's just use simple fix by forbidding SSR >>> overwrite directly. >>> >> >> Jaegeuk, >> >> Please help to add below missed tag to keep this patch being merged in stable >> kernel. >> >> Fixes: 5b6c6be2d878 ("f2fs: use SSR for warm node as well") > > Done. Thanks! :) Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel