linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: zhangqilong via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>
Subject: [f2fs-dev] 答复:  [PATCH] mkfs.f2fs: update allocation policy for ro feature
Date: Wed, 28 Sep 2022 02:11:03 +0000	[thread overview]
Message-ID: <75b9bfd8d6ea4674914119edbee2e6a7@huawei.com> (raw)
In-Reply-To: <YzMnm4vx7dxb+vAA@google.com>

> On 09/25, Chao Yu wrote:
> > Update allocation policy for ro feature:
> > - hot_data: allocating blocks by LBA ascending order
> > - hot_node: allocating blocks by LBA descending order
> 
> This will increase the RO image size.
> 
> >
> > Signed-off-by: Chao Yu <chao@kernel.org>
> > ---
> >  mkfs/f2fs_format.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c index
> > 40ac589..8d0f410 100644
> > --- a/mkfs/f2fs_format.c
> > +++ b/mkfs/f2fs_format.c
> > @@ -544,10 +544,10 @@ static int f2fs_prepare_super_block(void)
> >  	}
> >
> >  	if (c.feature & cpu_to_le32(F2FS_FEATURE_RO)) {
> > -		c.cur_seg[CURSEG_HOT_NODE] = 0;
> > +		c.cur_seg[CURSEG_HOT_NODE] =
> last_section(last_zone(total_zones));
> >  		c.cur_seg[CURSEG_WARM_NODE] = 0;
> >  		c.cur_seg[CURSEG_COLD_NODE] = 0;
> > -		c.cur_seg[CURSEG_HOT_DATA] = 1;
> > +		c.cur_seg[CURSEG_HOT_DATA] = 0;

Hi,

I want to know that, does this change try to reduce the possibility of the 3rd situation that
previous referred (f2fs: extent cache: support extent for no-compressed file)? The largest
extent maybe only cover one part of continuous blocks in f2fs ro-image.

Thanks,

> >  		c.cur_seg[CURSEG_COLD_DATA] = 0;
> >  		c.cur_seg[CURSEG_WARM_DATA] = 0;
> >  	} else if (c.heap) {
> > --
> > 2.36.1
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

      parent reply	other threads:[~2022-09-28  2:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-25  5:58 [f2fs-dev] [PATCH] mkfs.f2fs: update allocation policy for ro feature Chao Yu
2022-09-27 16:40 ` Jaegeuk Kim
2022-09-28  1:48   ` Chao Yu
2022-09-28  3:15     ` Jaegeuk Kim
2022-09-28 11:59       ` Chao Yu
2022-09-29 18:27         ` Jaegeuk Kim
2022-09-29 22:57           ` Chao Yu
2022-09-30 22:33             ` Jaegeuk Kim
2022-10-01  0:26               ` Chao Yu
2022-10-03  1:06                 ` Jaegeuk Kim
2022-10-06 15:22                   ` Chao Yu
2022-09-28  2:11   ` zhangqilong via Linux-f2fs-devel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75b9bfd8d6ea4674914119edbee2e6a7@huawei.com \
    --to=linux-f2fs-devel@lists.sourceforge.net \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=zhangqilong3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).