From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC934C433EF for ; Mon, 1 Nov 2021 07:15:19 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C0D96108C; Mon, 1 Nov 2021 07:15:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9C0D96108C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mhRXJ-0007LS-WC; Mon, 01 Nov 2021 07:15:18 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mhRXI-0007LH-KR for linux-f2fs-devel@lists.sourceforge.net; Mon, 01 Nov 2021 07:15:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EwDzyEKctTZaodBX02vlPoDub7+pNVoG1/glpazC92E=; b=hAJ1fy9Ly0VQVXqMT7dI/LkZRA RoKB4i5WXzTKrWZgLxT/DfSPwrtx0JLRySQN3HFx6FBZLCjYRLkFosvYPB4dv08D7MvlMwNolMzhD 8oDiMk79UCn8g+hOJXV7T69MZkhTtqgfCLsIcixvhmi2RjK4Xa2g9fN5KvMeUhKMIsq0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EwDzyEKctTZaodBX02vlPoDub7+pNVoG1/glpazC92E=; b=KdfyShZvVFcMjW/xo/iXk7KzY0 hrjmKlThBd0yMPk27MM72SEe8tzW6KB72dXQmuIWWkm2v9LS80TjdZkUiBl2Wivd0/VDjEFRXqSXT GWlwmOEqwOp/UPlcgPU6jdKHlOsgXur1Z6YAfBkNoLkWzsFwQLCdVmHp/HJDM2E1nq6s=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mhRVG-00Aes3-OG for linux-f2fs-devel@lists.sourceforge.net; Mon, 01 Nov 2021 07:15:16 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9723E60FE8; Mon, 1 Nov 2021 07:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635750780; bh=vHovt+cQzLZT7BElPIMbzumsvBYvSVJ0/rUbXoi52bo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lQYnG+YAUYKW1+jNysoNFIybCd4R4j7cLy84azLDo40aZd/T0kuv9Db7SXSGkOrJQ XMFpPiGnAcd4ZEkJZnHuoGRTBG2J2+zi313Z+7x7NKfG9JuoFkOzatfz2yJATrXY0Q 9SXlRFz0GgSw+QiMPlQykLsq1HEivcHs64dUK96Q0dfhs9EIH9L+jYe11XS+44MWSR lLwNqoUvtimuEVS2fDUkhN3Lj3gTyfd0+WSqodh79eqZBA9tobzMyC30LDXuj9Db0S hI2vI8yvIUJjuGvwoAXtnsm1Taze4IFtQ5V9rKHdSf/IrQcVIG0KXJjIIm3lwqyocn ZEmnyk8HChPZw== Message-ID: <75c52307-7bfd-2408-d067-26d1fca7bb73@kernel.org> Date: Mon, 1 Nov 2021 15:12:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Content-Language: en-US To: Hyeong-Jun Kim , Jaegeuk Kim References: <20211101054214.24456-1-hj514.kim@samsung.com> <9a0360922130485f4252970de4bb535667cc26e9.camel@samsung.com> From: Chao Yu In-Reply-To: <9a0360922130485f4252970de4bb535667cc26e9.camel@samsung.com> X-Headers-End: 1mhRVG-00Aes3-OG Subject: Re: [f2fs-dev] [PATCH] F2FS: invalidate META_MAPPING before IPU/DIO write X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/11/1 15:09, Hyeong-Jun Kim wrote: > On Mon, 2021-11-01 at 14:28 +0800, Chao Yu wrote: >> On 2021/11/1 13:42, Hyeong-Jun Kim wrote: >>> Encrypted pages during GC are read and cached in META_MAPPING. >>> However, due to cached pages in META_MAPPING, there is an issue >>> where >>> newly written pages are lost by IPU or DIO writes. >>> >>> Thread A Thread B >>> - f2fs_gc(): blk 0x10 -> 0x20 (a) >>> - IPU or DIO write on blk >>> 0x20 (b) >>> - f2fs_gc(): blk 0x20 -> 0x30 (c) >>> >>> (a) page for blk 0x20 is cached in META_MAPPING and page for blk >>> 0x10 >>> is invalidated from META_MAPPING. >>> (b) write new data to blk 0x200 using IPU or DIO, but outdated data >>> still remains in META_MAPPING. >>> (c) f2fs_gc() try to move blk from 0x20 to 0x30 using cached page >>> in >>> META_MAPPING. In conclusion, the newly written data in (b) is >>> lost. >> >> In c), f2fs_gc() will readahead encrypted block from disk via >> ra_data_block() anyway, >> not matter cached encrypted page of meta inode is uptodate or not, so >> it's safe, right? > Right, > However, if DIO write is performed between phase 3 and phase 4 of > f2fs_gc(), > the cached page of meta_mapping will be out-dated, though it read data > from > disk via ra_data_block() in phase 3. > > What do you think? Due to i_gc_rwsem lock coverage, the race condition should not happen right now? Thanks, > > Thanks, >> >> Am I missing anything? >> >> Thanks, >> >>> To address this issue, invalidating pages in META_MAPPING before >>> IPU or >>> DIO write. >>> >>> Signed-off-by: Hyeong-Jun Kim < >>> hj514.kim@samsung.com >>>> >>> --- >>> fs/f2fs/data.c | 2 ++ >>> fs/f2fs/segment.c | 3 +++ >>> 2 files changed, 5 insertions(+) >>> >>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >>> index 74e1a350c1d8..9f754aaef558 100644 >>> --- a/fs/f2fs/data.c >>> +++ b/fs/f2fs/data.c >>> @@ -1708,6 +1708,8 @@ int f2fs_map_blocks(struct inode *inode, >>> struct f2fs_map_blocks *map, >>> */ >>> f2fs_wait_on_block_writeback_range(inode, >>> map->m_pblk, map- >>>> m_len); >>> + invalidate_mapping_pages(META_MAPPING(sbi), >>> + map->m_pblk, map- >>>> m_pblk); >>> >>> if (map->m_multidev_dio) { >>> block_t blk_addr = map->m_pblk; >>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c >>> index 526423fe84ce..f57c55190f9e 100644 >>> --- a/fs/f2fs/segment.c >>> +++ b/fs/f2fs/segment.c >>> @@ -3652,6 +3652,9 @@ int f2fs_inplace_write_data(struct >>> f2fs_io_info *fio) >>> goto drop_bio; >>> } >>> >>> + invalidate_mapping_pages(META_MAPPING(fio->sbi), >>> + fio->new_blkaddr, fio->new_blkaddr); >>> + >>> stat_inc_inplace_blocks(fio->sbi); >>> >>> if (fio->bio && !(SM_I(sbi)->ipu_policy & (1 << >>> F2FS_IPU_NOCACHE))) >>> >> >> > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel