From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC89C433FE for ; Thu, 10 Dec 2020 08:43:30 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96BB623D69 for ; Thu, 10 Dec 2020 08:43:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96BB623D69 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1knHXs-0000wW-Qg; Thu, 10 Dec 2020 08:43:28 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knHXq-0000wO-Qj for linux-f2fs-devel@lists.sourceforge.net; Thu, 10 Dec 2020 08:43:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Kaf6SE3CcJng7hFfSOUqnpbRaR5mTLGBbLC+CrOtJH0=; b=SYBSV0YD09GDFsW2fqM9BEZTa8 bUHDA/jwE45cAdbMDeln2MHLUO1ePRvzXJkbXF9yTEQGLmbaWXwSgkhPgUneOCBFxHSJ9i+e67ZqJ pT+JMIiIDQ0Ay6L0TqNGZz/tPFoGjNeYtvoUmNWWVXSIW5B6b5INz5kHVHe5deACocsc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Kaf6SE3CcJng7hFfSOUqnpbRaR5mTLGBbLC+CrOtJH0=; b=NdxBRaZCjI9XhwLkcKk7NjnBw6 c/rbpaloBeMuJojhVCCHAI4hzGjD+lXWexZXNBlS2fVzx3bZguXd0nRdcJ5NavJpPTjZHvMNIIXzl qeInNpYQM5XcCW9ObZvvh+FIQAJs35KmKoJ+Qq9dPfjt+7hRIkyDQVilipaxJuSMYK+g=; Received: from szxga05-in.huawei.com ([45.249.212.191]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1knHXc-006CR6-47 for linux-f2fs-devel@lists.sourceforge.net; Thu, 10 Dec 2020 08:43:26 +0000 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Cs6q849KSzM356; Thu, 10 Dec 2020 16:42:12 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 10 Dec 2020 16:42:51 +0800 To: Robin Hsu , , , References: <20201208081555.652932-1-robinh3123@gmail.com> <20201208081555.652932-3-robinh3123@gmail.com> From: Chao Yu Message-ID: <785e9f0a-c3d6-9cc5-f17a-a3cc58a43a0f@huawei.com> Date: Thu, 10 Dec 2020 16:42:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201208081555.652932-3-robinh3123@gmail.com> Content-Language: en-US X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected X-Headers-End: 1knHXc-006CR6-47 Subject: Re: [f2fs-dev] [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/12/8 16:15, Robin Hsu wrote: > From: Robin Hsu > > Add F2FS compression support for sload > * Support file extension filter, either default-accept or default-deny > policy > * Support choice of compression algorithm, LZO (version 2) or LZ4 > (default) > * Support custom log of cluster size > * Support minimum number of compressed blocks per cluster (default 1). > A cluster will not be compressed if the number can not be met. > * suuport -r (read-only) option Could you please update manual as well? > + > + /* sldc: sload compression support */ Personally, I don't like the naming method of adding "sldc_" prefix... :( > + bool sldc_en; > + bool sldc_use_allow_list; /* default false to use the deny list */ > + struct compress_ctx sldc_cc; > + u8 sldc_ca; /* compress algorithm: 0 = LZO, 1 = LZ4 */ > + compress_ops *sldc_compr; > + enum filter_policy sldc_policy; > + /* max_cppc can used to specify minimum compression rate */ > + unsigned int sldc_min_cbpc; /* min compressed pages per cluster */ > + bool sldc_got_opt; > + bool sldc_immutable; > + struct ext_tbl_op *sldc_ef; /* extension filter */ The variables name like sldc_en, sldc_ca, min_cbpc, sldc_ef makes developers hard to understand w/o comments, and also there is no comments for several variable like sldc_en, sldc_cc... Could you please improve the naming like f2fs-tools style? Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel