From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C36CEB64DD for ; Sun, 6 Aug 2023 02:06:16 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qST9o-0000wU-Es; Sun, 06 Aug 2023 02:06:13 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qST9m-0000wN-EL for linux-f2fs-devel@lists.sourceforge.net; Sun, 06 Aug 2023 02:06:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=X+vbfJ0wdY3WL+v0k/CmGQ7odWaBOY2dFHoq9FjRQaM=; b=KF6+G3z2bdIlw7o0Hav73qg0Mi dk5lCGygmUiS5f9SoSF3kL2NUvJ8qVflaJuJQBQ3ioyVkb6ehn6ikV3lRCuHv1aycTUJeI7jrUAM6 0EHtDgqxLtWpO/iBVkBPu5KgnMk33gCKxru7oiL6SZIVl/aLb27umtX0K3MhcaYfDUio=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=X+vbfJ0wdY3WL+v0k/CmGQ7odWaBOY2dFHoq9FjRQaM=; b=kvYHsruylHHtqiqb3MjDo7YuvM lAIsuE0n2ym8BxD64LM6Vz/RwtZHMsrH6zbKqArusI85qRm2bfpeeIfGcdu8oF2z1Tf4eoW65Wop9 ML2HRitUwmHRawCXQf3Ur2bufAP9MTqwwsGhgMJOyGE1xDZsfhNDQ3MaTeaVl4XVUu0Q=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1qST9j-00Ed2H-W6 for linux-f2fs-devel@lists.sourceforge.net; Sun, 06 Aug 2023 02:06:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9411B60F87; Sun, 6 Aug 2023 02:05:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 977F0C433C7; Sun, 6 Aug 2023 02:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691287557; bh=Z4QnozTfyOTeA6ryCGMdqKhzAe2vCk+mRvcfqr/TDAc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dKJyxiFD3aOn3IzP847Q8tCFPdH+u9Cx9OqBpcqrUizUtkVlkZ5leIYSUl8IwbANo x5AvixfliXQjyqOQxw/n1CkuigL6VOQvlfNVLMhICwCQxJgpRLY7UkG3+NENE9fGfO tgZLnQR5iZyf4bxsBwvGBQrKqIz0z5Vx2oLWTwEFr59AWBeqvIHhwD1X3ZsPpkQ7ff 9i49QGrRyFQ+mZ1ZZ8l64xiQuNpozK3qoK9+cnzdFVYG51Aw76ft+9F41MxFMef9Rh +T1j1/veJ6btMX81rdc361Sh/gr8jq42Y5dLMdNn71HXqxMxNXZU83BTetZn8patvz zfIzbhMfy3Oow== Message-ID: <791fbf71-093e-3ef5-b02b-6d6bba72b57f@kernel.org> Date: Sun, 6 Aug 2023 10:05:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Wu Bo , Jaegeuk Kim References: <20230731012626.6843-1-bo.wu@vivo.com> From: Chao Yu In-Reply-To: <20230731012626.6843-1-bo.wu@vivo.com> X-Headers-End: 1qST9j-00Ed2H-W6 Subject: Re: [f2fs-dev] [PATCH 1/1] f2fs: move fiemap to use iomap framework X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wubo.oduw@gmail.com, Daeho Jeong , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2023/7/31 9:26, Wu Bo wrote: > This patch has been tested with xfstests by running 'kvm-xfstests -c > f2fs -g auto' with and without this patch; no regressions were seen. > > Some tests fail both before and after, and the test results are: > f2fs/default: 683 tests, 9 failures, 226 skipped, 30297 seconds > Failures: generic/050 generic/064 generic/250 generic/252 generic/459 > generic/506 generic/563 generic/634 generic/635 Can you please take a look at gerneic/473 ? generic/473 1s ... - output mismatch (see /media/fstests/results//generic/473.out.bad) --- tests/generic/473.out 2022-11-10 08:42:19.231395230 +0000 +++ /media/fstests/results//generic/473.out.bad 2023-08-04 02:02:01.000000000 +0000 @@ -6,7 +6,7 @@ 1: [256..287]: hole Hole + Data 0: [0..127]: hole -1: [128..255]: data +1: [128..135]: data Hole + Data + Hole 0: [0..127]: hole ... (Run 'diff -u /media/fstests/tests/generic/473.out /media/fstests/results//generic/473.out.bad' to see the entire diff) Other concern is, it needs to test this implementation on compressed file, since the logic is a little bit complicated. +Cc Daeho Jeong Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel