Re: [PATCH] f2fs: check if inmem_pages list is empty correctly

[Chao Yu <yuchao0@huawei.com>]

On 2018/4/17 17:12, Sheng Yong wrote:
> `cur' will never be NULL, we should check inmem_pages list instead.
> 
> Signed-off-by: Sheng Yong <shengyong1@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

> ---
>  fs/f2fs/segment.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 5854cc4e1d67..bf9dab55b370 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -328,7 +328,7 @@ void drop_inmem_page(struct inode *inode, struct page *page)
>  			break;
>  	}
>  
> -	f2fs_bug_on(sbi, !cur || cur->page != page);
> +	f2fs_bug_on(sbi, list_empty(head) || cur->page != page);
>  	list_del(&cur->list);
>  	mutex_unlock(&fi->inmem_lock);
>  
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot