Re: [f2fs-dev] [PATCH v2] f2fs: Only lfs mode is allowed with zoned block device feature

[Chao Yu <chao@kernel.org>]

On 2023/8/3 22:28, Chunhai Guo wrote:
> Now f2fs support four block allocation modes: lfs, adaptive,
> fragment:segment, fragment:block. Only lfs mode is allowed with zoned block
> device feature.
> 

Fixes: 6691d940b0e0 ("f2fs: introduce fragment allocation mode mount option")

Otherwise, it looks good to me.

Thanks,

> Signed-off-by: Chunhai Guo <guochunhai@vivo.com>
> ---
>   fs/f2fs/super.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 30883beb750a..26add77f9062 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -862,11 +862,6 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
>   			if (!name)
>   				return -ENOMEM;
>   			if (!strcmp(name, "adaptive")) {
> -				if (f2fs_sb_has_blkzoned(sbi)) {
> -					f2fs_warn(sbi, "adaptive mode is not allowed with zoned block device feature");
> -					kfree(name);
> -					return -EINVAL;
> -				}
>   				F2FS_OPTION(sbi).fs_mode = FS_MODE_ADAPTIVE;
>   			} else if (!strcmp(name, "lfs")) {
>   				F2FS_OPTION(sbi).fs_mode = FS_MODE_LFS;
> @@ -1331,6 +1326,11 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
>   			F2FS_OPTION(sbi).discard_unit =
>   					DISCARD_UNIT_SECTION;
>   		}
> +
> +		if (F2FS_OPTION(sbi).fs_mode != FS_MODE_LFS) {
> +			f2fs_info(sbi, "Only lfs mode is allowed with zoned block device feature");
> +			return -EINVAL;
> +		}
>   #else
>   		f2fs_err(sbi, "Zoned block device support is not enabled");
>   		return -EINVAL;


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel