From: Chao Yu <yuchao0@huawei.com>
To: Fengnan Chang <changfengnan@vivo.com>, <jaegeuk@kernel.org>,
<chao@kernel.org>, <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [RFC PATCH] f2fs: compress: remove unneeded read when rewrite whole cluster
Date: Mon, 24 May 2021 19:38:31 +0800 [thread overview]
Message-ID: <7ad8bae8-6e38-5ff7-add8-fe1023569f43@huawei.com> (raw)
In-Reply-To: <20210518125113.1712-1-changfengnan@vivo.com>
On 2021/5/18 20:51, Fengnan Chang wrote:
> For now,when overwrite compressed file, we need read old data to page
> cache first and update pages.
> But when we need overwrite whole cluster, we don't need old data
> anymore.
I only see you just check the whole page was dirty as below rather than
the whole cluster is dirty during write().
Thanks,
> + if (len == PAGE_SIZE)
> + return 0;
> /* compressed case */
> prealloc = (ret < cc->cluster_size);
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-05-24 11:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 12:51 [f2fs-dev] [RFC PATCH] f2fs: compress: remove unneeded read when rewrite whole cluster Fengnan Chang
2021-05-21 8:38 ` [f2fs-dev] 答复: " changfengnan
2021-05-24 11:38 ` Chao Yu [this message]
2021-05-25 12:05 ` changfengnan
2021-05-28 2:49 ` Chao Yu
2021-05-29 1:13 ` Chao Yu
2021-06-08 12:47 ` [f2fs-dev] 答复: " changfengnan--- via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ad8bae8-6e38-5ff7-add8-fe1023569f43@huawei.com \
--to=yuchao0@huawei.com \
--cc=changfengnan@vivo.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).