From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Qi Han <hanqi@vivo.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree
Date: Sat, 22 Apr 2023 20:15:21 +0800 [thread overview]
Message-ID: <84f8a1d4-a0c6-c618-b3e0-4d0f4d4d5a8d@kernel.org> (raw)
In-Reply-To: <ZELiCve2x31uJFhM@google.com>
On 2023/4/22 3:20, Jaegeuk Kim wrote:
> On 04/21, Chao Yu wrote:
>> On 2023/4/18 14:09, Qi Han wrote:
>>> This comment make no sense and is in the wrong place, so let's
>>> remove it.
>>>
>>> Signed-off-by: Qi Han <hanqi@vivo.com>
>>> ---
>>> fs/f2fs/extent_cache.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
>>> index 28b12553f2b3..1f6d7de35794 100644
>>> --- a/fs/f2fs/extent_cache.c
>>> +++ b/fs/f2fs/extent_cache.c
>>> @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)
>>> if (!test_opt(sbi, AGE_EXTENT_CACHE))
>>> return false;
>>> - /* don't cache block age info for cold file */
>>> if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
>>> return false;
>>
>> Should move it here instead of removal?
>>
>> /* don't cache block age info for cold file */
>
> Not worth to comment this, as the code is exactly saying that.
Correct.
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
>
>>
>>> if (file_is_cold(inode))
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-04-22 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 6:09 [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree Qi Han via Linux-f2fs-devel
2023-04-21 2:27 ` Chao Yu
2023-04-21 19:20 ` Jaegeuk Kim
2023-04-22 12:15 ` Chao Yu [this message]
2023-04-21 6:51 ` [f2fs-dev] [PATCH] f2fs: move wrong comment to right place " Qi Han via Linux-f2fs-devel
2023-04-24 18:10 ` [f2fs-dev] [PATCH] f2fs: remove unnessary comment " patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84f8a1d4-a0c6-c618-b3e0-4d0f4d4d5a8d@kernel.org \
--to=chao@kernel.org \
--cc=hanqi@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).