From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B9C4C6FD18 for ; Sat, 22 Apr 2023 12:16:17 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pqC9x-0003V4-4h; Sat, 22 Apr 2023 12:16:08 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pqC9g-0003Uk-Aq for linux-f2fs-devel@lists.sourceforge.net; Sat, 22 Apr 2023 12:15:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1xV7K0JcqGsEJRfJHhRSeCCRiw+/GRAKE/VetfC6lvw=; b=mpAXnXj/4/y+PZ3PRv0bu67c7s 52FV0lGJeaDkEpsdWDsC74m/sajQ2RBDz7Fj9pU/tgrP1Wx36mqs8n7++duST0KTopDxtQKUWwcWO Kgq9cIEvWy+yi9auaZG4WEO7W8iNN+O6/5L4PIt14fgVkhr4oq42QFLRTqn2M/CPFSDY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1xV7K0JcqGsEJRfJHhRSeCCRiw+/GRAKE/VetfC6lvw=; b=ZBnNNu96oIszQQSu3hv+yyHPE4 wts7piXM8ie1o50ol++pgJjf57n/sMRYVWl0AMgBH+DOa7S1jLvtjZddiMki5gHahlbAOaSvg6D09 dBhbh9p4plu90XvJiQz82ugBK2IlOC36UJBq2f8Tl9lN/kWJuyDrUsTj0xMxD5Q0psEc=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pqC9O-0005D2-Sj for linux-f2fs-devel@lists.sourceforge.net; Sat, 22 Apr 2023 12:15:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AB05060A55; Sat, 22 Apr 2023 12:15:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DB8AC433EF; Sat, 22 Apr 2023 12:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682165724; bh=dLzgToQ+97zNNFKyQ4T4DaBcoPkeYRwGP3sxxYoPM9E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eldrpYS8vH7GeFYeEKT4IhBo9fFMy7vhetIHJvkjuyjRUb365ddyzEQsRkdD7HYWM Rko3d3jdLDvUNvOm8zTGkAlRwiw1QsmBVMD0DJaJcPo8XD8iYvUUhkjiX+7ewPkKMY y1Sm1eznUkLbw42qZOSsLyke9JjMbuGA2wb8dU8dziT/cnU5znOTp5qE2hiKLOGq6K hvIofEQGg00LGGvOA46Odk+jy+LG0Q3NfwH4O2nXj520h9HCC9KBNcmdohYY5LvVDL VZqNhey9RMG1yiOoGcYHfR5BAml+cHwHpNRmHszlbATz2dPZyRmrZb9FJUJAcUKYAf mGKATj5TgiRww== Message-ID: <84f8a1d4-a0c6-c618-b3e0-4d0f4d4d5a8d@kernel.org> Date: Sat, 22 Apr 2023 20:15:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: Jaegeuk Kim References: <20230418060954.67585-1-hanqi@vivo.com> From: Chao Yu In-Reply-To: X-Headers-End: 1pqC9O-0005D2-Sj Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qi Han , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2023/4/22 3:20, Jaegeuk Kim wrote: > On 04/21, Chao Yu wrote: >> On 2023/4/18 14:09, Qi Han wrote: >>> This comment make no sense and is in the wrong place, so let's >>> remove it. >>> >>> Signed-off-by: Qi Han >>> --- >>> fs/f2fs/extent_cache.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c >>> index 28b12553f2b3..1f6d7de35794 100644 >>> --- a/fs/f2fs/extent_cache.c >>> +++ b/fs/f2fs/extent_cache.c >>> @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode) >>> if (!test_opt(sbi, AGE_EXTENT_CACHE)) >>> return false; >>> - /* don't cache block age info for cold file */ >>> if (is_inode_flag_set(inode, FI_COMPRESSED_FILE)) >>> return false; >> >> Should move it here instead of removal? >> >> /* don't cache block age info for cold file */ > > Not worth to comment this, as the code is exactly saying that. Correct. Reviewed-by: Chao Yu Thanks, > >> >>> if (file_is_cold(inode)) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel