From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Daniel Rosenberg <drosen@google.com>
Cc: "Theodore Y . Ts'o" <tytso@mit.edu>,
Eric Biggers <ebiggers@google.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-fscrypt@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org, kernel-team@android.com
Subject: Re: [f2fs-dev] [PATCH v4 1/3] libfs: Add generic function for setting dentry_ops
Date: Sat, 21 Nov 2020 23:55:37 -0500 [thread overview]
Message-ID: <87tutij8hi.fsf@collabora.com> (raw)
In-Reply-To: <20201119060904.463807-2-drosen@google.com> (Daniel Rosenberg's message of "Thu, 19 Nov 2020 06:09:02 +0000")
Daniel Rosenberg <drosen@google.com> writes:
> This adds a function to set dentry operations at lookup time that will
> work for both encrypted filenames and casefolded filenames.
>
> A filesystem that supports both features simultaneously can use this
> function during lookup preparations to set up its dentry operations once
> fscrypt no longer does that itself.
>
> Currently the casefolding dentry operation are always set if the
> filesystem defines an encoding because the features is toggleable on
> empty directories. Unlike in the encryption case, the dentry operations
> used come from the parent. Since we don't know what set of functions
> we'll eventually need, and cannot change them later, we enable the
> casefolding operations if the filesystem supports them at all.
>
> By splitting out the various cases, we support as few dentry operations
> as we can get away with, maximizing compatibility with overlayfs, which
> will not function if a filesystem supports certain dentry_operations.
>
> Signed-off-by: Daniel Rosenberg <drosen@google.com>
> Reviewed-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
--
Gabriel Krisman Bertazi
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-11-22 5:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 6:09 [f2fs-dev] [PATCH v4 0/3] Add support for Encryption and Casefolding in F2FS Daniel Rosenberg via Linux-f2fs-devel
2020-11-19 6:09 ` [f2fs-dev] [PATCH v4 1/3] libfs: Add generic function for setting dentry_ops Daniel Rosenberg via Linux-f2fs-devel
2020-11-22 4:55 ` Gabriel Krisman Bertazi [this message]
2020-11-19 6:09 ` [f2fs-dev] [PATCH v4 2/3] fscrypt: Have filesystems handle their d_ops Daniel Rosenberg via Linux-f2fs-devel
2020-11-22 4:45 ` Gabriel Krisman Bertazi
2020-11-23 22:30 ` Eric Biggers
2020-11-24 4:31 ` Gabriel Krisman Bertazi
2020-11-22 5:12 ` Gao Xiang
2020-11-23 22:51 ` Eric Biggers
2020-11-24 2:08 ` Gao Xiang
2020-11-24 4:37 ` Gabriel Krisman Bertazi
2020-11-26 6:20 ` Daniel Rosenberg via Linux-f2fs-devel
2020-11-19 6:09 ` [f2fs-dev] [PATCH v4 3/3] f2fs: Handle casefolding with Encryption Daniel Rosenberg via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tutij8hi.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=adilger.kernel@dilger.ca \
--cc=drosen@google.com \
--cc=ebiggers@google.com \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).