From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tiezhu Yang" Subject: Re: [PATCH] f2fs: fix wrong return value of f2fs_acl_create Date: Wed, 21 Nov 2018 06:38:29 +0800 (CST) Message-ID: <889a0da.8ee.16733466169.Coremail.kernelpatch@126.com> References: <26a3c90d.498.1672de9287d.Coremail.kernelpatch@126.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gPEfO-0003es-Q8 for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Nov 2018 22:38:46 +0000 Received: from m15-62.126.com ([220.181.15.62]) by sfi-mx-3.v28.lw.sourceforge.com with esmtp (Exim 4.90_1) id 1gPEfK-00FTX1-Kb for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Nov 2018 22:38:46 +0000 In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Chao Yu Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net At 2018-11-20 20:07:55, "Chao Yu" wrote: >On 2018-11-20 5:38, Tiezhu Yang wrote: >> When call f2fs_acl_create_masq() failed, the caller f2fs_acl_create() >> should return -EIO instead of -ENOMEM, this patch makes it consistent >> with posix_acl_create() which has been fixed in commit beaf226b863a >> ("posix_acl: don't ignore return value of posix_acl_create_masq()"). >> >> Fixes: 83dfe53c185e ("f2fs: fix reference leaks in f2fs_acl_create") >> Signed-off-by: Tiezhu Yang >> --- >> fs/f2fs/acl.c | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c >> index fa707cd..b791c24 100644 >> --- a/fs/f2fs/acl.c >> +++ b/fs/f2fs/acl.c >> @@ -351,13 +351,14 @@ static int f2fs_acl_create(struct inode *dir, umode_t *mode, >> if (IS_ERR(p)) >> return PTR_ERR(p); >> >> + ret = -ENOMEM; >> clone = f2fs_acl_clone(p, GFP_NOFS); >> if (!clone) > >We can avoid assigning ret by: > >clone = f2fs_acl_clone(p, GFP_NOFS); >if (!clone) { > ret = -ENOMEM; > goto release_acl; >} > >> - goto no_mem; >> + goto err_release; >> >> ret = f2fs_acl_create_masq(clone, mode); >> if (ret < 0) >> - goto no_mem_clone; >> + goto err_release_clone; >> >> if (ret == 0) >> posix_acl_release(clone); >> @@ -371,11 +372,11 @@ static int f2fs_acl_create(struct inode *dir, umode_t *mode, >> >> return 0; >> >> -no_mem_clone: >> +err_release_clone: > >release_clone: > >> posix_acl_release(clone); >> -no_mem: >> +err_release: > >release_acl: > >Tag naming is minor, anyway this patch looks good to me. Thanks for your suggestion, I will send a v2 patch. Thanks, > >Reviewed-by: Chao Yu > >Thanks, > >> posix_acl_release(p); >> - return -ENOMEM; >> + return ret; >> } >> >> int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage, >>