From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 073C0C77B7C for ; Mon, 22 May 2023 00:05:14 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1q0t32-0004UE-D5; Mon, 22 May 2023 00:05:13 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q0t31-0004U8-Ce for linux-f2fs-devel@lists.sourceforge.net; Mon, 22 May 2023 00:05:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vMyxo8JcHGinlxUdMcuInfNb7vz2Ov9+urCxYD/rlUA=; b=hexKnTEOqwDfp7XV8ARHTe1jP0 cZoH3D9kg9dIImyiWZQlTWRVpMbLL2tjd2sGIieLNQFv43JcRD8giIV2A/b+CrvWQK/vt3DTDSRJD rQJuU5FuBcdme5YoQZD/0OvGf/BcB+JgOl8x/1bpdy5gSaOWonUsR5Bm3WSYzfq3pJvI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vMyxo8JcHGinlxUdMcuInfNb7vz2Ov9+urCxYD/rlUA=; b=K3fh6+10mSRxT0VIHXSK8Kyosm n6+znLOopwACEspMPq170uebykwehmMuasxnGou2VTbLqqm+t7z8vfv3fZc0OQ5+gO1Y/J4RS8mxf GGd11GboAshQVvDL4e/kRumXL+2YaMJOSoVjjBi358ImihtJTTq6nDs7cPCsoLSrLsIE=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1q0t30-0004tM-3q for linux-f2fs-devel@lists.sourceforge.net; Mon, 22 May 2023 00:05:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A77DF6174C; Mon, 22 May 2023 00:05:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 750D7C433EF; Mon, 22 May 2023 00:05:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684713904; bh=E9HylG/tcZ9ypOKQIb0ALyQo4ZdadXJ2F5MM9xsQvIo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tg9VRhD3pU5E6h82uRSebiA2CoUfSFazrPXhAdkuMdw/YHz7TizGQVPxH7sf1bybJ 9pVjxyd9RD6Esi/udTHpfhazC7ni+xDnJ4tp7E6eb55JCV0Ys8k/lLJ4eUDSxRqvq9 LJERPMDd3prQur8f5Edsobj6QFKiaT4Fgpq94NE2coTNbZwqY1W+WFhGHfAI4sp6Z8 DlkD0MMz0RQOpRdIUO3g4Qdn9cn0kk3tJJQwapFPHbh7Lv+sp54Q+MR5U2VlJ16StD Hgj+jgofNL7e7t3WCATjtmEpaHL/w1gXK0aWokjb1cSD/3mfQKZv5EhJQmXTLNRAyQ ZG2tBsVHf7xCA== Message-ID: <88fe9652-3cf5-c601-08f1-64b75e367ca5@kernel.org> Date: Mon, 22 May 2023 09:05:00 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox References: <20230519093521.133226-1-hch@lst.de> <20230519093521.133226-9-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230519093521.133226-9-hch@lst.de> X-Headers-End: 1q0t30-0004tM-3q Subject: Re: [f2fs-dev] [PATCH 08/13] iomap: assign current->backing_dev_info in iomap_file_buffered_write X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Darrick J. Wong" , linux-mm@kvack.org, Andreas Gruenbacher , Miklos Szeredi , cluster-devel@redhat.com, Ilya Dryomov , linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-block@vger.kernel.org, Alexander Viro , Jaegeuk Kim , ceph-devel@vger.kernel.org, Xiubo Li , Trond Myklebust , Jens Axboe , Christian Brauner , Theodore Ts'o , "open list:F2FS FILE SYSTEM" , linux-xfs@vger.kernel.org, Anna Schumaker , linux-fsdevel@vger.kernel.org, Andrew Morton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 5/19/23 18:35, Christoph Hellwig wrote: > Move the assignment to current->backing_dev_info from the callers into > iomap_file_buffered_write to reduce boiler plate code and reduce the > scope to just around the page dirtying loop. > > Note that zonefs was missing this assignment before. Hu... Shouldn't this be fixed as a separate patch with a Fixes tag for this cycle ? I have never noticed any issues with this missing though. Not sure how an issue can be triggered with this assignment missing. Apart from that, this patch look good to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel