linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Yunlei He <heyunlei@huawei.com>,
	jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2] f2fs: stop issue discard if something wrong with f2fs
Date: Sun, 8 Apr 2018 16:26:23 +0800	[thread overview]
Message-ID: <8ca9f7d4-d56a-7a1c-a245-a973bfe02649@huawei.com> (raw)
In-Reply-To: <1523171471-538-1-git-send-email-heyunlei@huawei.com>

On 2018/4/8 15:11, Yunlei He wrote:
> This patch stop discard thread to issue discard io if
> something wrong with f2fs, which is similar to fstrim.
> 
> Signed-off-by: Yunlei He <heyunlei@huawei.com>
> ---
>  fs/f2fs/segment.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 5854cc4..f75f503 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1410,6 +1410,11 @@ static int issue_discard_thread(void *data)
>  			continue;
>  		if (kthread_should_stop())
>  			return 0;
> +		if (is_sbi_flag_set(sbi, SBI_NEED_FSCK)) {
> +			f2fs_msg(sbi->sb, KERN_WARNING,
> +				"Found FS corruption, run fsck to fix.");

__get_nat_bitmaps can set this flag during mounting? so its meaning is not only
indicate the image is corrupted but also mean that we need run fsck to recover
status like nat bitmaps?

Thanks,

> +			continue;
> +		}
>  
>  		if (dcc->discard_wake)
>  			dcc->discard_wake = 0;
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

  parent reply	other threads:[~2018-04-08  8:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-08  7:11 [PATCH 1/2] f2fs: stop issue discard if something wrong with f2fs Yunlei He
2018-04-08  7:11 ` [PATCH 2/2] f2fs: let discard thread wait a little longer if dev is busy Yunlei He
2018-04-08 11:01   ` Chao Yu
2018-04-08  8:26 ` Chao Yu [this message]
2018-04-08  9:19   ` [PATCH 1/2] f2fs: stop issue discard if something wrong with f2fs heyunlei
2018-04-08 10:01     ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ca9f7d4-d56a-7a1c-a245-a973bfe02649@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=heyunlei@huawei.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).