From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA0F6C433FE for ; Wed, 9 Nov 2022 13:40:24 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oslJV-0000Rr-Pp; Wed, 09 Nov 2022 13:40:21 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oslJU-0000Rj-9T for linux-f2fs-devel@lists.sourceforge.net; Wed, 09 Nov 2022 13:40:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/2QugQ7qiD72tQ18q/uoHEafoxX1jEX/ixxmyE9OGJ0=; b=ZHg4L4bQKYKFGiSV0G8wR4+OgE 8+lIZxaDSqRcnXoW9Xwn0l3c/NRFjSTbmYPQS6OdHIOCngypeaeVasRQRzNk1BJ3ZYAwRMAXG4wqy LSuzlzYcqRUQOoQ8h1slNCVl8vd/HUTUM5KstddIM8RbJY1Wix/CfCIH4VC5JGkt9ORQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/2QugQ7qiD72tQ18q/uoHEafoxX1jEX/ixxmyE9OGJ0=; b=XQi3pWzW3xYGSTxvHmW2kx8rus P1yilqqyb+QNnHjz3TPZ0uWX4l3uCLVCsIUlF6Yqm08mEN91Qu7Xa7sJ2HWnu9ZEA6anfwVoIQZOj ZrSCIHq/49f1nooKsH7b9ZOUfP3D08EM9FABN4lsp4h5IEjJACG1VoYjBYIB7JyTL2UU=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1oslJN-0006TE-JO for linux-f2fs-devel@lists.sourceforge.net; Wed, 09 Nov 2022 13:40:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0C54561AA5; Wed, 9 Nov 2022 13:40:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 097A0C433D6; Wed, 9 Nov 2022 13:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668001202; bh=R5D/mual96ln/JPqzbIm8Tg82MFVZP6ncu4epnJxztA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aJdGIOYjXTenNHND7xhh42IpIgD3S6NE0OECKL14T4to7SrNmNm6EFryNC0YjdQf7 rf/VJngQZhIV/cqxtmB7XegrcJ5PCNjHgG1aI2RkHYmrkskJCI9limk+T90nVFnd/a nFPo/gJEQ8rkNa1uXnOGvK5qOXCCZGPkV9ZL77TQNC2UTQvXWgLRFP/Q1/6Ql3UCOd GR4H8yRztwpfS4PH/ZdEQtmvUdFCg21VkLuhYIccMdZYNrrIIeGCCrV/ndFz3TWXqz 9BSBhKOSoXR1SlMyj/tfjvod+FZ2egpCI5x0TeEb7I3Gr1DGy/xo3zBps4fAw2LwUE u/Pu2f4mHfkSg== Message-ID: <8fe7450e-6d21-e85a-c6dc-89134206b264@kernel.org> Date: Wed, 9 Nov 2022 21:39:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Content-Language: en-US To: qixiaoyu , Jaegeuk Kim References: <20221021023136.22863-1-qixiaoyu1@xiaomi.com> <20221102122518.GB22857@mi-HP-ProDesk-680-G4-MT> <3d2b1141-995a-4bfb-4bf0-5227be25105a@kernel.org> <20221108123218.GC22857@mi-HP-ProDesk-680-G4-MT> <8368702c-ae33-b810-a6c3-ac8fa29998df@kernel.org> <20221109125605.GD22857@mi-HP-ProDesk-680-G4-MT> From: Chao Yu In-Reply-To: <20221109125605.GD22857@mi-HP-ProDesk-680-G4-MT> X-Headers-End: 1oslJN-0006TE-JO Subject: Re: [f2fs-dev] [PATCH] f2fs: separate IPU policy for fdatasync from F2FS_IPU_FSYNC X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qixiaoyu1 , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2022/11/9 20:56, qixiaoyu wrote: > On Tue, Nov 08, 2022 at 10:30:13PM +0800, Chao Yu wrote: >> On 2022/11/8 20:32, qixiaoyu wrote: >>> On Sun, Nov 06, 2022 at 09:54:59PM +0800, Chao Yu wrote: >>>> On 2022/11/2 20:25, qixiaoyu wrote: >>>>> Hi Chao, >>>>> >>>>> fdatasync do in-place-update to avoid additional node writes, but currently >>>>> it only do that with F2FS_IPU_FSYNC as: >>>>> >>>>> f2fs_do_sync_file: >>>>> if (datasync || get_dirty_pages(inode) <= SM_I(sbi)->min_fsync_blocks) >>>>> set_inode_flag(inode, FI_NEED_IPU); >>>>> >>>>> check_inplace_update_policy: >>>>> /* this is only set during fdatasync */ >>>>> if (policy & (0x1 << F2FS_IPU_FSYNC) && >>>>> is_inode_flag_set(inode, FI_NEED_IPU)) >>>>> return true; >>>>> >>>>> So this patch separate in-place-update of fdatasync from F2FS_IPU_FSYNC to >>>>> apply it to all IPU policy. >>>>> >>>>> BTW, we found small performance improvement with this patch on AndroBench app >>>>> using F2FS_IPU_SSR_UTIL on our product: >>>> >>>> How this patch affects performance when F2FS_IPU_SSR_UTIL is on? >>>> >>>> Thanks, >>>> >>> >>> SQLite test in AndroBench app use fdatasync to sync file to the disk. >>> When switch to F2FS_IPU_SSR_UTIL ipu_policy, it will use out-of-place-update >>> even though SQLite calls fdatasync, which will introduce extra meta data write. >> >> Why not using F2FS_IPU_SSR_UTIL | F2FS_IPU_FSYNC, I guess these two flags >> cover different scenarios, F2FS_IPU_SSR_UTIL for ssr case, and F2FS_IPU_FSYNC >> for f{data,}sync case. >> >> Thanks, >> > > As fsync(2) says: > fdatasync() is similar to fsync(), but does not flush modified metadata unless that > metadata is needed in order to allow a subsequent data retrieval to be correctly handled. I guess it says it allows fdatasync to flush metatdata in order to recovery data in SPO case. > > I think fdatasync should try to perform in-place-update to avoid unnecessary metadata > update whatever the ipu_policy is, and F2FS_IPU_FSYNC is used for fsync independently. IMO, FSYNC key word in F2FS_IPU_FSYNC means fsync path or interface name as below: int (*fsync) (struct file *, loff_t, loff_t, int datasync); And by default, f2fs enables F2FS_IPU_FSYNC, I didn't get why we need to disable it. To Jaegeuk, any comments? Thanks, > > Thanks > >>> >>> Thanks. >>> >>>>> >>>>> F2FS_IPU_FSYNC F2FS_IPU_SSR_UTIL F2FS_IPU_SSR_UTIL(with patch) >>>>> SQLite Insert(QPS) 6818.08 6327.09(-7.20%) 6757.72 >>>>> SQLite Update(QPS) 6528.81 6336.57(-2.94%) 6490.77 >>>>> SQLite Delete(QPS) 9724.68 9378.37(-3.56%) 9622.27 >>>>> >>>>> Thanks >>>>> >>>>> On Tue, Nov 01, 2022 at 11:14:55PM +0800, Chao Yu wrote: >>>>>> On 2022/10/21 10:31, qixiaoyu1 wrote: >>>>>>> Currently IPU policy for fdatasync is coupled with F2FS_IPU_FSYNC. >>>>>>> Fix to apply it to all IPU policy. >>>>>> >>>>>> Xiaoyu, >>>>>> >>>>>> Sorry for the delay. >>>>>> >>>>>> I didn't get the point, can you please explain more about the >>>>>> issue? >>>>>> >>>>>> Thanks, >>>>>> >>>>>>> >>>>>>> Signed-off-by: qixiaoyu1 >>>>>>> --- >>>>>>> fs/f2fs/data.c | 8 +++----- >>>>>>> fs/f2fs/file.c | 4 +++- >>>>>>> 2 files changed, 6 insertions(+), 6 deletions(-) >>>>>>> >>>>>>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >>>>>>> index a71e818cd67b..fec8e15fe820 100644 >>>>>>> --- a/fs/f2fs/data.c >>>>>>> +++ b/fs/f2fs/data.c >>>>>>> @@ -2518,6 +2518,9 @@ static inline bool check_inplace_update_policy(struct inode *inode, >>>>>>> if (policy & (0x1 << F2FS_IPU_HONOR_OPU_WRITE) && >>>>>>> is_inode_flag_set(inode, FI_OPU_WRITE)) >>>>>>> return false; >>>>>>> + /* this is set by fdatasync or F2FS_IPU_FSYNC policy */ >>>>>>> + if (is_inode_flag_set(inode, FI_NEED_IPU)) >>>>>>> + return true; >>>>>>> if (policy & (0x1 << F2FS_IPU_FORCE)) >>>>>>> return true; >>>>>>> if (policy & (0x1 << F2FS_IPU_SSR) && f2fs_need_SSR(sbi)) >>>>>>> @@ -2538,11 +2541,6 @@ static inline bool check_inplace_update_policy(struct inode *inode, >>>>>>> !IS_ENCRYPTED(inode)) >>>>>>> return true; >>>>>>> - /* this is only set during fdatasync */ >>>>>>> - if (policy & (0x1 << F2FS_IPU_FSYNC) && >>>>>>> - is_inode_flag_set(inode, FI_NEED_IPU)) >>>>>>> - return true; >>>>>>> - >>>>>>> if (unlikely(fio && is_sbi_flag_set(sbi, SBI_CP_DISABLED) && >>>>>>> !f2fs_is_checkpointed_data(sbi, fio->old_blkaddr))) >>>>>>> return true; >>>>>>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c >>>>>>> index 82cda1258227..08091550cdf2 100644 >>>>>>> --- a/fs/f2fs/file.c >>>>>>> +++ b/fs/f2fs/file.c >>>>>>> @@ -270,8 +270,10 @@ static int f2fs_do_sync_file(struct file *file, loff_t start, loff_t end, >>>>>>> goto go_write; >>>>>>> /* if fdatasync is triggered, let's do in-place-update */ >>>>>>> - if (datasync || get_dirty_pages(inode) <= SM_I(sbi)->min_fsync_blocks) >>>>>>> + if (datasync || (SM_I(sbi)->ipu_policy & (0x1 << F2FS_IPU_FSYNC) && >>>>>>> + get_dirty_pages(inode) <= SM_I(sbi)->min_fsync_blocks)) >>>>>>> set_inode_flag(inode, FI_NEED_IPU); >>>>>>> + >>>>>>> ret = file_write_and_wait_range(file, start, end); >>>>>>> clear_inode_flag(inode, FI_NEED_IPU); _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel