[f2fs-dev] [PATCH v2] f2fs: compress: remove unneeded read when rewrite whole cluster

[f2fs-dev] [PATCH v2] f2fs: compress: remove unneeded read when rewrite whole cluster

[Fengnan Chang]

when we overwrite the whole page in cluster, we don't need read original
data before write, because after write_end(), writepages() can help to
load left data in that cluster.

Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Acked-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/data.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 3a01a1b50104..2aeb1196cd5f 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -3328,6 +3328,9 @@ static int f2fs_write_begin(struct file *file, struct address_space *mapping,

 		*fsdata = NULL;

+		if (len == PAGE_SIZE)
+			goto repeat;
+
 		ret = f2fs_prepare_compress_overwrite(inode, pagep,
 							index, fsdata);
 		if (ret < 0) {
--
2.29.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2] f2fs: compress: remove unneeded read when rewrite whole cluster

[Fengnan Chang]

Hi Jaegeuk:

    FYI, I have run xfstest fast test on linux-5.13.0-rc1 + patch, no 
new failure case.

Thanks.

On 2021/6/22 19:50, Fengnan Chang wrote:
> when we overwrite the whole page in cluster, we don't need read original
> data before write, because after write_end(), writepages() can help to
> load left data in that cluster.
> 
> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> Acked-by: Chao Yu <yuchao0@huawei.com>
> ---
>   fs/f2fs/data.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 3a01a1b50104..2aeb1196cd5f 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -3328,6 +3328,9 @@ static int f2fs_write_begin(struct file *file, struct address_space *mapping,
> 
>   		*fsdata = NULL;
> 
> +		if (len == PAGE_SIZE)
> +			goto repeat;
> +
>   		ret = f2fs_prepare_compress_overwrite(inode, pagep,
>   							index, fsdata);
>   		if (ret < 0) {
> --
> 2.29.0
> 
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2] f2fs: compress: remove unneeded read when rewrite whole cluster

[Fengnan Chang]

Hi Jaegeuk:
	Any comments about this version?

On 2021/6/22 19:50, Fengnan Chang wrote:
> when we overwrite the whole page in cluster, we don't need read original
> data before write, because after write_end(), writepages() can help to
> load left data in that cluster.
> 
> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> Acked-by: Chao Yu <yuchao0@huawei.com>
> ---
>   fs/f2fs/data.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 3a01a1b50104..2aeb1196cd5f 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -3328,6 +3328,9 @@ static int f2fs_write_begin(struct file *file, struct address_space *mapping,
> 
>   		*fsdata = NULL;
> 
> +		if (len == PAGE_SIZE)
> +			goto repeat;
> +
>   		ret = f2fs_prepare_compress_overwrite(inode, pagep,
>   							index, fsdata);
>   		if (ret < 0) {
> --
> 2.29.0
> 
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2] f2fs: compress: remove unneeded read when rewrite whole cluster

[Chao Yu]

On 2021/7/13 10:35, Fengnan Chang wrote:
> Hi Jaegeuk:
> 	Any comments about this version?
> 
> On 2021/6/22 19:50, Fengnan Chang wrote:
>> when we overwrite the whole page in cluster, we don't need read original
>> data before write, because after write_end(), writepages() can help to
>> load left data in that cluster.

Jaegeuk,

Let's queue this in dev-test for testing?

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2] f2fs: compress: remove unneeded read when rewrite whole cluster

[Jaegeuk Kim]

On 07/13, Chao Yu wrote:
> On 2021/7/13 10:35, Fengnan Chang wrote:
> > Hi Jaegeuk:
> > 	Any comments about this version?
> > 
> > On 2021/6/22 19:50, Fengnan Chang wrote:
> > > when we overwrite the whole page in cluster, we don't need read original
> > > data before write, because after write_end(), writepages() can help to
> > > load left data in that cluster.
> 
> Jaegeuk,
> 
> Let's queue this in dev-test for testing?

A bit worry about unknown corner cases tho, Chao, could you please test
as well?

> 
> Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2] f2fs: compress: remove unneeded read when rewrite whole cluster

[Chao Yu]

On 2021/7/14 7:44, Jaegeuk Kim wrote:
> On 07/13, Chao Yu wrote:
>> On 2021/7/13 10:35, Fengnan Chang wrote:
>>> Hi Jaegeuk:
>>> 	Any comments about this version?
>>>
>>> On 2021/6/22 19:50, Fengnan Chang wrote:
>>>> when we overwrite the whole page in cluster, we don't need read original
>>>> data before write, because after write_end(), writepages() can help to
>>>> load left data in that cluster.
>>
>> Jaegeuk,
>>
>> Let's queue this in dev-test for testing?
> 
> A bit worry about unknown corner cases tho, Chao, could you please test
> as well?

Yup, I just plan to do this, may focus on data consistence.

Thanks,

> 
>>
>> Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2] f2fs: compress: remove unneeded read when rewrite whole cluster

[Chao Yu]

On 2021/7/14 9:18, Chao Yu wrote:
> On 2021/7/14 7:44, Jaegeuk Kim wrote:
>> On 07/13, Chao Yu wrote:
>>> On 2021/7/13 10:35, Fengnan Chang wrote:
>>>> Hi Jaegeuk:
>>>> 	Any comments about this version?
>>>>
>>>> On 2021/6/22 19:50, Fengnan Chang wrote:
>>>>> when we overwrite the whole page in cluster, we don't need read original
>>>>> data before write, because after write_end(), writepages() can help to
>>>>> load left data in that cluster.
>>>
>>> Jaegeuk,
>>>
>>> Let's queue this in dev-test for testing?
>>
>> A bit worry about unknown corner cases tho, Chao, could you please test
>> as well?
> 
> Yup, I just plan to do this, may focus on data consistence.

I have time to check the data consistence for this change, I've ran a
customized script (overwrite partial blocks of compressed cluster with
original data, sync, drop cache and compare the data), there is no data
corruption till now.

Thanks,

> 
> Thanks,
> 
>>
>>>
>>> Thanks,
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel