From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Wenjie Qi <qwjhust@gmail.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net, qiwenjie@xiaomi.com,
linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2 05/12] f2fs: cache: use meta cache
Date: Tue, 25 Aug 2026 14:37:33 +0800 [thread overview]
Message-ID: <970e87b6-23e1-4d34-9a13-68567692294e@kernel.org> (raw)
In-Reply-To: <20260825054248.399693-1-qiwenjie@xiaomi.com>
will fix, thanks,
On 8/25/26 13:42, Wenjie Qi wrote:
> Hi Chao,
>
>> case META:
>> nr_to_write = BIO_MAX_VECS;
>> break;
>
> and in `f2fs_sync_meta_caches()`:
>
>> nwritten += sbi->blocksize;
>> prev = entry->index;
>> if (unlikely(nwritten >= nr_to_write))
>> break;
>
> `adjust_flush_cache_number()` returns `BIO_MAX_VECS` for META, while
> `nwritten` advances by `sbi->blocksize` for each entry before the comparison.
>
> Are `nr_to_write` and `nwritten` intended to be entry counts or byte counts in
> this path?
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-08-25 6:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 13:47 [f2fs-dev] [PATCH] f2fs: introduce metadata cache Chao Yu via Linux-f2fs-devel
2026-08-24 13:47 ` [f2fs-dev] [PATCH v2 01/12] f2fs: cache: implement " Chao Yu via Linux-f2fs-devel
2026-08-25 5:39 ` Wenjie Qi
2026-08-25 6:35 ` Chao Yu via Linux-f2fs-devel
2026-08-24 13:47 ` [f2fs-dev] [PATCH v2 02/12] f2fs: cache: initialize meta cache Chao Yu via Linux-f2fs-devel
2026-08-24 13:47 ` [f2fs-dev] [PATCH v2 03/12] f2fs: cache: introduce shrinker Chao Yu via Linux-f2fs-devel
2026-08-25 5:42 ` Wenjie Qi
2026-08-25 6:36 ` Chao Yu via Linux-f2fs-devel
2026-08-25 5:42 ` Wenjie Qi
2026-08-25 6:37 ` Chao Yu via Linux-f2fs-devel
2026-08-24 13:47 ` [f2fs-dev] [PATCH v2 04/12] f2fs: cache: introduce writeback thread Chao Yu via Linux-f2fs-devel
2026-08-24 13:47 ` [f2fs-dev] [PATCH v2 05/12] f2fs: cache: use meta cache Chao Yu via Linux-f2fs-devel
2026-08-25 5:42 ` Wenjie Qi
2026-08-25 6:37 ` Chao Yu via Linux-f2fs-devel [this message]
2026-08-24 13:47 ` [f2fs-dev] [PATCH v2 06/12] f2fs: cache: initialize node cache Chao Yu via Linux-f2fs-devel
2026-08-24 13:47 ` [f2fs-dev] [PATCH v2 07/12] f2fs: cache: use " Chao Yu via Linux-f2fs-devel
2026-08-25 5:43 ` Wenjie Qi
2026-08-25 6:38 ` Chao Yu via Linux-f2fs-devel
2026-08-25 5:43 ` Wenjie Qi
2026-08-25 6:40 ` Chao Yu via Linux-f2fs-devel
2026-08-24 13:47 ` [f2fs-dev] [PATCH v2 08/12] f2fs: cache: initialize compress cache Chao Yu via Linux-f2fs-devel
2026-08-24 13:47 ` [f2fs-dev] [PATCH v2 09/12] f2fs: cache: use " Chao Yu via Linux-f2fs-devel
2026-08-25 5:43 ` Wenjie Qi
2026-08-25 6:42 ` Chao Yu via Linux-f2fs-devel
2026-08-24 13:47 ` [f2fs-dev] [PATCH v2 10/12] f2fs: cache: support fault injection Chao Yu via Linux-f2fs-devel
2026-08-24 13:47 ` [f2fs-dev] [PATCH v2 11/12] f2fs: cache: introduce tracepoints Chao Yu via Linux-f2fs-devel
2026-08-24 13:47 ` [f2fs-dev] [PATCH v2 12/12] f2fs: cache: show per-cache usage in debugfs Chao Yu via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=970e87b6-23e1-4d34-9a13-68567692294e@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiwenjie@xiaomi.com \
--cc=qwjhust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox