From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: stable@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix kernel crash due to null io->bio
Date: Tue, 7 Feb 2023 20:35:38 +0800 [thread overview]
Message-ID: <97b16883-64ec-ba32-ddf2-656ff7a5fc80@kernel.org> (raw)
In-Reply-To: <20230206034344.724593-1-jaegeuk@kernel.org>
On 2023/2/6 11:43, Jaegeuk Kim wrote:
> We should return when io->bio is null before doing anything. Otherwise, panic.
>
> BUG: kernel NULL pointer dereference, address: 0000000000000010
> RIP: 0010:__submit_merged_write_cond+0x164/0x240 [f2fs]
> Call Trace:
> <TASK>
> f2fs_submit_merged_write+0x1d/0x30 [f2fs]
> commit_checkpoint+0x110/0x1e0 [f2fs]
> f2fs_write_checkpoint+0x9f7/0xf00 [f2fs]
> ? __pfx_issue_checkpoint_thread+0x10/0x10 [f2fs]
> __checkpoint_and_complete_reqs+0x84/0x190 [f2fs]
> ? preempt_count_add+0x82/0xc0
> ? __pfx_issue_checkpoint_thread+0x10/0x10 [f2fs]
> issue_checkpoint_thread+0x4c/0xf0 [f2fs]
> ? __pfx_autoremove_wake_function+0x10/0x10
> kthread+0xff/0x130
> ? __pfx_kthread+0x10/0x10
> ret_from_fork+0x2c/0x50
> </TASK>
>
> Cc: stable@vger.kernel.org # v5.18+
> Fixes: 64bf0eef0171 ("f2fs: pass the bio operation to bio_alloc_bioset")
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-02-07 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 3:43 [f2fs-dev] [PATCH] f2fs: fix kernel crash due to null io->bio Jaegeuk Kim
2023-02-07 12:35 ` Chao Yu [this message]
2023-02-07 19:00 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97b16883-64ec-ba32-ddf2-656ff7a5fc80@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).