From: Chao Yu <chao@kernel.org>
To: Chengguang Xu <cgxu519@gmx.com>, jaegeuk@kernel.org, yuchao0@huawei.com
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: remove default option setting in remount
Date: Tue, 18 Sep 2018 21:20:58 +0800 [thread overview]
Message-ID: <9bc59ef2-01cc-0cf1-1676-4d8a75514aad@kernel.org> (raw)
In-Reply-To: <20180918062344.3102-1-cgxu519@gmx.com>
On 2018/9/18 14:23, Chengguang Xu wrote:
> Currently we set default value to options before parsing remount options,
> it will cause unexpected change of options which were specified in first
> mount.
Can you check below commit? It looks w/o it we may lose default option after
remount.
498c5e9fcd10 ("f2fs: add default mount options to remount")
Thanks,
>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
> ---
> fs/f2fs/super.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 00d512cd4bf2..89ea19466e80 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1499,8 +1499,6 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
> clear_sbi_flag(sbi, SBI_NEED_SB_WRITE);
> }
>
> - default_options(sbi);
> -
> /* parse mount options */
> err = parse_options(sb, data);
> if (err)
>
next prev parent reply other threads:[~2018-09-18 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 6:23 [PATCH] f2fs: remove default option setting in remount Chengguang Xu
2018-09-18 13:20 ` Chao Yu [this message]
2018-09-18 13:47 ` cgxu519
2018-09-19 14:02 ` Chao Yu
2018-09-19 23:54 ` cgxu519
2018-09-20 6:29 ` Chao Yu
2018-09-22 14:40 ` cgxu519
2018-09-25 7:41 ` Chao Yu
2018-10-18 5:28 ` Chengguang Xu
2018-10-19 2:15 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bc59ef2-01cc-0cf1-1676-4d8a75514aad@kernel.org \
--to=chao@kernel.org \
--cc=cgxu519@gmx.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).