* [f2fs-dev] [PATCH] f2fs: set zstd compress level correctly
@ 2022-11-17 15:10 Sheng Yong via Linux-f2fs-devel
2022-11-24 0:55 ` Nick Terrell via Linux-f2fs-devel
2022-11-24 15:11 ` Chao Yu
0 siblings, 2 replies; 3+ messages in thread
From: Sheng Yong via Linux-f2fs-devel @ 2022-11-17 15:10 UTC (permalink / raw)
To: jaegeuk, chao; +Cc: terrelln, linux-kernel, linux-f2fs-devel
Fixes: cf30f6a5f0c6 ("lib: zstd: Add kernel-specific API")
Signed-off-by: Sheng Yong <shengyong@oppo.com>
---
fs/f2fs/compress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index d315c2de136f2..74d3f2d2271f3 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -346,7 +346,7 @@ static int zstd_init_compress_ctx(struct compress_ctx *cc)
if (!level)
level = F2FS_ZSTD_DEFAULT_CLEVEL;
- params = zstd_get_params(F2FS_ZSTD_DEFAULT_CLEVEL, cc->rlen);
+ params = zstd_get_params(level, cc->rlen);
workspace_size = zstd_cstream_workspace_bound(¶ms.cParams);
workspace = f2fs_kvmalloc(F2FS_I_SB(cc->inode),
--
2.25.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: set zstd compress level correctly
2022-11-17 15:10 [f2fs-dev] [PATCH] f2fs: set zstd compress level correctly Sheng Yong via Linux-f2fs-devel
@ 2022-11-24 0:55 ` Nick Terrell via Linux-f2fs-devel
2022-11-24 15:11 ` Chao Yu
1 sibling, 0 replies; 3+ messages in thread
From: Nick Terrell via Linux-f2fs-devel @ 2022-11-24 0:55 UTC (permalink / raw)
To: Sheng Yong
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
> On Nov 17, 2022, at 7:10 AM, Sheng Yong <shengyong@oppo.com> wrote:
>
> >
> Fixes: cf30f6a5f0c6 ("lib: zstd: Add kernel-specific API")
> Signed-off-by: Sheng Yong <shengyong@oppo.com>
> ---
> fs/f2fs/compress.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
> index d315c2de136f2..74d3f2d2271f3 100644
> --- a/fs/f2fs/compress.c
> +++ b/fs/f2fs/compress.c
> @@ -346,7 +346,7 @@ static int zstd_init_compress_ctx(struct compress_ctx *cc)
> if (!level)
> level = F2FS_ZSTD_DEFAULT_CLEVEL;
>
> - params = zstd_get_params(F2FS_ZSTD_DEFAULT_CLEVEL, cc->rlen);
> + params = zstd_get_params(level, cc->rlen);
> workspace_size = zstd_cstream_workspace_bound(¶ms.cParams);
>
> workspace = f2fs_kvmalloc(F2FS_I_SB(cc->inode),
> --
> 2.25.1
>
Thanks for the patch, and sorry for introducing the bug!
Looks like I missed this while rebasing that patch series.
Reviewed-by: Nick Terrell <terrelln@fb.com>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: set zstd compress level correctly
2022-11-17 15:10 [f2fs-dev] [PATCH] f2fs: set zstd compress level correctly Sheng Yong via Linux-f2fs-devel
2022-11-24 0:55 ` Nick Terrell via Linux-f2fs-devel
@ 2022-11-24 15:11 ` Chao Yu
1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu @ 2022-11-24 15:11 UTC (permalink / raw)
To: Sheng Yong, jaegeuk; +Cc: terrelln, linux-kernel, linux-f2fs-devel
On 2022/11/17 23:10, Sheng Yong wrote:
> Fixes: cf30f6a5f0c6 ("lib: zstd: Add kernel-specific API")
> Signed-off-by: Sheng Yong <shengyong@oppo.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-24 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-17 15:10 [f2fs-dev] [PATCH] f2fs: set zstd compress level correctly Sheng Yong via Linux-f2fs-devel
2022-11-24 0:55 ` Nick Terrell via Linux-f2fs-devel
2022-11-24 15:11 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).