From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E424C433DF for ; Fri, 29 May 2020 06:37:29 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D05CD20721 for ; Fri, 29 May 2020 06:37:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="QstIyvmX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="DKWZu19U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D05CD20721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jeYdz-0004eB-Fg; Fri, 29 May 2020 06:37:27 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeYdy-0004dn-RD for linux-f2fs-devel@lists.sourceforge.net; Fri, 29 May 2020 06:37:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Qvrr7o33fRRfecKJfkC5A4YC376w3Q5bxLwXgWxRMcA=; b=QstIyvmXPLKElArhzzkunM42zQ NgB0HmHlgOztziK3W9qcGZeuJU7oGkML+oinUapA2UDVgfKYEnCk1Av0Rsvi7BWalNuZS05/5Eh+l 1eQKC8zcw6LZnuHG3nkssCB8CewbVrf/CkEZNOQqHDXiprLlSNNbsDSCYOA0+BAx7MVE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Qvrr7o33fRRfecKJfkC5A4YC376w3Q5bxLwXgWxRMcA=; b=DKWZu19US6VC/48lWs2T09jeeJ vq4DaqhzHJhJ+h6zpF9+UO96ZT3k286sStJN0Yu4Yex1CYKTmcyfHEy3L8kvbikGJnDOSrUfUeWgv Ybl9iqBX6oXPX8/XVPIb7C+FhNo0m0sVANzm1EJfcHhUNauHGg2ozR1FFtqRuvAirzhk=; Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jeYdw-00Gwxp-4D for linux-f2fs-devel@lists.sourceforge.net; Fri, 29 May 2020 06:37:26 +0000 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id E832D5B84A409C22E219; Fri, 29 May 2020 14:37:05 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 29 May 2020 14:37:04 +0800 To: Jaegeuk Kim References: <20200527102753.15743-1-yuchao0@huawei.com> <20200527102753.15743-3-yuchao0@huawei.com> <20200527210233.GC206249@google.com> <23245f6e-528d-43ab-57b6-4ca16db43fe5@huawei.com> <20200528012615.GA232094@google.com> <8e30b18d-bf8e-dd2f-35fa-08bbfd1b507e@huawei.com> <20200528190010.GA162605@google.com> From: Chao Yu Message-ID: <9fa465a0-70b5-7d17-baf4-21224196e2bc@huawei.com> Date: Fri, 29 May 2020 14:37:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200528190010.GA162605@google.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1jeYdw-00Gwxp-4D Subject: Re: [f2fs-dev] [PATCH 3/3] f2fs: fix to cover meta flush with cp_lock X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/5/29 3:00, Jaegeuk Kim wrote: > On 05/28, Chao Yu wrote: >> On 2020/5/28 9:26, Jaegeuk Kim wrote: >>> On 05/28, Chao Yu wrote: >>>> On 2020/5/28 5:02, Jaegeuk Kim wrote: >>>>> On 05/27, Chao Yu wrote: >>>>>> meta inode page should be flushed under cp_lock, fix it. >>>>> >>>>> It doesn't matter for this case, yes? >>>> >>>> It's not related to discard issue. >>> >>> I meant we really need this or not. :P >> >> Yes, let's keep that rule: flush meta pages under cp_lock, otherwise >> checkpoint flush order may be broken due to race, right? as checkpoint >> should write 2rd cp park page after flushing all meta pages. > > Well, this is for shutdown test, and thus we don't need to sync up here. I'm a little worried about race condition: f2fs_write_checkpoint do_checkpoint ... shutdown f2fs_sync_meta_pages stop_checkpoint ... Though, I haven't figure out potential damage of their racing. > >> >>> >>>> >>>> Now, I got some progress, I can reproduce that bug occasionally. >>>> >>>> Thanks, >>>> >>>>> >>>>>> >>>>>> Signed-off-by: Chao Yu >>>>>> --- >>>>>> fs/f2fs/file.c | 2 ++ >>>>>> 1 file changed, 2 insertions(+) >>>>>> >>>>>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c >>>>>> index f7de2a1da528..0fcae4d90074 100644 >>>>>> --- a/fs/f2fs/file.c >>>>>> +++ b/fs/f2fs/file.c >>>>>> @@ -2260,7 +2260,9 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) >>>>>> set_sbi_flag(sbi, SBI_IS_SHUTDOWN); >>>>>> break; >>>>>> case F2FS_GOING_DOWN_METAFLUSH: >>>>>> + mutex_lock(&sbi->cp_mutex); >>>>>> f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_META_IO); >>>>>> + mutex_unlock(&sbi->cp_mutex); >>>>>> f2fs_stop_checkpoint(sbi, false); >>>>>> set_sbi_flag(sbi, SBI_IS_SHUTDOWN); >>>>>> break; >>>>>> -- >>>>>> 2.18.0.rc1 >>>>> . >>>>> >>> . >>> > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel