From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8562C2D0B1 for ; Wed, 5 Feb 2020 03:05:24 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 981D5214AF for ; Wed, 5 Feb 2020 03:05:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lists.sourceforge.net header.i=@lists.sourceforge.net header.b="d8mf1KbF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="iqMggYa0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="CAMUQzHV"; dkim=neutral (0-bit key) header.d=google.com header.i=@google.com header.b="a/rT7owE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 981D5214AF Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.sourceforge.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:To:Message-ID:Date:In-Reply-To:References: MIME-Version:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GYSTCiVls3M9PZz9K/rKb+QTcZRU1VYVFRv03Q42NS4=; b=d8mf1KbFbeSXlq6AYKgCSOU6aA E0yzGPl3vR00gxisHbxOr10HyctWPJneSBtUfani7X0sHU7mMUzjBDoAtqjMI1ta6J8mTfv/h9J0q 7KfpQNo/U5GvBu4RgjRSxjO1xzhJy8BFu5qtjeV246UXR0t91owLw/sPdXqg7GQGf8yU=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1izB0F-00052P-EA; Wed, 05 Feb 2020 03:05:23 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1izB0E-00052G-40 for linux-f2fs-devel@lists.sourceforge.net; Wed, 05 Feb 2020 03:05:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5WF1go+DuJvbwgdXeUhoD65NaX1JQ7zRHimo51GmC8M=; b=iqMggYa0tmhPPLTtQOsYK63Dsu OR13x0y8ssXc4z7knHnts55+FryAw4yxX4OTJeN69alhOgIfkajQJhGttJ2du3vEhrSxw6fAtMfIO cBGpdhxHF3eXvnHCksivUh5zaBc2x9sKFPXBJm6cIiwfBxKR+w7cX0cysmMfryucrNHs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5WF1go+DuJvbwgdXeUhoD65NaX1JQ7zRHimo51GmC8M=; b=CAMUQzHVpBjMyg6yJx6cKZYBRs abqLtzOF7GtfiyiCUMzODnfAxUmvinka+pQreSzHgUcqKVuK8yLd0xC28cZ/7aqzLAFxMj6QVgpD0 q931QLEOpJsQ0bVeGMcMe10uNCSi8ASl7q1KiBVobU4g8+XtcefwuK/EDE62/4CYi0wg=; Received: from mail-lf1-f66.google.com ([209.85.167.66]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1izB0C-00AXVg-Mh for linux-f2fs-devel@lists.sourceforge.net; Wed, 05 Feb 2020 03:05:22 +0000 Received: by mail-lf1-f66.google.com with SMTP id y19so350844lfl.9 for ; Tue, 04 Feb 2020 19:05:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5WF1go+DuJvbwgdXeUhoD65NaX1JQ7zRHimo51GmC8M=; b=a/rT7owEo3U/lPRFn35JOyHmNdZNKq3CUN5eC0vmSOAlGMUJJc7ELCvSX1Mh8APfaa lAlLVERWXR5pYN81ddhMclRnb/OmN5Fx2KddB7KuZLDfFPyFM3c5qNNCCjwGgxr+r3s1 DNCcaZvM6VYKACKmTz/OjiTlKJVFN9VL8YzEYvQS2U83lFvZUm1XWKOklUIkQxQvXozG vNU7Zo1syf0hTTILG3oFQfUcj+JQqVr59fj+c5MCVuSCuEvLrPxTFeYRhYsiMU1wniYS k/ew5rFlhFL2LzMHulEuIV3u33upCBPfLhXENQXAIsbZYUZT2I99yQmfa/FkquxeDAIP aNXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5WF1go+DuJvbwgdXeUhoD65NaX1JQ7zRHimo51GmC8M=; b=OmHtAg1RQyxz9mr7aSpXJLQSJ4lFFKMwVoPpLYL1hM1X0krNPz7MLAbUc6KZGplHNh /GDVAFaUhhiA92cJsl2PB+Dq1DUkLmq3fPdOSW0Zd3cKI/BE2rhpGVEK0mP85JVfe/sZ wTaCtC0ZwxWyV77WW2tb9CxtsoXn4MD5mrGgF757eIoxjwmDuKFnUCYiQmSQbN0YnyAT LMlQ5CmmpCfz4HXxfO4cEMYFhblHc7pA2z9BT9McV9njZ72Mcz4xjfGnvlmJ14qwDquk iU7bF0wM6gz3oquuuDvNSjzP/uEOF4/uz+b+JRDf2E+De9t9lHfvVtv8OyGpdwjxr6gp RWRw== X-Gm-Message-State: APjAAAWtwVnYeIH9D4l0LObUYSaaPXSDK8vPOEjNtmzN+l2hXhTv9YdO toaRrlSq9ZG6nCw+cdmf7AKJ9Q5V6ZCfoddBlxiJrtlADPar5w== X-Google-Smtp-Source: APXvYqzeG4caRRvcRllow4EA73MGmU6WFhFNYJbaTAD8sJamhzsXSFSCQuZUYpZgWEJovRgzDpyi7R9sxFKJltzNJtg= X-Received: by 2002:a19:4a92:: with SMTP id x140mr17094713lfa.29.1580871913677; Tue, 04 Feb 2020 19:05:13 -0800 (PST) MIME-Version: 1.0 References: <20200128230328.183524-1-drosen@google.com> <20200128230328.183524-2-drosen@google.com> <85sgjsxx2g.fsf@collabora.com> In-Reply-To: <85sgjsxx2g.fsf@collabora.com> Date: Tue, 4 Feb 2020 19:05:02 -0800 Message-ID: To: Gabriel Krisman Bertazi X-Headers-End: 1izB0C-00AXVg-Mh Subject: Re: [f2fs-dev] [PATCH v6 1/5] unicode: Add standard casefolded d_ops X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Daniel Rosenberg via Linux-f2fs-devel Reply-To: Daniel Rosenberg Cc: Theodore Ts'o , Jonathan Corbet , Richard Weinberger , Andreas Dilger , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Sun, Feb 2, 2020 at 5:46 PM Gabriel Krisman Bertazi wrote: > > > I don't think fs/unicode is the right place for these very specific > filesystem functions, just because they happen to use unicode. It is an > encoding library, it doesn't care about dentries, nor should know how to > handle them. It exposes a simple api to manipulate and convert utf8 strings. > > I saw change was after the desire to not have these functions polluting > the VFS hot path, but that has nothing to do with placing them here. > > Would libfs be better? or a casefolding library in fs/casefold.c? > > > -- > Gabriel Krisman Bertazi The hash function needs access to utf8ncursor, but apart from that, libfs would make sense. utf8ncursor is the only reason I have them here. How do you feel about exposing utf8cursor or something similar? _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel