From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84E37C433EF for ; Fri, 18 Mar 2022 19:37:59 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nVIQB-0003d1-JG; Fri, 18 Mar 2022 19:37:58 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nVIQA-0003ct-B9 for linux-f2fs-devel@lists.sourceforge.net; Fri, 18 Mar 2022 19:37:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZS9ok05PYKlNZu1rxfnTOBmw2CBJcOeQT2M61z+cNaM=; b=AvG8jARXUx1AzbYH+U53TQZw1G z7QlH/38QYetzpw0GQ1MwBgcpxwq7fBffWfzY0E4HxykhqzW5wxWubm2HB3hvu0xDC7236RTneedU LgZy8vqn1iA4irGdwZYkgDjZIfwiQrQ2ob5kxmTjPBk68u046+P//LIJItJTZThuLwAU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZS9ok05PYKlNZu1rxfnTOBmw2CBJcOeQT2M61z+cNaM=; b=jey6NhUJja3iUh3uHtxjiteK6D U4S15iCSsTsW5suC1E/0WjlASu331FV4bJeEtPLr1DZysNi4mgK0J/5s6Uu7d13e+ly4OYcOFHpgP xJ+GhVwR/Uegf4vqKZp3Okd2rn3LRVDn8ea3S1ku4OK7yxP3XizwlrVtpDcrGiyk+/6w=; Received: from mail-oo1-f51.google.com ([209.85.161.51]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.94.2) id 1nVIQ4-003OQh-2q for linux-f2fs-devel@lists.sourceforge.net; Fri, 18 Mar 2022 19:37:56 +0000 Received: by mail-oo1-f51.google.com with SMTP id y27-20020a4a9c1b000000b0032129651bb0so11369937ooj.2 for ; Fri, 18 Mar 2022 12:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZS9ok05PYKlNZu1rxfnTOBmw2CBJcOeQT2M61z+cNaM=; b=jIcNV6Y6FHF5WfQofdJeZLGkRRnKmqhlhP8GAhYV5fqxojJwo/iFsNSPY+BkpqUx7z cVnP2eLTY1pfuAozuXk/issL2JSOMhtZA+gPLzBCLnV4X2gfx+e35DiEB0llqIVUxNaw zClS82Yj+F+Z+MzHVvIlgQULs/WrocF2gkjtdtohEcYlpq/M9+X+CyeGgwengz0wUlsN iQVpXAo54MRxJIry/OK2L2T49djs92Umr4iyRknwjjs9Uw2/moDkBYWu7YyiUGTZRmw2 lCecRMLp+NgziUvdg1zC8O4201TG6JjJgSb2GpJede3OUOanB2ifRJDxvRCQ3D+3N918 q3WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZS9ok05PYKlNZu1rxfnTOBmw2CBJcOeQT2M61z+cNaM=; b=s3iQ+3y77rb/BcHg63EWWzmH010f2g4NSFGTZlAyoJnUxhLOpax7myx/5VP4Ry4MCx lP+fkjywABobSAtExKlF0KiWP2p+0pDxDyi5pkuyzgei1HUerYkAY3l0TO/alCCGrnRq FPQp8OKmgBhtl8x0Wjbv0o61iBsUiIvaCHRek637c6bSWB4Qnt6gt/dGf4Ulr1kqb+nJ dEcwd4+iX2IhG4f8/mCswCGVkXdOkr43O1VabUn6W8dYl9T3HF0kHIqid6QmAXQo6MKE b9raJ84gV93/09fgTjOcrs3BJInBrzF7O4R2VhCzU/eH54ffCPG8OEQAc6D1ZDLdkNA3 smyQ== X-Gm-Message-State: AOAM531907eWIZxhyLqjy4pMnSaCChalO1ifeEwhh8OSt6Am57+o2/Yv g6rBxzA1+F+qJjEj1RNDGbydQFAf3+Tb0ao3aFDsWPfoHxk= X-Google-Smtp-Source: ABdhPJwtCprt5WfOMNYtaolfRijaJQkSfbdULl/jCbQlU9R26vgNkGVJ0PVOEQw7N6gWxYJnOirUUqEN1URoIj/hfk0= X-Received: by 2002:a05:6870:58aa:b0:dd:a976:5e8f with SMTP id be42-20020a05687058aa00b000dda9765e8fmr5294282oab.112.1647630833948; Fri, 18 Mar 2022 12:13:53 -0700 (PDT) MIME-Version: 1.0 References: <20220318191012.4113266-1-daeho43@gmail.com> In-Reply-To: <20220318191012.4113266-1-daeho43@gmail.com> Date: Fri, 18 Mar 2022 12:13:18 -0700 Message-ID: To: Daeho Jeong X-Headers-End: 1nVIQ4-003OQh-2q Subject: Re: [f2fs-dev] [PATCH] f2fs: make gc_urgent and gc_segment_mode sysfs node readable X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Daeho Jeong via Linux-f2fs-devel Reply-To: Daeho Jeong Cc: kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Plz, sorry, ignore this one. On Fri, Mar 18, 2022 at 12:10 PM Daeho Jeong wrote: > > From: Daeho Jeong > > Changed a way of showing values of them to use strings. > > Signed-off-by: Daeho Jeong > --- > fs/f2fs/sysfs.c | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > index fe29bcb70f46..f2613cc83888 100644 > --- a/fs/f2fs/sysfs.c > +++ b/fs/f2fs/sysfs.c > @@ -41,6 +41,16 @@ enum { > ATGC_INFO, /* struct atgc_management */ > }; > > +const char *gc_mode_names[MAX_GC_MODE] = { > + "GC_NORMAL", > + "GC_IDLE_CB", > + "GC_IDLE_GREEDY", > + "GC_IDLE_AT", > + "GC_URGENT_HIGH", > + "GC_URGENT_LOW", > + "GC_URGENT_MID" > +}; > + > struct f2fs_attr { > struct attribute attr; > ssize_t (*show)(struct f2fs_attr *, struct f2fs_sb_info *, char *); > @@ -316,8 +326,13 @@ static ssize_t f2fs_sbi_show(struct f2fs_attr *a, > return sysfs_emit(buf, "%u\n", sbi->compr_new_inode); > #endif > > + if (!strcmp(a->attr.name, "gc_urgent")) > + return sysfs_emit(buf, "%s\n", > + gc_mode_names[sbi->gc_mode]); > + > if (!strcmp(a->attr.name, "gc_segment_mode")) > - return sysfs_emit(buf, "%u\n", sbi->gc_segment_mode); > + return sysfs_emit(buf, "%s\n", > + gc_mode_names[sbi->gc_segment_mode]); > > if (!strcmp(a->attr.name, "gc_reclaimed_segments")) { > return sysfs_emit(buf, "%u\n", > -- > 2.35.1.894.gb6a874cedc-goog > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel