From: Daeho Jeong <daeho43@gmail.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 3/4] f2fs: check write pointers when checkpoint=disable
Date: Mon, 4 Dec 2023 11:03:06 -0800 [thread overview]
Message-ID: <CACOAw_xo_73xxqUty_2e6mvPA8A45MXEefOe8gr7f7owU1XuXQ@mail.gmail.com> (raw)
In-Reply-To: <20231204180428.925779-3-jaegeuk@kernel.org>
LGTM
On Mon, Dec 4, 2023 at 10:06 AM Jaegeuk Kim <jaegeuk@kernel.org> wrote:
>
> Even if f2fs was rebooted as staying checkpoint=disable, let's match the write
> pointers all the time.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 617340e9ea7f..9a874b4d1501 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -4741,7 +4741,7 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
> #ifdef CONFIG_QUOTA
> f2fs_recover_quota_end(sbi, quota_enabled);
> #endif
> -
> +reset_checkpoint:
> /*
> * If the f2fs is not readonly and fsync data recovery succeeds,
> * check zoned block devices' write pointer consistency.
> @@ -4752,7 +4752,6 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
> goto free_meta;
> }
>
> -reset_checkpoint:
> f2fs_init_inmem_curseg(sbi);
>
> /* f2fs_recover_fsync_data() cleared this already */
> --
> 2.43.0.rc2.451.g8631bc7472-goog
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-12-04 21:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 18:04 [f2fs-dev] [PATCH 1/4] f2fs: allocate new section if it's not new Jaegeuk Kim
2023-12-04 18:04 ` [f2fs-dev] [PATCH 2/4] f2fs: fix write pointers on zoned device after roll forward Jaegeuk Kim
2023-12-04 19:02 ` Daeho Jeong
2023-12-04 18:04 ` [f2fs-dev] [PATCH 3/4] f2fs: check write pointers when checkpoint=disable Jaegeuk Kim
2023-12-04 19:03 ` Daeho Jeong [this message]
2023-12-04 18:04 ` [f2fs-dev] [PATCH 4/4] f2fs: let's finish or reset zones all the time Jaegeuk Kim
2023-12-04 19:11 ` Daeho Jeong
2023-12-05 19:29 ` [f2fs-dev] [PATCH 4/4 v2] " Jaegeuk Kim
2023-12-04 18:53 ` [f2fs-dev] [PATCH 1/4] f2fs: allocate new section if it's not new Daeho Jeong
2023-12-14 20:50 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACOAw_xo_73xxqUty_2e6mvPA8A45MXEefOe8gr7f7owU1XuXQ@mail.gmail.com \
--to=daeho43@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).