From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1573AC38142 for ; Tue, 31 Jan 2023 19:13:55 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pMw4o-0003DJ-Vv; Tue, 31 Jan 2023 19:13:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pMw4n-0003D9-Je for linux-f2fs-devel@lists.sourceforge.net; Tue, 31 Jan 2023 19:13:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fU8hV2aEVpS4Iv/7PLb42FnF+FtItn9zaQfC2HMeTsU=; b=gjH2+3SIpocktJHKs7CXcnPPln EisGoPS397NcDOMMAjPcMzhjOStKzVWs7tOCXZYKoL1yRU0W6BaMDRJPrHiFxCIZozsQgW3j6hUHm Oj1tVrdxpECSdr8RxZaYds1y5AJKhu82U+n9+FHKdqH49mOPvvvca+YpMqYZnTUvbPOw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fU8hV2aEVpS4Iv/7PLb42FnF+FtItn9zaQfC2HMeTsU=; b=VLMlGk/CnnV/HxXia4h2pg7P06 TgqaZ20LmQvrdtcO+uo+cZJleZcqqmgFiLyK3vdHN6b0vS5UeXdlYk66LZkP35FQH4LzaiiBzxHID DiWUzT2+IVNiU+VFk9AoDdl7B10fkx6mDewEW3oN0XMTKlZUFQipsdbANWBfUD9VVj6Y=; Received: from mail-yb1-f170.google.com ([209.85.219.170]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1pMw4l-0006d6-DR for linux-f2fs-devel@lists.sourceforge.net; Tue, 31 Jan 2023 19:13:52 +0000 Received: by mail-yb1-f170.google.com with SMTP id t16so19442697ybk.2 for ; Tue, 31 Jan 2023 11:13:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fU8hV2aEVpS4Iv/7PLb42FnF+FtItn9zaQfC2HMeTsU=; b=KsYqvtEwP03MFQk5D61D2vBAeDlqQG54FFVBErzdMjxwLxOrPHvbevBLnlpfttMCa6 +z9AyL1dT1w2QlZvxAwKwU4NlXv6mmxYYJCITbF6JYmEnc1Fj/U+ICRjVAESPbPfRfCH jya/MVCNMgL5cmZ73c/xhUenKPVzouZ5SGdwFHdG40Iqi1dgfaLbYGmL3QzWnBt3ml8V SsviGUZFhWswUh3qIlD14+dj4Y+jKNVRpDttZSDQZHf890I5w3ogBENQ9Is9JoqyiEaY wJgqm/tSPWSAPPLOC2MfQ859I6I+HN4kGaHJ2l+ImQjFkQissidTINWTUQ1tKLICK6Rr ljcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fU8hV2aEVpS4Iv/7PLb42FnF+FtItn9zaQfC2HMeTsU=; b=JCAKPbJtnkZ6XUaY+YHmG5lJ08vEwQ2iLdpn69jO4etiyO1K9NCbIUJ+R9lqkmTjqH cVuNCJ7K74TZ3OdnVxd+oRYwr41AhlJuDzxEqTOYgBASsNZxFxXVRg6KX5ESMeCCQKGK B56Nu/3Jk2iACU2nwlVycx7n74OE67kdTy8vlnp5ThZkgR8a+NW4yweABtLnDl/l7wBh S1j+AT+lXBU2XLyAHnAHISwtC+HGwyFcx94DmlJAVcFqUmcKHSgIh4ct+Z+aiugwgsTA OrT80LANUgVKVz7WfNCDMyQykrOqPYWW8vzGsjtOgjD0b3g+bTvM4hMJGA0U7fCY76Lx joEw== X-Gm-Message-State: AO0yUKV/LjZtV1XXAd3agH3Gx6xsJqkNSniRzYIBoSCaOEmhlKNQreaP P22sbAC/KGFU3+FsJt/4jjzt6c8IIPpzunzwIZ2l5xRh/yIQFQ== X-Google-Smtp-Source: AK7set+Uie+lj3Pdtiv1v/j1sXQlZe/9enF5aW+Sgy4MhweL9mhYmeuYt0ssdLoQkJHVoX7eTONZm2GOKikJBQw3bRE= X-Received: by 2002:a25:cf83:0:b0:7d6:8ddf:c85b with SMTP id f125-20020a25cf83000000b007d68ddfc85bmr7033ybg.307.1675192426266; Tue, 31 Jan 2023 11:13:46 -0800 (PST) MIME-Version: 1.0 References: <20230113004933.2082072-1-daeho43@gmail.com> <8f1c15a3-d056-7709-af45-fe7cba56463f@kernel.org> In-Reply-To: <8f1c15a3-d056-7709-af45-fe7cba56463f@kernel.org> From: Daeho Jeong Date: Tue, 31 Jan 2023 11:13:34 -0800 Message-ID: To: Chao Yu X-Headers-End: 1pMw4l-0006d6-DR Subject: Re: [f2fs-dev] [PATCH] f2fs: synchronize atomic write aborts X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong , kernel-team@android.com, linux-kernel@vger.kernel.org, syzbot+823000d23b3400619f7c@syzkaller.appspotmail.com, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hi Chao, On Tue, Jan 31, 2023 at 3:37 AM Chao Yu wrote: > > Hi Daeho, > > On 2023/1/31 0:34, Daeho Jeong wrote: > > Hi Chao, > > > > I read your patch series now and I like it. > > Thank you for checking the patches. :) > > > However, how about a race condition between start_atomic_write and > > abort_atomic_write? > > Yup, I noticed that issue, I guess we can avoid this race condition by > covering these two flows w/ i_atomic_sem. > > > abort_atomic_write is called without inode_lock in closing filp scenarios. > > What do you think about this? > > I'm fine w/ your change as it's more clean, but it's better to drop cow_inode's > page cache if atomic_write is committed or aborted to avoid caching obsolete page? It's better to put that part in f2fs_abort_atomic_write(). On top of that, maybe, we should move f2fs_do_truncate_blocks(fi->cow_inode, 0, true) part from f2fs_ioc_start_atomic_write() to f2fs_abort_atomic_write(), too. Thanks, > > Thanks, > > > > > Thanks, > > > > > > On Fri, Jan 27, 2023 at 6:07 PM Chao Yu wrote: > >> > >> Hi Daeho, Jaegeuk, > >> > >> Please take a look at patchset in below link: > >> > >> https://lore.kernel.org/linux-f2fs-devel/20230109034453.490176-1-chao@kernel.org/T/#t > >> > >> In PATCH 4/5, I'm trying to fix the same issue w/ alternative way, let me > >> know your preference. :) > >> > >> One comment as below. > >> > >> On 2023/1/13 8:49, Daeho Jeong wrote: > >>> From: Daeho Jeong > >>> > >>> To fix a race condition between atomic write aborts, I use the inode > >>> lock and make COW inode to be re-usable thoroughout the whole > >>> atomic file inode lifetime. > >>> > >>> Reported-by: syzbot+823000d23b3400619f7c@syzkaller.appspotmail.com > >>> Fixes: 3db1de0e582c ("f2fs: change the current atomic write way") > >>> Signed-off-by: Daeho Jeong > >>> --- > >>> fs/f2fs/file.c | 43 ++++++++++++++++++++++++++++--------------- > >>> fs/f2fs/inode.c | 11 +++++++++-- > >>> fs/f2fs/segment.c | 3 --- > >>> fs/f2fs/super.c | 2 -- > >>> 4 files changed, 37 insertions(+), 22 deletions(-) > >>> > >>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > >>> index ecbc8c135b49..ff072a9ed258 100644 > >>> --- a/fs/f2fs/file.c > >>> +++ b/fs/f2fs/file.c > >>> @@ -1866,7 +1866,10 @@ static int f2fs_release_file(struct inode *inode, struct file *filp) > >>> atomic_read(&inode->i_writecount) != 1) > >>> return 0; > >>> > >>> + inode_lock(inode); > >>> f2fs_abort_atomic_write(inode, true); > >>> + inode_unlock(inode); > >>> + > >>> return 0; > >>> } > >>> > >>> @@ -1880,8 +1883,11 @@ static int f2fs_file_flush(struct file *file, fl_owner_t id) > >>> * until all the writers close its file. Since this should be done > >>> * before dropping file lock, it needs to do in ->flush. > >>> */ > >>> - if (F2FS_I(inode)->atomic_write_task == current) > >>> + if (F2FS_I(inode)->atomic_write_task == current) { > >>> + inode_lock(inode); > >>> f2fs_abort_atomic_write(inode, true); > >>> + inode_unlock(inode); > >>> + } > >>> return 0; > >>> } > >>> > >>> @@ -2087,19 +2093,28 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate) > >>> goto out; > >>> } > >>> > >>> - /* Create a COW inode for atomic write */ > >>> - pinode = f2fs_iget(inode->i_sb, fi->i_pino); > >>> - if (IS_ERR(pinode)) { > >>> - f2fs_up_write(&fi->i_gc_rwsem[WRITE]); > >>> - ret = PTR_ERR(pinode); > >>> - goto out; > >>> - } > >>> + /* Check if the inode already has a COW inode */ > >>> + if (fi->cow_inode == NULL) { > >>> + /* Create a COW inode for atomic write */ > >>> + pinode = f2fs_iget(inode->i_sb, fi->i_pino); > >>> + if (IS_ERR(pinode)) { > >>> + f2fs_up_write(&fi->i_gc_rwsem[WRITE]); > >>> + ret = PTR_ERR(pinode); > >>> + goto out; > >>> + } > >>> > >>> - ret = f2fs_get_tmpfile(mnt_userns, pinode, &fi->cow_inode); > >>> - iput(pinode); > >>> - if (ret) { > >>> - f2fs_up_write(&fi->i_gc_rwsem[WRITE]); > >>> - goto out; > >>> + ret = f2fs_get_tmpfile(mnt_userns, pinode, &fi->cow_inode); > >>> + iput(pinode); > >>> + if (ret) { > >>> + f2fs_up_write(&fi->i_gc_rwsem[WRITE]); > >>> + goto out; > >>> + } > >>> + > >>> + set_inode_flag(fi->cow_inode, FI_COW_FILE); > >>> + clear_inode_flag(fi->cow_inode, FI_INLINE_DATA); > >>> + } else { > >>> + /* Reuse the already created COW inode */ > >>> + f2fs_do_truncate_blocks(fi->cow_inode, 0, true); > >>> } > >>> > >>> f2fs_write_inode(inode, NULL); > >>> @@ -2107,8 +2122,6 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate) > >>> stat_inc_atomic_inode(inode); > >>> > >>> set_inode_flag(inode, FI_ATOMIC_FILE); > >>> - set_inode_flag(fi->cow_inode, FI_COW_FILE); > >>> - clear_inode_flag(fi->cow_inode, FI_INLINE_DATA); > >>> > >>> isize = i_size_read(inode); > >>> fi->original_i_size = isize; > >>> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > >>> index ff6cf66ed46b..4921f7209e28 100644 > >>> --- a/fs/f2fs/inode.c > >>> +++ b/fs/f2fs/inode.c > >>> @@ -766,11 +766,18 @@ int f2fs_write_inode(struct inode *inode, struct writeback_control *wbc) > >>> void f2fs_evict_inode(struct inode *inode) > >>> { > >>> struct f2fs_sb_info *sbi = F2FS_I_SB(inode); > >>> - nid_t xnid = F2FS_I(inode)->i_xattr_nid; > >>> + struct f2fs_inode_info *fi = F2FS_I(inode); > >>> + nid_t xnid = fi->i_xattr_nid; > >>> int err = 0; > >>> > >>> f2fs_abort_atomic_write(inode, true); > >>> > >>> + if (fi->cow_inode) { > >>> + clear_inode_flag(fi->cow_inode, FI_COW_FILE); > >>> + iput(fi->cow_inode); > >>> + fi->cow_inode = NULL; > >>> + } > >>> + > >>> trace_f2fs_evict_inode(inode); > >>> truncate_inode_pages_final(&inode->i_data); > >>> > >>> @@ -857,7 +864,7 @@ void f2fs_evict_inode(struct inode *inode) > >>> stat_dec_inline_inode(inode); > >>> stat_dec_compr_inode(inode); > >>> stat_sub_compr_blocks(inode, > >>> - atomic_read(&F2FS_I(inode)->i_compr_blocks)); > >>> + atomic_read(&fi->i_compr_blocks)); > >>> > >>> if (likely(!f2fs_cp_error(sbi) && > >>> !is_sbi_flag_set(sbi, SBI_CP_DISABLED))) > >>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > >>> index ae3c4e5474ef..536d7c674b04 100644 > >>> --- a/fs/f2fs/segment.c > >>> +++ b/fs/f2fs/segment.c > >>> @@ -192,9 +192,6 @@ void f2fs_abort_atomic_write(struct inode *inode, bool clean) > >>> if (!f2fs_is_atomic_file(inode)) > >>> return; > >>> > >>> - clear_inode_flag(fi->cow_inode, FI_COW_FILE); > >>> - iput(fi->cow_inode); > >>> - fi->cow_inode = NULL; > >>> release_atomic_write_cnt(inode); > >>> clear_inode_flag(inode, FI_ATOMIC_COMMITTED); > >>> clear_inode_flag(inode, FI_ATOMIC_REPLACE); > >>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > >>> index 1f812b9ce985..10463f084d30 100644 > >>> --- a/fs/f2fs/super.c > >>> +++ b/fs/f2fs/super.c > >>> @@ -1430,8 +1430,6 @@ static int f2fs_drop_inode(struct inode *inode) > >>> atomic_inc(&inode->i_count); > >>> spin_unlock(&inode->i_lock); > >>> > >>> - f2fs_abort_atomic_write(inode, true); > >> > >> In order to avoid caching obsolete page of cow_inode, how about truncating > >> them here? > >> > >> if (f2fs_is_atomic_file() && cow_inode) > >> truncate_inode_pages_final(&cow_inode->i_data); > >> > >> Thanks, > >> > >>> - > >>> /* should remain fi->extent_tree for writepage */ > >>> f2fs_destroy_extent_node(inode); > >>> _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel