linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Namjae Jeon <linkinjeon@gmail.com>
To: Huajun Li <huajun.li@intel.com>
Cc: namjae.jeon@samsung.com, linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org
Subject: Re: [f2fs-dev] [RFC 0/5] Enable f2fs support inline data
Date: Tue, 4 Jun 2013 13:23:57 +0900	[thread overview]
Message-ID: <CAKYAXd-87rGatnEC8wbocR_wt6Qdpec3HzZaH9ukpzmst6DK=A@mail.gmail.com> (raw)
In-Reply-To: <1370312366.3600.3.camel@kjgkr>

Hi. Huajun.

I agree jaegeuk's opinion.
Additionally, It is better that you describe the effect in change-log
when this feature is added to f2fs.
e.g.
    1. how much space is saved when storing kernel-tree(small files) ?
    2. small files creation performance test.
    3. file look-up performance test.
    4. other performance tools 's result.

Thanks.

2013/6/4 Jaegeuk Kim <jaegeuk.kim@samsung.com>:
> Hi,
>
> This feature is one of my todo items. ;)
> Thank you for the contribution.
>
> Before reviewing the below code intensively, we need to check the
> following issues.
>
> - deadlock conditions
> - FS consistency
> - recovery routine
>
> Could you check one more time?
> Thanks again,
>
> 2013-06-03 (월), 18:04 +0800, Huajun Li:
>> f2fs inode is so large, small files can be stored directly in the inode,
>> rather than just storing a single block address and storing the data elsewhere.
>>
>> This RFC patch set is just to enable f2fs support inline data: files less than
>> about 3.6K can be stored directly in inode block.
>>
>> TODO: make small dirs inline too.
>>
>>
>> Haicheng Li (3):
>>   f2fs: Add helper functions and flag to support inline data
>>   f2fs: Add interface for inline data support
>>   f2fs: add tracepoints to debug inline data operations
>>
>> Huajun Li (2):
>>   f2fs: Handle inline data read and write
>>   f2fs: Key functions to handle inline data
>>
>>  fs/f2fs/Kconfig             |   10 +++
>>  fs/f2fs/Makefile            |    1 +
>>  fs/f2fs/data.c              |   78 +++++++++++++++++++++-
>>  fs/f2fs/f2fs.h              |   70 +++++++++++++++++++
>>  fs/f2fs/file.c              |    9 ++-
>>  fs/f2fs/inline.c            |  156 +++++++++++++++++++++++++++++++++++++++++++
>>  fs/f2fs/inode.c             |    8 +++
>>  include/linux/f2fs_fs.h     |    5 ++
>>  include/trace/events/f2fs.h |   69 +++++++++++++++++++
>>  9 files changed, 402 insertions(+), 4 deletions(-)
>>  create mode 100644 fs/f2fs/inline.c
>>
>
> --
> Jaegeuk Kim
> Samsung

------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. A cloud service to automate IT design, transition and operations
2. Dashboards that offer high-level views of enterprise services
3. A single system of record for all IT processes
http://p.sf.net/sfu/servicenow-d2d-j
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2013-06-04  4:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 10:04 [f2fs-dev] [RFC 0/5] Enable f2fs support inline data Huajun Li
2013-06-03 10:04 ` [RFC 1/5] f2fs: Add helper functions and flag to " Huajun Li
2013-06-03 10:04 ` [f2fs-dev] [RFC 2/5] f2fs: Handle inline data read and write Huajun Li
2013-06-03 10:04 ` [f2fs-dev] [RFC 3/5] f2fs: Key functions to handle inline data Huajun Li
2013-06-03 10:04 ` [f2fs-dev] [RFC 4/5] f2fs: Add Kconfig interface for inline data support Huajun Li
2013-06-03 10:04 ` [f2fs-dev] [RFC 5/5] f2fs: add tracepoints to debug inline data operations Huajun Li
2013-06-03 13:50   ` Steven Rostedt
2013-06-03 23:45     ` Haicheng Li
2013-06-04  2:19 ` [RFC 0/5] Enable f2fs support inline data Jaegeuk Kim
2013-06-04  4:23   ` Namjae Jeon [this message]
2013-06-04  6:01     ` Haicheng Li
2013-06-05  7:13       ` [f2fs-dev] " Jaegeuk Kim
2013-06-08  7:25         ` Huajun Li
2013-06-09 22:55           ` Jaegeuk Kim
2013-08-07 11:36           ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKYAXd-87rGatnEC8wbocR_wt6Qdpec3HzZaH9ukpzmst6DK=A@mail.gmail.com' \
    --to=linkinjeon@gmail.com \
    --cc=huajun.li@intel.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namjae.jeon@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).