From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EFC0C4361B for ; Mon, 7 Dec 2020 16:23:58 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E38323877 for ; Mon, 7 Dec 2020 16:23:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E38323877 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kmJIq-0002wm-ET; Mon, 07 Dec 2020 16:23:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmJIp-0002we-5Q for linux-f2fs-devel@lists.sourceforge.net; Mon, 07 Dec 2020 16:23:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jbuXSXkpWZcUp/VKpjCnoXJjYIN6M0CA6TkocxY3KN8=; b=icv+6JW2bA2ztfqnr9USDds5sX 9+8C3IH4++Dd36bXU8LfhsxiqO7MViAOVhxnt8oNy1pWPwZdVj562Q5xg5nqUoG71RuFFyEsUDhRv 5st+/aqxZrT7i5jwaMWvuLsb5ny3EhttEK7vajev2b3EnI2gWWPi/ovDMBuqLjzQXdT0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jbuXSXkpWZcUp/VKpjCnoXJjYIN6M0CA6TkocxY3KN8=; b=I7OCPxqsWgTUZHid+o1k0R+9Uv ZDUcnv31CnlGDr3fd90I66Y7z7jYfRWP4VCEYlOqDaFaGG6jpUyp9Hi3NEnhhVRZFGeqyl+M2MYdu UC/7PgH6d7pWKh5nEO8LjONZHcMkc6SiJYjqQopA5lHTgSABA943EaZ3BhtTyxWh3s4U=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kmJIi-005XrU-9g for linux-f2fs-devel@lists.sourceforge.net; Mon, 07 Dec 2020 16:23:55 +0000 Date: Mon, 7 Dec 2020 08:23:33 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607358215; bh=RtjDqwhG7C9VhOOl+aSC4bpaP4bWy/pDESZGvoZx9zU=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=DU++70I+51+gNFDYK6kI4FDLSxpKQIioYgO98XUgQD5TEitNO8fdoO6ZTJvlt/1/W p098+X1lEHR6GVBVarJB9paZJikaNWVh9rC9zVEOnF+38dt7Cb1DVavSB3d4Ou94Lv 006HQuqQMKuB1t4xq9n7jvVjFRadF035QrAsnLtr19qUgWftR3pj/UUTq3AvIs1Hym apmeZ0zxAs9vRgvpqBojlDjk/diVfwzykjYg6t3wsQz9fbFC7g/cbazu07923RBEKI dLWNhiGeS/dEfhyC3uIsO3x3y69Ux7EVAFWzUmsn/F3O/o8RYgp+0G+SG6wGe1fmvi xEQpVuRG7eSQg== From: Jaegeuk Kim To: Robin Hsu Message-ID: References: <20201207064250.272240-1-robinh3123@gmail.com> <20201207064250.272240-4-robinh3123@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201207064250.272240-4-robinh3123@gmail.com> X-Headers-End: 1kmJIi-005XrU-9g Subject: Re: [f2fs-dev] [PATCH v2 3/3] f2fs-tools:sload.f2fs compress: Fixed automake X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 12/07, Robin Hsu wrote: > From: Robin Hsu > > Fixed automake for sload.f2fs compression support > > ./configure now will by default depends on liblzo2 and liblz4. > > To compile without liblzo2 (and thus not support liblzo2 compression), > run ./configure with '--without-lzo2' option. > > To compile without liblz4 (and thus not support liblz4 compression), > run ./configure with '--without-lz4' option. > > Test: Build with automake OK on glinux > Bug: 170918502 > Signed-off-by: Robin Hsu > Change-Id: I25d339e4cab4ca196781da89fc3df3e13f869234 > --- > configure.ac | 32 ++++++++++++++++++++++++++++++++ > fsck/Makefile.am | 9 ++++++--- > 2 files changed, 38 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 1e5619d..3a357b2 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -44,6 +44,14 @@ AC_ARG_WITH([blkid], > AS_HELP_STRING([--without-blkid], > [Ignore presence of libblkid and disable blkid support])) > > +AC_ARG_WITH([lzo2], > + AS_HELP_STRING([--without-lzo2], > + [Ignore liblzo ver.2 for sload (not supporting lzo compression)])) > + > +AC_ARG_WITH([lz4], > + AS_HELP_STRING([--without-lz4], > + [Ignore liblz4 for sload (not supporting lz4 compression)])) > + > # Checks for programs. > AC_PROG_CC > AC_PROG_LIBTOOL > @@ -52,6 +60,30 @@ AC_PATH_PROG([LDCONFIG], [ldconfig], > [$PATH:/sbin]) > > # Checks for libraries. > +AS_IF([test "x$with_lzo2" != xno], > + [AC_CHECK_LIB([lzo2], [main], > + [AC_SUBST([liblzo2_LIBS], ["-llzo2"]) > + AC_DEFINE([HAVE_LIBLZO2], [1], > + [Define if you have liblzo2]) > + ], > + [if test "x$with_lzo2" != xcheck; then > + AC_MSG_FAILURE( > + [--with-lzo2 was given (or by default), but test for liblzo2 failed]) > + fi > + ], [])]) > + > +AS_IF([test "x$with_lz4" != xno], > + [AC_CHECK_LIB([lz4], [main], > + [AC_SUBST([liblz4_LIBS], ["-llz4"]) > + AC_DEFINE([HAVE_LIBLZ4], [1], > + [Define if you have liblz4]) > + ], > + [if test "x$with_lz4" != xcheck; then > + AC_MSG_FAILURE( > + [--with-lz4 was given (or by default), but test for liblz4 failed]) > + fi > + ], [])]) > + Please don't bother users to be aware of libraries only for sload.f2fs using compression. > PKG_CHECK_MODULES([libuuid], [uuid]) > > AS_IF([test "x$with_selinux" != "xno"], > diff --git a/fsck/Makefile.am b/fsck/Makefile.am > index 1fc7310..74bc4b8 100644 > --- a/fsck/Makefile.am > +++ b/fsck/Makefile.am > @@ -3,12 +3,15 @@ > AM_CPPFLAGS = ${libuuid_CFLAGS} -I$(top_srcdir)/include > AM_CFLAGS = -Wall > sbin_PROGRAMS = fsck.f2fs > -noinst_HEADERS = common.h dict.h dqblk_v2.h f2fs.h fsck.h node.h quotaio.h quotaio_tree.h quotaio_v2.h xattr.h > +noinst_HEADERS = common.h dict.h dqblk_v2.h f2fs.h fsck.h node.h quotaio.h \ > + quotaio_tree.h quotaio_v2.h xattr.h compress_wrapper.h > include_HEADERS = $(top_srcdir)/include/quota.h > fsck_f2fs_SOURCES = main.c fsck.c dump.c mount.c defrag.c resize.c \ > - node.c segment.c dir.c sload.c xattr.c \ > + node.c segment.c dir.c sload.c xattr.c compress_wrapper.c \ > dict.c mkquota.c quotaio.c quotaio_tree.c quotaio_v2.c > -fsck_f2fs_LDADD = ${libselinux_LIBS} ${libuuid_LIBS} $(top_builddir)/lib/libf2fs.la > +fsck_f2fs_LDADD = ${libselinux_LIBS} ${libuuid_LIBS} \ > + ${liblzo2_LIBS} ${liblz4_LIBS} \ > + $(top_builddir)/lib/libf2fs.la > > install-data-hook: > ln -sf fsck.f2fs $(DESTDIR)/$(sbindir)/dump.f2fs > -- > 2.29.2.576.ga3fc446d84-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel