From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C86BC38A2D for ; Mon, 24 Oct 2022 20:07:08 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1on3j1-0000EE-IE; Mon, 24 Oct 2022 20:07:07 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1on3j0-0000E1-P5 for linux-f2fs-devel@lists.sourceforge.net; Mon, 24 Oct 2022 20:07:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7MsR0R1NbSyB2Djzw/hFUhA/+5S6z5HyXDOZO3eVnQg=; b=XK2ubwvSo6T8ocK+x68/leqDnJ YZWMOBwFZixcYajQ+SKQT4w8Q7zZCGC21P+qwBoaHV49MpAwwKndkw7JikwtU1zlbDNI+fD2r7U8C 7y1muWaVQrM9OmYEzjekFhcCjoQEzbEKwtMqCN8JShqpZqGUrtXVoGOrJ1jUbSm60yFo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7MsR0R1NbSyB2Djzw/hFUhA/+5S6z5HyXDOZO3eVnQg=; b=M52vbdgN1S8DCzzzxr5iz3ZV7l 8UebY/ugSXICW8fIJvCitU+KXve+D8XG93i6kgWfRQ/VghPRYIrWJyBGAbGrMkAvVst+tBUgKwenr wilQx+ZFEndS+RpPCwXx6cvC9KwINzjo4n95A+CLlLU1LIQnx67+qJXv93JG52YDVkYo=; Received: from casper.infradead.org ([90.155.50.34]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1on3ix-00006c-F0 for linux-f2fs-devel@lists.sourceforge.net; Mon, 24 Oct 2022 20:07:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7MsR0R1NbSyB2Djzw/hFUhA/+5S6z5HyXDOZO3eVnQg=; b=Sz5j+RyAMJMG8UN49CI/nYQsRM 4uctA+lYIXec8+kZbgkhU9sfzm2Y04hWo+tPCEQTJyx3zRaNr9Wd20f0mK3a2nGhmAnFPqvsQD/k1 7mQnl5ZhzhFRoUDkH0U9c9iTvIWHP7suVXqBsD5AMkabioENS46bynM5C22QMostYhwbZ03GBCt64 C6ho4ykMx3e35M96kmpJGQH3OjDWH4lKrS9MHkdnK3z0AT1XCBM64Ux2LafoYepJsAbGzL+W6zQpV iWZYCZcRkajtC2dbalkjT9RGPcA20dSCql/hbVwpp6dr8//HsLsLv88DwGLSugrvIDPH/UYXKAClR wLAo/S/g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1on3ir-00FiEx-R3; Mon, 24 Oct 2022 20:06:57 +0000 Date: Mon, 24 Oct 2022 21:06:57 +0100 From: Matthew Wilcox To: "Vishal Moola (Oracle)" Message-ID: References: <20221017202451.4951-1-vishal.moola@gmail.com> <20221017202451.4951-4-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221017202451.4951-4-vishal.moola@gmail.com> X-Headers-End: 1on3ix-00006c-F0 Subject: Re: [f2fs-dev] [PATCH v3 03/23] filemap: Convert __filemap_fdatawait_range() to use filemap_get_folios_tag() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-cifs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Oct 17, 2022 at 01:24:31PM -0700, Vishal Moola (Oracle) wrote: > Converted function to use folios. This is in preparation for the removal > of find_get_pages_range_tag(). Yes, it is, but this patch also has some nice advantages of its own: - Removes a call to wait_on_page_writeback(), which removes a call to compound_head() - Removes a call to ClearPageError(), which removes another call to compound_head() - Removes a call to pagevec_release(), which will eventually remove a third call to compound_head() (it doesn't today, but one day ...) So you can definitely say that it removes 50 bytes of text and two calls to compound_head(). And that way, this patch justifies its existance by itself ;-) > Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Matthew Wilcox (Oracle) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel