* [f2fs-dev] [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed @ 2022-12-08 5:08 zhoudan8 2022-12-09 20:19 ` Jaegeuk Kim 0 siblings, 1 reply; 9+ messages in thread From: zhoudan8 @ 2022-12-08 5:08 UTC (permalink / raw) To: jaegeuk; +Cc: zhoudan8, linux-kernel, linux-f2fs-devel In compress_mode=user, f2fs_release_compress_blocks() does not verify whether it has been compressed and sets FI_COMPRESS_RELEASED directly. which will lead to return -EINVAL after calling compress. To fix it,let's do not set FI_COMPRESS_RELEASED if file is not compressed. Signed-off-by: zhoudan8 <zhoudan8@xiaomi.com> --- fs/f2fs/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 82cda1258227..f32910077df6 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -3451,14 +3451,13 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg) ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); if (ret) goto out; - - set_inode_flag(inode, FI_COMPRESS_RELEASED); inode->i_ctime = current_time(inode); f2fs_mark_inode_dirty_sync(inode, true); if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) goto out; + set_inode_flag(inode, FI_COMPRESS_RELEASED); f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); filemap_invalidate_lock(inode->i_mapping); -- 2.38.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed 2022-12-08 5:08 [f2fs-dev] [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed zhoudan8 @ 2022-12-09 20:19 ` Jaegeuk Kim 2022-12-12 12:21 ` zhoudan 2022-12-12 12:38 ` Chao Yu 0 siblings, 2 replies; 9+ messages in thread From: Jaegeuk Kim @ 2022-12-09 20:19 UTC (permalink / raw) To: zhoudan8; +Cc: zhoudan8, linux-kernel, linux-f2fs-devel On 12/08, zhoudan8 wrote: > In compress_mode=user, f2fs_release_compress_blocks() > does not verify whether it has been compressed and > sets FI_COMPRESS_RELEASED directly. which will lead to > return -EINVAL after calling compress. > To fix it,let's do not set FI_COMPRESS_RELEASED if file > is not compressed. Do you mean you want to avoid EINVAL on a file having FI_COMPRESS_RELEASED with zero i_compr_blokcs? I think the current logic is giving the error on a released file already. > > Signed-off-by: zhoudan8 <zhoudan8@xiaomi.com> > --- > fs/f2fs/file.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index 82cda1258227..f32910077df6 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -3451,14 +3451,13 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg) > ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); > if (ret) > goto out; > - > - set_inode_flag(inode, FI_COMPRESS_RELEASED); > inode->i_ctime = current_time(inode); > f2fs_mark_inode_dirty_sync(inode, true); > > if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) > goto out; > > + set_inode_flag(inode, FI_COMPRESS_RELEASED); > f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > filemap_invalidate_lock(inode->i_mapping); > > -- > 2.38.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed 2022-12-09 20:19 ` Jaegeuk Kim @ 2022-12-12 12:21 ` zhoudan 2022-12-12 23:05 ` Jaegeuk Kim 2022-12-12 12:38 ` Chao Yu 1 sibling, 1 reply; 9+ messages in thread From: zhoudan @ 2022-12-12 12:21 UTC (permalink / raw) To: Jaegeuk Kim; +Cc: zhoudan8, linux-kernel, linux-f2fs-devel Maybe I'm not describing it clearly enough, but I think there is something wrong with the logic here.The 'f2fs_release_compress_blocks' method does not determine if the file is compressed, but simply adds the FI_COMPRESS_RELEASED flag. In particular, in the current Android system, when the application is installed, the release interface is called by default to release the storage marked as compressed, without checking whether the file is actually compressed. In this case, when compress_mode is set to user, calling the compress interface returns ENVAL and the file cannot be compressed. So I think the implementation of release needs to be modified, and only set FI_COMPRESS_RELEASED when it's really compressed and the storage is released. On Fri, Dec 09, 2022 at 12:19:44PM -0800, Jaegeuk Kim wrote: > On 12/08, zhoudan8 wrote: > > In compress_mode=user, f2fs_release_compress_blocks() > > does not verify whether it has been compressed and > > sets FI_COMPRESS_RELEASED directly. which will lead to > > return -EINVAL after calling compress. > > To fix it,let's do not set FI_COMPRESS_RELEASED if file > > is not compressed. > > Do you mean you want to avoid EINVAL on a file having FI_COMPRESS_RELEASED > with zero i_compr_blokcs? > > I think the current logic is giving the error on a released file already. > > > > > Signed-off-by: zhoudan8 <zhoudan8@xiaomi.com> > > --- > > fs/f2fs/file.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > index 82cda1258227..f32910077df6 100644 > > --- a/fs/f2fs/file.c > > +++ b/fs/f2fs/file.c > > @@ -3451,14 +3451,13 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg) > > ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); > > if (ret) > > goto out; > > - > > - set_inode_flag(inode, FI_COMPRESS_RELEASED); > > inode->i_ctime = current_time(inode); > > f2fs_mark_inode_dirty_sync(inode, true); > > > > if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) > > goto out; > > > > + set_inode_flag(inode, FI_COMPRESS_RELEASED); > > f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > > filemap_invalidate_lock(inode->i_mapping); > > > > -- > > 2.38.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed 2022-12-12 12:21 ` zhoudan @ 2022-12-12 23:05 ` Jaegeuk Kim 2022-12-13 2:21 ` zhoudan 0 siblings, 1 reply; 9+ messages in thread From: Jaegeuk Kim @ 2022-12-12 23:05 UTC (permalink / raw) To: zhoudan; +Cc: zhoudan8, linux-kernel, linux-f2fs-devel On 12/12, zhoudan wrote: > Maybe I'm not describing it clearly enough, but I think there is > something wrong with the logic here.The 'f2fs_release_compress_blocks' > method does not determine if the file is compressed, but simply adds > the FI_COMPRESS_RELEASED flag. I firstly lost your point since f2fs_release_compress_blocks() checked f2fs_compressed_file(). > In particular, in the current Android system, when the application is > installed, the release interface is called by default to release the > storage marked as compressed, without checking whether the file is > actually compressed. In this case, when compress_mode is set to user, > calling the compress interface returns ENVAL and the file cannot be > compressed. > So I think the implementation of release needs to be modified, and > only set FI_COMPRESS_RELEASED when it's really compressed and the > storage is released. > > On Fri, Dec 09, 2022 at 12:19:44PM -0800, Jaegeuk Kim wrote: > > On 12/08, zhoudan8 wrote: > > > In compress_mode=user, f2fs_release_compress_blocks() > > > does not verify whether it has been compressed and > > > sets FI_COMPRESS_RELEASED directly. which will lead to > > > return -EINVAL after calling compress. > > > To fix it,let's do not set FI_COMPRESS_RELEASED if file > > > is not compressed. > > > > Do you mean you want to avoid EINVAL on a file having FI_COMPRESS_RELEASED > > with zero i_compr_blokcs? > > > > I think the current logic is giving the error on a released file already. > > > > > > > > Signed-off-by: zhoudan8 <zhoudan8@xiaomi.com> > > > --- > > > fs/f2fs/file.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > > index 82cda1258227..f32910077df6 100644 > > > --- a/fs/f2fs/file.c > > > +++ b/fs/f2fs/file.c > > > @@ -3451,14 +3451,13 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg) > > > ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); > > > if (ret) > > > goto out; > > > - > > > - set_inode_flag(inode, FI_COMPRESS_RELEASED); > > > inode->i_ctime = current_time(inode); > > > f2fs_mark_inode_dirty_sync(inode, true); > > > > > > if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) > > > goto out; > > > > > > + set_inode_flag(inode, FI_COMPRESS_RELEASED); > > > f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > > > filemap_invalidate_lock(inode->i_mapping); > > > > > > -- > > > 2.38.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed 2022-12-12 23:05 ` Jaegeuk Kim @ 2022-12-13 2:21 ` zhoudan 2022-12-16 11:17 ` zhou dan 0 siblings, 1 reply; 9+ messages in thread From: zhoudan @ 2022-12-13 2:21 UTC (permalink / raw) To: Jaegeuk Kim; +Cc: zhoudan8, linux-kernel, linux-f2fs-devel However, 'f2fs_compressed_file()' only determines whether the file can be compressed, not whether the file has been compressed. As far as I know, when compress_mode is user, files marked FI_COMPRESSED_FILE will be compressed only after 'f2fs_ioc_compress_file()' is called. On Mon, Dec 12, 2022 at 03:05:08PM -0800, Jaegeuk Kim wrote: > On 12/12, zhoudan wrote: > > Maybe I'm not describing it clearly enough, but I think there is > > something wrong with the logic here.The 'f2fs_release_compress_blocks' > > method does not determine if the file is compressed, but simply adds > > the FI_COMPRESS_RELEASED flag. > > I firstly lost your point since f2fs_release_compress_blocks() checked > f2fs_compressed_file(). > > > In particular, in the current Android system, when the application is > > installed, the release interface is called by default to release the > > storage marked as compressed, without checking whether the file is > > actually compressed. In this case, when compress_mode is set to user, > > calling the compress interface returns ENVAL and the file cannot be > > compressed. > > So I think the implementation of release needs to be modified, and > > only set FI_COMPRESS_RELEASED when it's really compressed and the > > storage is released. > > > > On Fri, Dec 09, 2022 at 12:19:44PM -0800, Jaegeuk Kim wrote: > > > On 12/08, zhoudan8 wrote: > > > > In compress_mode=user, f2fs_release_compress_blocks() > > > > does not verify whether it has been compressed and > > > > sets FI_COMPRESS_RELEASED directly. which will lead to > > > > return -EINVAL after calling compress. > > > > To fix it,let's do not set FI_COMPRESS_RELEASED if file > > > > is not compressed. > > > > > > Do you mean you want to avoid EINVAL on a file having FI_COMPRESS_RELEASED > > > with zero i_compr_blokcs? > > > > > > I think the current logic is giving the error on a released file already. > > > > > > > > > > > Signed-off-by: zhoudan8 <zhoudan8@xiaomi.com> > > > > --- > > > > fs/f2fs/file.c | 3 +-- > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > > > index 82cda1258227..f32910077df6 100644 > > > > --- a/fs/f2fs/file.c > > > > +++ b/fs/f2fs/file.c > > > > @@ -3451,14 +3451,13 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg) > > > > ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); > > > > if (ret) > > > > goto out; > > > > - > > > > - set_inode_flag(inode, FI_COMPRESS_RELEASED); > > > > inode->i_ctime = current_time(inode); > > > > f2fs_mark_inode_dirty_sync(inode, true); > > > > > > > > if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) > > > > goto out; > > > > > > > > + set_inode_flag(inode, FI_COMPRESS_RELEASED); > > > > f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > > > > filemap_invalidate_lock(inode->i_mapping); > > > > > > > > -- > > > > 2.38.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed 2022-12-13 2:21 ` zhoudan @ 2022-12-16 11:17 ` zhou dan 2023-01-04 2:29 ` Jaegeuk Kim 0 siblings, 1 reply; 9+ messages in thread From: zhou dan @ 2022-12-16 11:17 UTC (permalink / raw) To: Jaegeuk Kim; +Cc: zhoudan8, linux-kernel, linux-f2fs-devel Hi, about this patch, I haven't received any reply recently. Maybe you have some new ideas to solve this problem? zhoudan <zhuqiandann@gmail.com> 于2022年12月13日周二 10:21写道： > > However, 'f2fs_compressed_file()' only determines whether the file can > be compressed, not whether the file has been compressed. As far as I > know, when compress_mode is user, files marked FI_COMPRESSED_FILE > will be compressed only after 'f2fs_ioc_compress_file()' is called. > On Mon, Dec 12, 2022 at 03:05:08PM -0800, Jaegeuk Kim wrote: > > On 12/12, zhoudan wrote: > > > Maybe I'm not describing it clearly enough, but I think there is > > > something wrong with the logic here.The 'f2fs_release_compress_blocks' > > > method does not determine if the file is compressed, but simply adds > > > the FI_COMPRESS_RELEASED flag. > > > > I firstly lost your point since f2fs_release_compress_blocks() checked > > f2fs_compressed_file(). > > > > > In particular, in the current Android system, when the application is > > > installed, the release interface is called by default to release the > > > storage marked as compressed, without checking whether the file is > > > actually compressed. In this case, when compress_mode is set to user, > > > calling the compress interface returns ENVAL and the file cannot be > > > compressed. > > > So I think the implementation of release needs to be modified, and > > > only set FI_COMPRESS_RELEASED when it's really compressed and the > > > storage is released. > > > > > > On Fri, Dec 09, 2022 at 12:19:44PM -0800, Jaegeuk Kim wrote: > > > > On 12/08, zhoudan8 wrote: > > > > > In compress_mode=user, f2fs_release_compress_blocks() > > > > > does not verify whether it has been compressed and > > > > > sets FI_COMPRESS_RELEASED directly. which will lead to > > > > > return -EINVAL after calling compress. > > > > > To fix it,let's do not set FI_COMPRESS_RELEASED if file > > > > > is not compressed. > > > > > > > > Do you mean you want to avoid EINVAL on a file having FI_COMPRESS_RELEASED > > > > with zero i_compr_blokcs? > > > > > > > > I think the current logic is giving the error on a released file already. > > > > > > > > > > > > > > Signed-off-by: zhoudan8 <zhoudan8@xiaomi.com> > > > > > --- > > > > > fs/f2fs/file.c | 3 +-- > > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > > > > index 82cda1258227..f32910077df6 100644 > > > > > --- a/fs/f2fs/file.c > > > > > +++ b/fs/f2fs/file.c > > > > > @@ -3451,14 +3451,13 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg) > > > > > ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); > > > > > if (ret) > > > > > goto out; > > > > > - > > > > > - set_inode_flag(inode, FI_COMPRESS_RELEASED); > > > > > inode->i_ctime = current_time(inode); > > > > > f2fs_mark_inode_dirty_sync(inode, true); > > > > > > > > > > if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) > > > > > goto out; > > > > > > > > > > + set_inode_flag(inode, FI_COMPRESS_RELEASED); > > > > > f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > > > > > filemap_invalidate_lock(inode->i_mapping); > > > > > > > > > > -- > > > > > 2.38.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed 2022-12-16 11:17 ` zhou dan @ 2023-01-04 2:29 ` Jaegeuk Kim 2023-01-11 2:47 ` zhou dan 0 siblings, 1 reply; 9+ messages in thread From: Jaegeuk Kim @ 2023-01-04 2:29 UTC (permalink / raw) To: zhou dan; +Cc: zhoudan8, linux-kernel, linux-f2fs-devel On 12/16, zhou dan wrote: > Hi, about this patch, I haven't received any reply recently. > Maybe you have some new ideas to solve this problem? Could you please describe the exact flow that you're suffering from? > > > zhoudan <zhuqiandann@gmail.com> 于2022年12月13日周二 10:21写道： > > > > However, 'f2fs_compressed_file()' only determines whether the file can > > be compressed, not whether the file has been compressed. As far as I > > know, when compress_mode is user, files marked FI_COMPRESSED_FILE > > will be compressed only after 'f2fs_ioc_compress_file()' is called. > > On Mon, Dec 12, 2022 at 03:05:08PM -0800, Jaegeuk Kim wrote: > > > On 12/12, zhoudan wrote: > > > > Maybe I'm not describing it clearly enough, but I think there is > > > > something wrong with the logic here.The 'f2fs_release_compress_blocks' > > > > method does not determine if the file is compressed, but simply adds > > > > the FI_COMPRESS_RELEASED flag. > > > > > > I firstly lost your point since f2fs_release_compress_blocks() checked > > > f2fs_compressed_file(). > > > > > > > In particular, in the current Android system, when the application is > > > > installed, the release interface is called by default to release the > > > > storage marked as compressed, without checking whether the file is > > > > actually compressed. In this case, when compress_mode is set to user, > > > > calling the compress interface returns ENVAL and the file cannot be > > > > compressed. > > > > So I think the implementation of release needs to be modified, and > > > > only set FI_COMPRESS_RELEASED when it's really compressed and the > > > > storage is released. > > > > > > > > On Fri, Dec 09, 2022 at 12:19:44PM -0800, Jaegeuk Kim wrote: > > > > > On 12/08, zhoudan8 wrote: > > > > > > In compress_mode=user, f2fs_release_compress_blocks() > > > > > > does not verify whether it has been compressed and > > > > > > sets FI_COMPRESS_RELEASED directly. which will lead to > > > > > > return -EINVAL after calling compress. > > > > > > To fix it,let's do not set FI_COMPRESS_RELEASED if file > > > > > > is not compressed. > > > > > > > > > > Do you mean you want to avoid EINVAL on a file having FI_COMPRESS_RELEASED > > > > > with zero i_compr_blokcs? > > > > > > > > > > I think the current logic is giving the error on a released file already. > > > > > > > > > > > > > > > > > Signed-off-by: zhoudan8 <zhoudan8@xiaomi.com> > > > > > > --- > > > > > > fs/f2fs/file.c | 3 +-- > > > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > > > > > index 82cda1258227..f32910077df6 100644 > > > > > > --- a/fs/f2fs/file.c > > > > > > +++ b/fs/f2fs/file.c > > > > > > @@ -3451,14 +3451,13 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg) > > > > > > ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); > > > > > > if (ret) > > > > > > goto out; > > > > > > - > > > > > > - set_inode_flag(inode, FI_COMPRESS_RELEASED); > > > > > > inode->i_ctime = current_time(inode); > > > > > > f2fs_mark_inode_dirty_sync(inode, true); > > > > > > > > > > > > if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) > > > > > > goto out; > > > > > > > > > > > > + set_inode_flag(inode, FI_COMPRESS_RELEASED); > > > > > > f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > > > > > > filemap_invalidate_lock(inode->i_mapping); > > > > > > > > > > > > -- > > > > > > 2.38.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed 2023-01-04 2:29 ` Jaegeuk Kim @ 2023-01-11 2:47 ` zhou dan 0 siblings, 0 replies; 9+ messages in thread From: zhou dan @ 2023-01-11 2:47 UTC (permalink / raw) To: Jaegeuk Kim, chao; +Cc: zhoudan8, linux-kernel, linux-f2fs-devel On Android S, after the app is installed, it will judge whether the file is allowed to be compressed and release it. In the case of compress_mode=user, the file is not compressed at this point, causing EVNAL to be returned on subsequent executions to release. In the method 'isCompressionAllowed', there is also such a notice:"NOTE: The return value does not mean if the given file, or any other file on the same file system, is actually compressed. It merely determines whether not files <em>may</em> be compressed." On Wed, Jan 4, 2023 at 10:29 AM Jaegeuk Kim <jaegeuk@kernel.org> wrote: > > On 12/16, zhou dan wrote: > > Hi, about this patch, I haven't received any reply recently. > > Maybe you have some new ideas to solve this problem? > > Could you please describe the exact flow that you're suffering from? > > > > > > > zhoudan <zhuqiandann@gmail.com> 于2022年12月13日周二 10:21写道： > > > > > > However, 'f2fs_compressed_file()' only determines whether the file can > > > be compressed, not whether the file has been compressed. As far as I > > > know, when compress_mode is user, files marked FI_COMPRESSED_FILE > > > will be compressed only after 'f2fs_ioc_compress_file()' is called. > > > On Mon, Dec 12, 2022 at 03:05:08PM -0800, Jaegeuk Kim wrote: > > > > On 12/12, zhoudan wrote: > > > > > Maybe I'm not describing it clearly enough, but I think there is > > > > > something wrong with the logic here.The 'f2fs_release_compress_blocks' > > > > > method does not determine if the file is compressed, but simply adds > > > > > the FI_COMPRESS_RELEASED flag. > > > > > > > > I firstly lost your point since f2fs_release_compress_blocks() checked > > > > f2fs_compressed_file(). > > > > > > > > > In particular, in the current Android system, when the application is > > > > > installed, the release interface is called by default to release the > > > > > storage marked as compressed, without checking whether the file is > > > > > actually compressed. In this case, when compress_mode is set to user, > > > > > calling the compress interface returns ENVAL and the file cannot be > > > > > compressed. > > > > > So I think the implementation of release needs to be modified, and > > > > > only set FI_COMPRESS_RELEASED when it's really compressed and the > > > > > storage is released. > > > > > > > > > > On Fri, Dec 09, 2022 at 12:19:44PM -0800, Jaegeuk Kim wrote: > > > > > > On 12/08, zhoudan8 wrote: > > > > > > > In compress_mode=user, f2fs_release_compress_blocks() > > > > > > > does not verify whether it has been compressed and > > > > > > > sets FI_COMPRESS_RELEASED directly. which will lead to > > > > > > > return -EINVAL after calling compress. > > > > > > > To fix it,let's do not set FI_COMPRESS_RELEASED if file > > > > > > > is not compressed. > > > > > > > > > > > > Do you mean you want to avoid EINVAL on a file having FI_COMPRESS_RELEASED > > > > > > with zero i_compr_blokcs? > > > > > > > > > > > > I think the current logic is giving the error on a released file already. > > > > > > > > > > > > > > > > > > > > Signed-off-by: zhoudan8 <zhoudan8@xiaomi.com> > > > > > > > --- > > > > > > > fs/f2fs/file.c | 3 +-- > > > > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > > > > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > > > > > > index 82cda1258227..f32910077df6 100644 > > > > > > > --- a/fs/f2fs/file.c > > > > > > > +++ b/fs/f2fs/file.c > > > > > > > @@ -3451,14 +3451,13 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg) > > > > > > > ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); > > > > > > > if (ret) > > > > > > > goto out; > > > > > > > - > > > > > > > - set_inode_flag(inode, FI_COMPRESS_RELEASED); > > > > > > > inode->i_ctime = current_time(inode); > > > > > > > f2fs_mark_inode_dirty_sync(inode, true); > > > > > > > > > > > > > > if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) > > > > > > > goto out; > > > > > > > > > > > > > > + set_inode_flag(inode, FI_COMPRESS_RELEASED); > > > > > > > f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > > > > > > > filemap_invalidate_lock(inode->i_mapping); > > > > > > > > > > > > > > -- > > > > > > > 2.38.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed 2022-12-09 20:19 ` Jaegeuk Kim 2022-12-12 12:21 ` zhoudan @ 2022-12-12 12:38 ` Chao Yu 1 sibling, 0 replies; 9+ messages in thread From: Chao Yu @ 2022-12-12 12:38 UTC (permalink / raw) To: Jaegeuk Kim, zhoudan8; +Cc: zhoudan8, linux-kernel, linux-f2fs-devel On 2022/12/10 4:19, Jaegeuk Kim wrote: > On 12/08, zhoudan8 wrote: >> In compress_mode=user, f2fs_release_compress_blocks() >> does not verify whether it has been compressed and >> sets FI_COMPRESS_RELEASED directly. which will lead to >> return -EINVAL after calling compress. >> To fix it,let's do not set FI_COMPRESS_RELEASED if file >> is not compressed. > > Do you mean you want to avoid EINVAL on a file having FI_COMPRESS_RELEASED > with zero i_compr_blokcs? > > I think the current logic is giving the error on a released file already. IMO, if i_compr_blocks is zero, it's better to return -EINVAL in f2fs_release_compress_blocks(), as there will be no benefit after the conversion. Thanks, > >> >> Signed-off-by: zhoudan8 <zhoudan8@xiaomi.com> >> --- >> fs/f2fs/file.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c >> index 82cda1258227..f32910077df6 100644 >> --- a/fs/f2fs/file.c >> +++ b/fs/f2fs/file.c >> @@ -3451,14 +3451,13 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg) >> ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); >> if (ret) >> goto out; >> - >> - set_inode_flag(inode, FI_COMPRESS_RELEASED); >> inode->i_ctime = current_time(inode); >> f2fs_mark_inode_dirty_sync(inode, true); >> >> if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) >> goto out; >> >> + set_inode_flag(inode, FI_COMPRESS_RELEASED); >> f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); >> filemap_invalidate_lock(inode->i_mapping); >> >> -- >> 2.38.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-01-11 2:48 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-12-08 5:08 [f2fs-dev] [PATCH] f2fs: don't set FI_COMPRESS_RELEASED if file is not compressed zhoudan8 2022-12-09 20:19 ` Jaegeuk Kim 2022-12-12 12:21 ` zhoudan 2022-12-12 23:05 ` Jaegeuk Kim 2022-12-13 2:21 ` zhoudan 2022-12-16 11:17 ` zhou dan 2023-01-04 2:29 ` Jaegeuk Kim 2023-01-11 2:47 ` zhou dan 2022-12-12 12:38 ` Chao Yu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).