From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Yangtao Li <frank.li@vivo.com>
Subject: Re: [f2fs-dev] [PATCH 1/4] f2fs: reset iostat_count in f2fs_reset_iostat()
Date: Wed, 11 Jan 2023 11:17:10 -0800 [thread overview]
Message-ID: <Y78LNobSXGF5N3tn@google.com> (raw)
In-Reply-To: <7378f01b-3f02-a81c-7266-c743381131fb@kernel.org>
On 01/11, Chao Yu wrote:
> On 2023/1/5 3:20, Jaegeuk Kim wrote:
> > Hi Yangtao,
> >
> > These are all in dev-test branch, which means you don't need to stack up more
> > patches on top of it. I just integrated most of them into two original patches.
> > Could you please take a look at this?
> >
> > c1706cc0cd72 f2fs: add iostat support for flush
> > acd6f525e01c f2fs: support accounting iostat count and avg_bytes
>
> +#define IOSTAT_INFO_SHOW(name, type) \
> + seq_printf(seq, "%-23s %-16llu %-16llu %-16llu\n", \
> + name":", sbi->iostat_bytes[type], \
> + sbi->iostat_count[type], \
> + iostat_get_avg_bytes(sbi, type)) \
>
> '\' doesn't align in column, otherwise it looks good to me.
Applied with the fix.
>
> Reviewed-by: Chao Yu <chao@kernel.org>
>
> Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-01-11 19:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 11:21 [f2fs-dev] [PATCH 1/4] f2fs: reset iostat_count in f2fs_reset_iostat() Yangtao Li via Linux-f2fs-devel
2023-01-04 11:21 ` [f2fs-dev] [PATCH 2/4] f2fs: no need to call ktime_get_real_seconds() if iostat is not enabled Yangtao Li via Linux-f2fs-devel
2023-01-04 11:21 ` [f2fs-dev] [PATCH 3/4] f2fs: introduce IOSTAT_INFO_SHOW macro Yangtao Li via Linux-f2fs-devel
2023-01-04 11:21 ` [f2fs-dev] [PATCH 4/4] f2fs: rename rw_iostat to iostat_bytes Yangtao Li via Linux-f2fs-devel
2023-01-04 19:20 ` [f2fs-dev] [PATCH 1/4] f2fs: reset iostat_count in f2fs_reset_iostat() Jaegeuk Kim
2023-01-11 14:06 ` Chao Yu
2023-01-11 19:17 ` Jaegeuk Kim [this message]
2023-01-12 15:13 ` Yangtao Li via Linux-f2fs-devel
2023-01-12 23:59 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y78LNobSXGF5N3tn@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=frank.li@vivo.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).