From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Fengnan Chang <changfengnan@vivo.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: compress: avoid unnecessary check in f2fs_prepare_compress_overwrite
Date: Tue, 4 May 2021 08:56:18 -0700 [thread overview]
Message-ID: <YJFuov0gQT+ZzNOM@google.com> (raw)
In-Reply-To: <20210428024927.645-1-changfengnan@vivo.com>
On 04/28, Fengnan Chang wrote:
> when write compressed file with O_TRUNC, there will be a lot of
> unnecessary check valid blocks in f2fs_prepare_compress_overwrite,
> especially when written in page size, remove it.
>
> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
> ---
> fs/f2fs/data.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index cf935474ffba..4cfc0472bc2d 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -3270,6 +3270,9 @@ static int f2fs_write_begin(struct file *file, struct address_space *mapping,
> struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
> struct page *page = NULL;
> pgoff_t index = ((unsigned long long) pos) >> PAGE_SHIFT;
> +#ifdef CONFIG_F2FS_FS_COMPRESSION
> + pgoff_t end = (i_size_read(inode) + PAGE_SIZE - 1) >> PAGE_SHIFT;
Need to move this below?
> +#endif
> bool need_balance = false, drop_atomic = false;
> block_t blkaddr = NULL_ADDR;
> int err = 0;
> @@ -3306,6 +3309,9 @@ static int f2fs_write_begin(struct file *file, struct address_space *mapping,
>
> *fsdata = NULL;
>
> + if (index >= end)
> + goto repeat;
> +
> ret = f2fs_prepare_compress_overwrite(inode, pagep,
> index, fsdata);
> if (ret < 0) {
> --
> 2.29.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2021-05-04 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 2:49 [f2fs-dev] [PATCH v2] f2fs: compress: avoid unnecessary check in f2fs_prepare_compress_overwrite Fengnan Chang
2021-05-04 15:56 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJFuov0gQT+ZzNOM@google.com \
--to=jaegeuk@kernel.org \
--cc=changfengnan@vivo.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).