From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EB2EC433B4 for ; Tue, 11 May 2021 00:21:52 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59B3B61076; Tue, 11 May 2021 00:21:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59B3B61076 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lgG9l-00063a-Rn; Tue, 11 May 2021 00:21:49 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgG9j-00063S-FW for linux-f2fs-devel@lists.sourceforge.net; Tue, 11 May 2021 00:21:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pVD109YQP66zpRyqEqfxdySVgnrFmb0t09GsRTtxVO4=; b=KOUMR/oEZi+Kcn6bwQWdzYIFKh FtNwY7UrA3MNKlBu5jSW1Cr64F3o2rmzfCScPfRdcgplIm+VRVw+Z0YOPh6uDP/P+7eLQxmVYjzO8 LmDoAhxpYtPpnGqPYracEnO1LZ6eO8DG5MbBkRhqRVUJXrljohmUyl77OZAHxvHHkY9Q=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pVD109YQP66zpRyqEqfxdySVgnrFmb0t09GsRTtxVO4=; b=IQu0EILr/jIQLO/AInUMn98lGh a2MOsQ7Z2PomCELbSIPT/+bi1URR5wDnZn3tpKKzMC9A4QSnq50u3b1+gUuIraaN7f7adwdRRioZU 9qNwehZLamPntVpY04dzQFX+ywkgsxt6/1oWcGpyGUN3c/w9uPYlJx05RqpxfebjZfTQ=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1lgG9c-003CEy-2p for linux-f2fs-devel@lists.sourceforge.net; Tue, 11 May 2021 00:21:49 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7F28A61076; Tue, 11 May 2021 00:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620692494; bh=D7+FwB6wNN0y7dvFP+IevrpYhvlfmJwLrmX2r+rCwDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UCXWIZy4TrRnCP1EkRT4CWaXC+/SMGJWlqplUeXY8l1cA9TOUxiP68X7bOE/vDGYR o/W+bl9Y+919fZU+OUi+73a4GjLMt6iSwefA6Gi1Ng+k/H5xGRtvLLW/pAHodXnh/p 0ZteAzCxRFkdWvT4ECp30MtuT2cAqQv8nX+FN+sHQpoaTjNgByqSmJXrw85MtdzQha Pa32btRkDKsWq7ru/sAJXiW0Kb9eWsar9Po7c+y5vDT8gNb+tNwZ9O27xtXJ+JcNw0 2HmAj0KklstW+SqSGjyHnp6zw1sgGPfOOywb5k+LUgow8sljxscNyq3qOdexKtlsy5 yUnmYDzdDw+iw== Date: Mon, 10 May 2021 17:21:33 -0700 From: Jaegeuk Kim To: Eric Biggers Message-ID: References: <20210506191347.1242802-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1lgG9c-003CEy-2p Subject: Re: [f2fs-dev] [PATCH v2] f2fs: support iflag change given the mask X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/10, Eric Biggers wrote: > On Mon, May 10, 2021 at 07:42:27AM -0700, Jaegeuk Kim wrote: > > In f2fs_fileattr_set(), > > > > if (!fa->flags_valid) > > mask &= FS_COMMON_FL; > > > > In this case, we can set supported flags by mask only instead of BUG_ON. > > > > /* Flags shared betwen flags/xflags */ > > (FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \ > > FS_NODUMP_FL | FS_NOATIME_FL | FS_DAX_FL | \ > > FS_PROJINHERIT_FL) > > > > Fixes: 4c5b47997521 ("vfs: add fileattr ops") > > Shouldn't it be: > > Fixes: 9b1bb01c8ae7 ("f2fs: convert to fileattr") Heh, thank you. I applied this change in the git. :) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel