From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: introduce cf_name_slab cache
Date: Mon, 7 Jun 2021 16:47:41 -0700 [thread overview]
Message-ID: <YL6wHViJbCKVGx4K@gmail.com> (raw)
In-Reply-To: <20210607232715.3669-1-chao@kernel.org>
On Tue, Jun 08, 2021 at 07:27:15AM +0800, Chao Yu wrote:
> From: Chao Yu <yuchao0@huawei.com>
>
> Add a slab cache: "f2fs_casefold_name_entry" for memory allocation
> of casefold name.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/dir.c | 16 ++++++++++------
> fs/f2fs/recovery.c | 6 +++++-
> fs/f2fs/super.c | 24 ++++++++++++++++++++++++
> 3 files changed, 39 insertions(+), 7 deletions(-)
Looks good, but "f2fs_casefolded_name" would be a better name for this cache.
"f2fs_casefold_name_entry" makes it sounds like it contains some bookkeeping
information and not the actual casefolded filenames.
>
> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> index 96dcc4aca639..ee400562157d 100644
> --- a/fs/f2fs/dir.c
> +++ b/fs/f2fs/dir.c
> @@ -16,6 +16,10 @@
> #include "xattr.h"
> #include <trace/events/f2fs.h>
>
> +#ifdef CONFIG_UNICODE
> +extern struct kmem_cache *cf_name_slab;
> +#endif
Also this variable needs to be prefixed with "f2fs_". Otherwise this will cause
a build error if/when ext4 adds the same thing.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-06-07 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 23:27 [f2fs-dev] [PATCH] f2fs: introduce cf_name_slab cache Chao Yu
2021-06-07 23:47 ` Eric Biggers [this message]
2021-06-08 0:01 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL6wHViJbCKVGx4K@gmail.com \
--to=ebiggers@kernel.org \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).