From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2417C4338F for ; Thu, 5 Aug 2021 02:53:55 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A52E260F14 for ; Thu, 5 Aug 2021 02:53:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A52E260F14 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mBTW6-0006cq-1u; Thu, 05 Aug 2021 02:53:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBTW5-0006ch-Fv for linux-f2fs-devel@lists.sourceforge.net; Thu, 05 Aug 2021 02:53:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TNGvX8wQ8xlvkBYB7jF+/sPXDu3sV8Nt/1hONLud/XI=; b=NXsVZofTUWI2CzC3wS8fdm0w8x fSwlsV9QG9o6P6X8AiqHzA3YOehh9c/tJ3G+EpqBjKC5FU3jFKK7ICAVpndhgOEPBKsh8pPoZb0rN D2cxTKQke3K+9w5yYTPdeJxoQKeN4ok7dJyWFbv4HUBmKuNVoob1BU03Xw2i4WQK0kmY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TNGvX8wQ8xlvkBYB7jF+/sPXDu3sV8Nt/1hONLud/XI=; b=AFJiezA0aCB1l+MBTUV32kkKUJ VHq34YK8ADvQ5CFXmez8NI9GG4zaaNrAFdI0lFYhzloEi/09OKo3bZFWaI/xRLIYG2YXPGM9HmBOh NlRrXQat9eVqzbUf9+Lw4WLVMxH+/+JwkzF9U4ZUrSpbtIvhNfzSgxCDL8xIghefGRhI=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mBTVw-0007s0-RP for linux-f2fs-devel@lists.sourceforge.net; Thu, 05 Aug 2021 02:53:53 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4B13C61037; Thu, 5 Aug 2021 02:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628132014; bh=572pJp3ee6li9WZRwxOQIDTFDcCjD3QXQ/WZjb6zgeY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DmTDblh1tN1+QpEn+UvacJuYWlWX2dRSB1HpSLCWKRADbTV2s8nU+MlZKus2a9l4O MZMTI2ZpJYFLionCOsOPEtRzI0zg5VXm5HhD1gtUuIpoLOn+8qyQNQftQNSHB5drpf gKX+0LkMljb+neOdNispQ6zOL2XfMHnDk94R/+83Zr1s+hWJ9ilNApaeNNuOx6iYqY aiTBgnr9dQ4PJWn6KFf67gNMcQErsXI+2+5mwtfcgYrBnTH13GZXGctPhmHABxSZEp iMabJW1UZyRE2wVX64u+eqynXW/WuchP4U0CnMXVMMHe4a5o7M11C68z5gScVyMDrJ Zz9qqHylVsgJw== Date: Wed, 4 Aug 2021 19:53:32 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20210804022348.1414543-1-chao@kernel.org> <0dad9863-4aa2-3ea3-fd97-457aa635ed66@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0dad9863-4aa2-3ea3-fd97-457aa635ed66@kernel.org> X-Headers-End: 1mBTVw-0007s0-RP Subject: Re: [f2fs-dev] [RFC v3] f2fs: extent cache: support unaligned extent X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 08/05, Chao Yu wrote: > Jaegeuk, > > On 2021/8/5 7:45, Jaegeuk Kim wrote: > > Chao, > > > > How about this? > > https://github.com/jaegeuk/f2fs/commit/d6bbe121bc24dfabfedc07ba7cb6e921fb70ece0 > > Looks more clean, thanks, > > > > > I'm digging one bug in __insert_extent_tree w/ the patch tho. > > Shouldn't we initialize @ei in f2fs_update_extent_tree_range(), otherwise, > __try_merge_extent_node(&ei) -> __is_extent_mergeable() will do the check > w/ uninitialized c_len of @ei. Fixed some bugs, but still getting another data corruption. https://github.com/jaegeuk/f2fs/commit/c5d97919c55b467392407b60c1a7b1e3e81721ff > > > > On 08/04, Chao Yu wrote: > > > > + if (from_dnode) > > > > + goto skip_reading_dnode; > > Wrong condition here, thanks for fixing. > > Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel