From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Yangtao Li <frank.li@vivo.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: always call f2fs_issue_checkpoint() in f2fs_sync_fs()
Date: Mon, 16 Aug 2021 17:32:31 -0700 [thread overview]
Message-ID: <YRsDnwWZwTBFvD0/@google.com> (raw)
In-Reply-To: <20210816132248.276865-1-frank.li@vivo.com>
On 08/16, Yangtao Li wrote:
> Sync is always 1, so delete the check of the value.
I don't think so.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> fs/f2fs/super.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 98727e04d271..b823c7e3f303 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1553,7 +1553,6 @@ static void f2fs_put_super(struct super_block *sb)
> int f2fs_sync_fs(struct super_block *sb, int sync)
> {
> struct f2fs_sb_info *sbi = F2FS_SB(sb);
> - int err = 0;
>
> if (unlikely(f2fs_cp_error(sbi)))
> return 0;
> @@ -1565,10 +1564,7 @@ int f2fs_sync_fs(struct super_block *sb, int sync)
> if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING)))
> return -EAGAIN;
>
> - if (sync)
> - err = f2fs_issue_checkpoint(sbi);
> -
> - return err;
> + return f2fs_issue_checkpoint(sbi);
> }
>
> static int f2fs_freeze(struct super_block *sb)
> --
> 2.32.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2021-08-17 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 13:22 [f2fs-dev] [PATCH] f2fs: always call f2fs_issue_checkpoint() in f2fs_sync_fs() Yangtao Li
2021-08-17 0:32 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRsDnwWZwTBFvD0/@google.com \
--to=jaegeuk@kernel.org \
--cc=frank.li@vivo.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).