From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55768C433EF for ; Thu, 9 Sep 2021 05:23:49 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15A5660EE6 for ; Thu, 9 Sep 2021 05:23:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 15A5660EE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1mOCXL-0000u8-IR; Thu, 09 Sep 2021 05:23:47 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mOCXJ-0000tw-EU for linux-f2fs-devel@lists.sourceforge.net; Thu, 09 Sep 2021 05:23:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=36L5xwoDnvscAaZku6r8ld2neOb9y0N9yPOxldETjQ4=; b=bjVuvzkpQX5A7eBI3/mFVpL3W3 qaoyASvoqc2BZIyZz9yz3V5Rl7MfJwHiW0cLhAG0D31oFt8bQYsLrNy9676OphLBw8NlPtGs2CbWO Yw6tThpgt+wGARCRPhGvpNWyu0dRo3lkJUuBVHXmd5lbGcWJCDMfqV2Rark2g9bbz9xE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=36L5xwoDnvscAaZku6r8ld2neOb9y0N9yPOxldETjQ4=; b=fdCOMUD+gvSz2jsQIamYKkH7M3 o6ATwVJA6dofng0+Okl1cy0EJhjBpq3N8oqDXRybbV0KWPO0XP1uqYgTGmRt//BuorOUQC75aMqEo qzecWBeonzIS4ZdSnX/2RzJD5SQkek7PXwlJoGj/0l1Km5z2ZKBRq6w7AEL+knA0fAlc=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mOCXG-0005DI-H9 for linux-f2fs-devel@lists.sourceforge.net; Thu, 09 Sep 2021 05:23:45 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E6AED61139; Thu, 9 Sep 2021 05:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631165011; bh=2030Fa3YA+ALwsrAEP90On+6Fw88IVjxq61IUtIdhV0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ofdOSHCjC2bZdTClUyhHpLOrIhzmwzJWcdL0oE6HlAgJkAUoggNeenB+naTovUkiK TFp7K/PQM/zgJJVmiFlc9bkZ1cQwTugQs9ROWBSbj2Qa+pvNoGtOHjXLqCdlVuKBOa EP7GkbgykF/eq1z3Hvm1pw1OcmrxvDjyqe30BW7M= Date: Thu, 9 Sep 2021 07:23:08 +0200 From: Greg KH To: Jaegeuk Kim Message-ID: References: <20210908220020.599899-1-jaegeuk@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210908220020.599899-1-jaegeuk@google.com> X-Headers-End: 1mOCXG-0005DI-H9 Subject: Re: [f2fs-dev] [PATCH] f2fs: guarantee to write dirty data when enabling checkpoint back X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim , stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Sep 08, 2021 at 03:00:20PM -0700, Jaegeuk Kim wrote: > From: Jaegeuk Kim > > commit dddd3d65293a52c2c3850c19b1e5115712e534d8 upstream. > > We must flush all the dirty data when enabling checkpoint back. Let's guarantee > that first by adding a retry logic on sync_inodes_sb(). In addition to that, > this patch adds to flush data in fsync when checkpoint is disabled, which can > mitigate the sync_inodes_sb() failures in advance. > > Reviewed-by: Chao Yu > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/file.c | 5 ++--- > fs/f2fs/super.c | 11 ++++++++++- > 2 files changed, 12 insertions(+), 4 deletions(-) What stable kernel(s) are you wanting to have this backported to? thanks, greg k-h _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel