From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F158C433F5 for ; Fri, 10 Sep 2021 22:04:50 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E4C261205 for ; Fri, 10 Sep 2021 22:04:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5E4C261205 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mOodd-0001YG-Hz; Fri, 10 Sep 2021 22:04:49 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOodb-0001Y1-Ov for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Sep 2021 22:04:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GIRIiEz0GoGMLwMyRLQB0RIPrIOVpS9sKcWgEpljY3g=; b=IRjd90EIEfWUGIPTv/Dsbn5Cyb FTNfM5/srftJwUm+AI1u6QcSvyb3KjKhZQe69CYSpibFxnb1oQfMGxLlXSeFW8LCUd7GjPmi1+rUt AhRb0m/mSqnNxq7u4aZQaJn0e77aLj/vvsG4vn6JBQkgVsPkTG6bv2wsyNS7etfRwVyI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GIRIiEz0GoGMLwMyRLQB0RIPrIOVpS9sKcWgEpljY3g=; b=FH4nYRW/Y0jGQKCo3p5RbGUjk0 1OEF4UBZpJJZTuGSVk5MwWZIFlOaJfWXUwlp1S17W1NxU++nEIQbhELusbbDVi/oOxtV5x1yMi/y6 /YutdcA2A12Dn+ziOdt/Tk5WO2fLDIUZFcGBLo1GmnDHfg9DkWrObPPjg6t07qdiYUbQ=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mOoda-0007Hf-1F for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Sep 2021 22:04:47 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7ED4061205; Fri, 10 Sep 2021 22:04:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631311480; bh=3JR8G3EKcM2k1RFRog8eh3eVWwB/J9K7BivJ3sbD6Fk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pXtSl/ycaBYktotlT+4ORlnv9Z/qUhP8nqLgQqNpHQCYecWW9SXSgOrA3aBgs/IzV yuL9gfu2EAGOnSVqMhX90a0ncfB8j8/o/atzmEB0X+8XmtUrUg2SCz68tXEBS42CN0 8DS+9RYF4U26ECgR8dkFqmn0Abzmx1ULUlfPJVbT8kG4r51mQMDN616BcNtBOEjF7f Gh6Czd8Vde8jG6UVaVYs0gVES3N+YP4BhwfJKBtL/VObV7iHgHJiLMbZ2DOjUHjpn4 hXjtl5+BqedzDumhRn9gcp4iigvEZV+JXpu69KOX5xm5Hvd0cmhSWQK2qP2nRCgGbe TPb4iLOOXqplQ== Date: Fri, 10 Sep 2021 15:04:39 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20210901073232.109355-1-chao@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210901073232.109355-1-chao@kernel.org> X-Headers-End: 1mOoda-0007Hf-1F Subject: Re: [f2fs-dev] [PATCH] f2fs: introduce excess_dirty_threshold() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chao Yu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 09/01, Chao Yu wrote: > This patch enables f2fs_balance_fs_bg() to check all metadatas' dirty > threshold rather than just checking node block's, so that checkpoint() > from background can be triggered more frequently to avoid heaping up > too much dirty metadatas. > > Threshold value by default: > race with foreground ops single type global > No 16MB 24MB > Yes 24MB 36MB > > In addtion, let f2fs_balance_fs_bg() be aware of roll-forward sapce > as well as fsync(). > > Signed-off-by: Chao Yu > --- > fs/f2fs/f2fs.h | 3 +++ > fs/f2fs/node.h | 5 ----- > fs/f2fs/segment.c | 23 +++++++++++++++++++++-- > 3 files changed, 24 insertions(+), 7 deletions(-) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 6c5e75f86da4..5ae2ca6dba96 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -562,6 +562,9 @@ enum { > > #define MAX_DIR_RA_PAGES 4 /* maximum ra pages of dir */ > > +/* dirty segments threshold for triggering CP */ > +#define DEFAULT_DIRTY_THRESHOLD 4 > + > /* for in-memory extent cache entry */ > #define F2FS_MIN_EXTENT_LEN 64 /* minimum extent length */ > > diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h > index ff14a6e5ac1c..18b98cf0465b 100644 > --- a/fs/f2fs/node.h > +++ b/fs/f2fs/node.h > @@ -138,11 +138,6 @@ static inline bool excess_cached_nats(struct f2fs_sb_info *sbi) > return NM_I(sbi)->nat_cnt[TOTAL_NAT] >= DEF_NAT_CACHE_THRESHOLD; > } > > -static inline bool excess_dirty_nodes(struct f2fs_sb_info *sbi) > -{ > - return get_pages(sbi, F2FS_DIRTY_NODES) >= sbi->blocks_per_seg * 8; > -} > - > enum mem_type { > FREE_NIDS, /* indicates the free nid list */ > NAT_ENTRIES, /* indicates the cached nat entry */ > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 7358342652ec..ffd148429a9d 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -535,6 +535,25 @@ void f2fs_balance_fs(struct f2fs_sb_info *sbi, bool need) > } > } > > +static inline bool excess_dirty_threshold(struct f2fs_sb_info *sbi) > +{ > + int factor = rwsem_is_locked(&sbi->cp_rwsem) ? 3 : 2; > + unsigned int dents = get_pages(sbi, F2FS_DIRTY_DENTS); > + unsigned int qdata = get_pages(sbi, F2FS_DIRTY_QDATA); > + unsigned int nodes = get_pages(sbi, F2FS_DIRTY_NODES); > + unsigned int meta = get_pages(sbi, F2FS_DIRTY_META); > + unsigned int imeta = get_pages(sbi, F2FS_DIRTY_IMETA); > + unsigned int threshold = sbi->blocks_per_seg * factor * > + DEFAULT_DIRTY_THRESHOLD; > + unsigned int global_threshold = threshold * 3 / 2; > + > + if (dents >= threshold || qdata >= threshold || > + nodes >= threshold || meta >= threshold || > + imeta >= threshold) > + return true; > + return dents + qdata + nodes + meta + imeta > global_threshold; > +} > + > void f2fs_balance_fs_bg(struct f2fs_sb_info *sbi, bool from_bg) > { > if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING))) > @@ -553,8 +572,8 @@ void f2fs_balance_fs_bg(struct f2fs_sb_info *sbi, bool from_bg) > else > f2fs_build_free_nids(sbi, false, false); > > - if (excess_dirty_nats(sbi) || excess_dirty_nodes(sbi) || > - excess_prefree_segs(sbi)) > + if (excess_dirty_nats(sbi) || excess_dirty_threshold(sbi) || > + excess_prefree_segs(sbi) || f2fs_space_for_roll_forward(sbi)) f2fs_space_for_roll_forward() == 0? > goto do_sync; > > /* there is background inflight IO or foreground operation recently */ > -- > 2.32.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel