From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: tanghuan <tanghuan@vivo.com>,
Fengnan Chang <changfengnan@vivo.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix whint_mode mount option error
Date: Tue, 28 Sep 2021 12:08:41 -0700 [thread overview]
Message-ID: <YVNoObi/kRt5OMFz@google.com> (raw)
In-Reply-To: <6c114c4d-7e02-9d4e-7308-0810aa31339d@kernel.org>
On 09/28, Chao Yu wrote:
> On 2021/9/27 14:09, Fengnan Chang wrote:
> > When mount with whint_mode option, it doesn't work, Fix it.
> > Fixes: d0b9e42ab615 (f2fs: introduce inmem curseg)
>
> Thanks for the patch, it looks Keoseong Park has submitted the same
> fix patch a little bit earlier....
>
> I guess we need to select one of your patches, and merge Singed-off
> and Reported tags from another one.
Merged with SOB and Reported-by.
>
> Thanks,
>
> >
> > Reported-by: tanghuan <tanghuan@vivo.com>
> > Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
> > ---
> > fs/f2fs/super.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> > index 78ebc306ee2b..86eeb019cc52 100644
> > --- a/fs/f2fs/super.c
> > +++ b/fs/f2fs/super.c
> > @@ -1292,7 +1292,7 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
> > /* Not pass down write hints if the number of active logs is lesser
> > * than NR_CURSEG_PERSIST_TYPE.
> > */
> > - if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_TYPE)
> > + if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_PERSIST_TYPE)
> > F2FS_OPTION(sbi).whint_mode = WHINT_MODE_OFF;
> > if (f2fs_sb_has_readonly(sbi) && !f2fs_readonly(sbi->sb)) {
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2021-09-28 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 6:09 [f2fs-dev] [PATCH] f2fs: fix whint_mode mount option error Fengnan Chang via Linux-f2fs-devel
2021-09-28 15:32 ` Chao Yu
2021-09-28 19:08 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVNoObi/kRt5OMFz@google.com \
--to=jaegeuk@kernel.org \
--cc=changfengnan@vivo.com \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=tanghuan@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).