From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45078C433EF for ; Wed, 27 Oct 2021 22:40:36 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BD2660231 for ; Wed, 27 Oct 2021 22:40:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0BD2660231 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mfrb1-0000O1-4o; Wed, 27 Oct 2021 22:40:33 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mfraz-0000Np-IL for linux-f2fs-devel@lists.sourceforge.net; Wed, 27 Oct 2021 22:40:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iWF/YNor2JSMnupn32Wk/02g21ycx7A3oYTrbqnUVdY=; b=ffGdmKXv3aYQZpaqudqEoQbrRk WHqECRLmpiLVDSAIV7OIAPvfQNqBLmW433Fg15i9JOKvFqu14dsUxBRZtpE9sHydecNQXmVpWlHzs KcuLr3PijO2ccdLWAWBv2YeFWZhxY20cXSWCod1eJOxpUntfh25cNUkF9obQ/rEU3mYY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iWF/YNor2JSMnupn32Wk/02g21ycx7A3oYTrbqnUVdY=; b=TczlTXTlU/KEaFIpkYjMJiQNwW FeTiA37G5ENkkj0MJwOjQjC2k85xcA1UH/WCjtH1qDWVxi6gHPKTjbATXNH+wanE4G5H+tSgnvu/s v2LrXxn+5wPXBjlmXfghtZJm0cQ4mVNJxsvHBygLToMANImNmnuqlN5GuIK0oo/NrE/k=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mfrVA-0003Yb-3H for linux-f2fs-devel@lists.sourceforge.net; Wed, 27 Oct 2021 22:40:32 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B4A7060EBD; Wed, 27 Oct 2021 22:34:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635374061; bh=4SqiEoUxJz4vtG++4/zpHHHXF6cTsG3IDqC+tBAV7BE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d1nbimgnUwu6ytcWSdSaArsq65+JkZFDoLif7EkFAQ8WHU3MX54WUEux3Av50svpQ wf4w1OqedzwetZ8vWSbmM1EduhPPR0TATul/CtZEV660GawZFZ46RkApwjRxwDrG96 ihV7BTLZt6eEaHegdcKQbZsuajei28HAsHsdWD4/cWz8ZrX63wlw06lknPPRqsgXNn H23kwiDxVpRGt+sFIFXbxVLC8VIrEykXvp9ocBS/vH3OQMikto3PBcVBWe91gImCWi ChgBlLlCx1zo9my4ngeFNFoEjVBO8dVeS1lwwbDmPuU66fW/Xz8lCw7rOlpQoRhhe3 GxciBF6wlzCNQ== Date: Wed, 27 Oct 2021 15:34:20 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20210922152705.720071-1-chao@kernel.org> <20210924095021.GA16651@duo.ucw.cz> <4897a06a-9f9e-27ce-91d3-58721bee42ac@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4897a06a-9f9e-27ce-91d3-58721bee42ac@kernel.org> X-Headers-End: 1mfrVA-0003Yb-3H Subject: Re: [f2fs-dev] [PATCH] f2fs: fix incorrect return value in f2fs_sanity_check_ckpt() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pavel Machek , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Could you post the patch again? I don't see this in my box. On 10/27, Chao Yu wrote: > Jaegeuk, > > Missed to apply this patch? > > Thanks, > > On 2021/9/24 17:50, Pavel Machek wrote: > > Hi! > > > > > This code looks quite confused: part of function returns 1 on > > > corruption, part returns -errno. The problem is not stable-specific. > > > > > > [1] https://lkml.org/lkml/2021/9/19/207 > > > > > > Let's fix to make 'insane cp_payload case' to return 1 rater than > > > EFSCORRUPTED, so that return value can be kept consistent for all > > > error cases, it can avoid confusion of code logic. > > > > > > Fixes: 65ddf6564843 ("f2fs: fix to do sanity check for sb/cp fields correctly") > > > Reported-by: Pavel Machek > > > Signed-off-by: Chao Yu > > > > Reviewed-by: Pavel Machek > > > > (This is good minimal fix, but eventually I believe the function > > should switch to 0/-errno... for consistency with rest of kernel). > > > > Thank you, > > Pavel > > > > > +++ b/fs/f2fs/super.c > > > @@ -3487,7 +3487,7 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi) > > > NR_CURSEG_PERSIST_TYPE + nat_bits_blocks >= blocks_per_seg)) { > > > f2fs_warn(sbi, "Insane cp_payload: %u, nat_bits_blocks: %u)", > > > cp_payload, nat_bits_blocks); > > > - return -EFSCORRUPTED; > > > + return 1; > > > } > > > if (unlikely(f2fs_cp_error(sbi))) { > > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel