From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 680F8C433EF for ; Thu, 2 Dec 2021 21:28:48 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mstdH-0006M0-Iu; Thu, 02 Dec 2021 21:28:47 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mstdG-0006Lu-Ew for linux-f2fs-devel@lists.sourceforge.net; Thu, 02 Dec 2021 21:28:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=o7NLP2DMrKhILNV9rV4jTAOsAcSYjE4xZXDT0Nzn48k=; b=BXyqAp4ziCwMOd6oQJ1NxpXju5 ENh+DfK+rWW/jQH5yavHj3fOVY8kiYRslWlB4YzkGvHqE0Eo7EHK5fijibOguupepHw5wz06HgVVE tylR6Pfe5MpvL+kMZ4m6meyDIYuD7saWaXLF8dGZ3RIIt292uPwqGWI1KVCi/oPrz56w=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=o7NLP2DMrKhILNV9rV4jTAOsAcSYjE4xZXDT0Nzn48k=; b=leUEmR0yU7bXtOe7If5jWrMpWP 4j/VWm699TDFIAWOH/i8FlsFkXe1yhLhprm/W3k6KHarvS3y6PJQ4l0iyDNFuYvtMwHdPZQqz4o6F 3elpcyDc8A1K++UAL3LGDEFW9rX8gEF2YMhlHNkyss+iPLyNz6+9fPHzfUNB3tQWflBc=; Received: from sin.source.kernel.org ([145.40.73.55]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mstdE-0002Oq-An for linux-f2fs-devel@lists.sourceforge.net; Thu, 02 Dec 2021 21:28:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id C5670CE23FC for ; Thu, 2 Dec 2021 21:28:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0ACEC00446; Thu, 2 Dec 2021 21:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638480516; bh=jk2dq844Et2Vb6nBznE+RG8/97FPagFPguWx2YhztoY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZaR/4nEsCbBi6QA1jsfLvobwAGtRvQ2+V9oDytXiR0DPl/pucx+tepyjamfz0hdQG Dios2S8iW6AfsxLcU2f2SXlQkyIRdCQukGwYG/t18ZiXGzZI64UsiX72372UUoFpyb kPKv87252agC8KSqYoapwQi3DFFR3RG+VhX5xSwSmV55xPld5d7G+liElrmD2TKC9g b8rz1AqzDywhbLJLBXI+BMJvkyXKgPR9YKRI2sINNOnkI7AFrVldiXEA75p9yHvl2g UR1u/LgjQ0DdX7vDCU11UTkxG4n1d1cmcOXtGesFFdQ/Z/be3+RCuAMB0TDVz9uj7S c+RTj47FUoXwg== Date: Thu, 2 Dec 2021 13:28:34 -0800 From: Jaegeuk Kim To: Eric Biggers Message-ID: References: <20211116214510.2934905-1-jaegeuk@kernel.org> <20211116214510.2934905-5-jaegeuk@kernel.org> <1ba0f002-42c7-b085-0c54-6071664ba79b@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1mstdE-0002Oq-An Subject: Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 12/02, Jaegeuk Kim wrote: > On 12/02, Eric Biggers wrote: > > On Thu, Dec 02, 2021 at 11:00:47AM -0800, Jaegeuk Kim wrote: > > > On 12/02, Jaegeuk Kim wrote: > > > > On 12/02, Eric Biggers wrote: > > > > > On Thu, Dec 02, 2021 at 10:04:11PM +0800, Chao Yu wrote: > > > > > > On 2021/12/2 12:15, Eric Biggers wrote: > > > > > > > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: > > > > > > > > Why not relocating this check before f2fs_map_blocks()? > > > > > > > > > > > > Wait, it supports DIO in multi-device image after commit 71f2c8206202 > > > > > > ("f2fs: multidevice: support direct IO"), how about > > > > > > checking with f2fs_allow_multi_device_dio()? > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > Okay, that was not the case when I sent this patch originally. We'll need to > > > > > update this to support multiple devices. > > > > > > > > Chao/Eric, does this make sense? > > > > > > > > --- a/fs/f2fs/data.c > > > > +++ b/fs/f2fs/data.c > > > > @@ -4070,11 +4070,10 @@ static int f2fs_iomap_begin(struct inode *inode, loff_t offset, loff_t length, > > > > } > > > > if (WARN_ON_ONCE(!__is_valid_data_blkaddr(map.m_pblk))) > > > > return -EINVAL; > > > > - iomap->addr = blks_to_bytes(inode, map.m_pblk); > > > > > > > > - if (WARN_ON_ONCE(f2fs_is_multi_device(F2FS_I_SB(inode)))) > > > > - return -EINVAL; > > > > - iomap->bdev = inode->i_sb->s_bdev; > > > > + iomap->bdev = map->m_multidev_dio ? map.m_bdev : > > > > > > correction: map.m_multidev_dio > > > > > > > I guess so, but why doesn't f2fs_map_blocks() just always set m_bdev to the > > correct block device? What is the point of m_multidev_dio? > > It seems we can simply assign iomap->bdev = map.m_bdev, and remove > map->m_multidev_dio. Ok, it was used in previous get_block flow, but I think it'd be worth to keep it to show by f2fs_map_blocks tracepoint. > > > > > - Eric > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel